Re: [PATCH 6/9] block/accounting: Emit BLOCK_IO_DELAY event

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 8036 bytes --]

On Mon, Aug 31, 2026 at 03:52:02PM +0200, Hanna Czenczek wrote:
> When a request finishes with a higher latency than a predefined
> threshold, emit the BLOCK_IO_DELAY event.
> 
> Note there would be an alternative, more precise solution: We could keep
> all active cookies per BlockBackend in a list and repeatedly iterate
> over it in a background coroutine (woken on a timer so it would wake
> always exactly when the next request would time out, so it generally
> stays asleep until there is actually a timeout). This way, we could emit
> the event exactly when a request crosses the delay threshold, while it
> is still running; and we could hypothetically even take actions like
> pausing the VM until the request is done so the guest operating system
> is shielded from extreme latency spikes.
> 
> In practice, this is very complicated because latency cookies are
> created and finalized all over the place, so it is very hard to
> guarantee that every `block_acct_start()` is matched by the right
> finalization to ensure that cookies are properly removed from the list
> when they are done. Even if we fix all non-matching places now, there is
> hardly a guarantee this will be kept in order in the future.

I think this patch series already couples the accounting so closely with
BlockBackend (i.e. adding the offset field into the cookie struct and
adding a BB pointer into the stats struct) that we might as well fully
integrate the two. Then callers don't need to manually manage cookies
because BlockBackend does that internally and the concerns about
lifetimes go away.

> 
> So, for now, just implement the simpler solution of only notifying the
> management layer when the request does complete, so VMs with high
> latency spikes can at least be identified when they happen without
> having to regularly check the latency histogram.
> 
> Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
> ---
>  include/block/accounting.h | 10 ++++++++-
>  block/accounting.c         | 42 +++++++++++++++++++++++++++++++++++++-
>  blockdev.c                 |  2 +-
>  hw/block/block.c           |  2 +-
>  4 files changed, 52 insertions(+), 4 deletions(-)
> 
> diff --git a/include/block/accounting.h b/include/block/accounting.h
> index 025536239e6..ba3a6859cf4 100644
> --- a/include/block/accounting.h
> +++ b/include/block/accounting.h
> @@ -92,6 +92,7 @@ struct BlockAcctStats {
>      QSLIST_HEAD(, BlockAcctTimedStats) intervals;
>      bool account_invalid;
>      bool account_failed;
> +    int64_t delay_threshold_ns;
>      BlockLatencyHistogram latency_histogram[BLOCK_MAX_IOTYPE];
>  };
>  
> @@ -103,9 +104,16 @@ typedef struct BlockAcctCookie {
>  } BlockAcctCookie;
>  
>  void block_acct_init(BlockBackend *blk, BlockAcctStats *stats);
> +/**
> + * Set up accounting for a block device in @stats.
> + * @alert_ns specifies a latency so that if any request takes longer than that
> + * threshold, a BLOCK_IO_DELAY event will be generated (when that request
> + * completes). Pass 0 to disable.
> + */
>  bool block_acct_setup(BlockAcctStats *stats, enum OnOffAuto account_invalid,
>                        enum OnOffAuto account_failed, uint32_t *stats_intervals,
> -                      uint32_t num_stats_intervals, Error **errp);
> +                      uint32_t num_stats_intervals, int64_t alert_ns,

There are a few names for the same thing:
- delay_threshold_ns
- alert_ns
- BLOCK_IO_DELAY

Pick one and use it consistently?

> +                      Error **errp);
>  void block_acct_cleanup(BlockAcctStats *stats);
>  void block_acct_add_interval(BlockAcctStats *stats, unsigned interval_length);
>  BlockAcctTimedStats *block_acct_interval_next(BlockAcctStats *stats,
> diff --git a/block/accounting.c b/block/accounting.c
> index a74551d41f2..debf1924455 100644
> --- a/block/accounting.c
> +++ b/block/accounting.c
> @@ -27,8 +27,10 @@
>  #include "block/accounting.h"
>  #include "block/block_int.h"
>  #include "qemu/timer.h"
> +#include "system/block-backend.h"
>  #include "system/qtest.h"
>  #include "qapi/error.h"
> +#include "qapi/qapi-events-block.h"
>  
>  static QEMUClockType clock_type = QEMU_CLOCK_REALTIME;
>  static const int qtest_latency_ns = NANOSECONDS_PER_SECOND / 1000;
> @@ -62,9 +64,35 @@ static bool bool_from_onoffauto(OnOffAuto val, bool def)
>      }
>  }
>  
> +/**
> + * Convert a BlockAcctType into its QAPI equivalent IoAccountingOperation.
> + *
> + * Must only be called for valid BlockAcctType values, i.e. specifically not for
> + * `BLOCK_ACCT_NONE`.
> + */
> +static IoAccountingOperation block_acct_qapi_type(enum BlockAcctType type)
> +{
> +    switch (type) {
> +    case BLOCK_ACCT_READ:
> +        return IO_ACCOUNTING_OPERATION_READ;
> +    case BLOCK_ACCT_WRITE:
> +        return IO_ACCOUNTING_OPERATION_WRITE;
> +    case BLOCK_ACCT_FLUSH:
> +        return IO_ACCOUNTING_OPERATION_FLUSH;
> +    case BLOCK_ACCT_ZONE_APPEND:
> +        return IO_ACCOUNTING_OPERATION_ZONE_APPEND;
> +    case BLOCK_ACCT_UNMAP:
> +        return IO_ACCOUNTING_OPERATION_UNMAP;
> +    case BLOCK_ACCT_NONE:
> +    default:
> +        g_assert_not_reached();
> +    }
> +}
> +
>  bool block_acct_setup(BlockAcctStats *stats, enum OnOffAuto account_invalid,
>                        enum OnOffAuto account_failed, uint32_t *stats_intervals,
> -                      uint32_t num_stats_intervals, Error **errp)
> +                      uint32_t num_stats_intervals, int64_t alert_ns,
> +                      Error **errp)
>  {
>      stats->account_invalid = bool_from_onoffauto(account_invalid,
>                                                   stats->account_invalid);
> @@ -79,6 +107,7 @@ bool block_acct_setup(BlockAcctStats *stats, enum OnOffAuto account_invalid,
>              block_acct_add_interval(stats, stats_intervals[i]);
>          }
>      }
> +    stats->delay_threshold_ns = alert_ns;
>      return true;
>  }
>  
> @@ -252,6 +281,17 @@ static void block_account_one_io(BlockAcctStats *stats, BlockAcctCookie *cookie,
>          return;
>      }
>  
> +    if (stats->delay_threshold_ns && latency_ns > stats->delay_threshold_ns) {
> +        g_autofree char *dev_path = blk_get_attached_dev_path(stats->blk);
> +        double latency = latency_ns / (double)NANOSECONDS_PER_SECOND;
> +
> +        qapi_event_send_block_io_delay(dev_path,
> +                                       block_acct_qapi_type(cookie->type),
> +                                       latency,
> +                                       cookie->offset >= 0, cookie->offset,
> +                                       cookie->bytes);
> +    }
> +
>      WITH_QEMU_LOCK_GUARD(&stats->lock) {
>          if (failed) {
>              stats->failed_ops[cookie->type]++;
> diff --git a/blockdev.c b/blockdev.c
> index 6e86c6262f9..195bac8af01 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -618,7 +618,7 @@ static BlockBackend *blockdev_init(const char *file, QDict *bs_opts,
>          bs->detect_zeroes = detect_zeroes;
>  
>          block_acct_setup(blk_get_stats(blk), account_invalid, account_failed,
> -                         NULL, 0, NULL);
> +                         NULL, 0, 0, NULL);
>  
>          if (!parse_stats_intervals(blk_get_stats(blk), interval_list, errp)) {
>              blk_unref(blk);
> diff --git a/hw/block/block.c b/hw/block/block.c
> index f187fa025d0..19301c6f995 100644
> --- a/hw/block/block.c
> +++ b/hw/block/block.c
> @@ -251,7 +251,7 @@ bool blkconf_apply_backend_options(BlockConf *conf, bool readonly,
>  
>      if (!block_acct_setup(blk_get_stats(blk), conf->account_invalid,
>                            conf->account_failed, conf->stats_intervals,
> -                          conf->num_stats_intervals, errp)) {
> +                          conf->num_stats_intervals, 0, errp)) {
>          return false;
>      }
>      return true;
> -- 
> 2.55.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]