All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arvind Yadav <arvind.yadav@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: rodrigo.vivi@intel.com, badal.nilawar@intel.com,
	michal.wajdeczko@intel.com, himal.prasad.ghimiray@intel.com,
	dnyaneshwar.bhadane@intel.com, mallesh.koujalagi@intel.com,
	matthew.brost@intel.com
Subject: [PATCH v6 2/4] drm/xe/guc: Report reset failure using SIGID
Date: Tue,  1 Sep 2026 12:00:57 +0530	[thread overview]
Message-ID: <20260901063059.2547247-3-arvind.yadav@intel.com> (raw)
In-Reply-To: <20260901063059.2547247-1-arvind.yadav@intel.com>

Route the GuC submit engine reset failure through the structured SIGID
logging helper.

Use the GUCSUBMIT component, which maps to XE_SIGID_GT_TDR, and pass -EIO
as the errno value.

Cc: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
Cc: Badal Nilawar <badal.nilawar@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Suggested-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Arvind Yadav <arvind.yadav@intel.com>
---
v6:
 - Updated the log message to print class/instance as %u:%u and
   reason as %#x. (Michal)

v5:
 - Added GUCSUBMIT component and mapped it to XE_SIGID_GT_TDR.
   (Michal)
 - Used GUCSUBMIT instead of GT for the GuC submit reset failure.
   (Michal)
 - Dropped "request" from the reset failure message.
   (Michal)

v4:
 - Clarified that the GT component maps to XE_SIGID_GT_TDR and -EIO is
   only the errno value. (Sashiko)

v3:
 - Split the GuC reset-request failure conversion into a separate patch.
   (Michal)
 - Dropped GuC job-timeout warning conversions to avoid changing warn-level
   logs into error-level SIGID reports. (Michal)
 - Kept only the existing error path that maps naturally to GT_TDR. (Michal)

v2:
 - Rebased on the latest structured SIGID logging series.
 - Switched from the old xe_ras_log_() helpers to the new xe_log_()
   helpers.
 - Dropped paths already covered by the base SIGID series.

 drivers/gpu/drm/xe/xe_guc_submit.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index 99d8c807ff05..1df6527130f3 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -34,6 +34,7 @@
 #include "xe_guc_klv_helpers.h"
 #include "xe_guc_submit_types.h"
 #include "xe_hw_engine.h"
+#include "xe_log.h"
 #include "xe_lrc.h"
 #include "xe_macros.h"
 #include "xe_map.h"
@@ -3494,8 +3495,9 @@ int xe_guc_exec_queue_reset_failure_handler(struct xe_guc *guc, u32 *msg, u32 le
 	reason = msg[2];
 
 	/* Unexpected failure of a hardware feature, log an actual error */
-	xe_gt_err(gt, "GuC engine reset request failed on %d:%d because 0x%08X",
-		  guc_class, instance, reason);
+	xe_log_err(gt, GUCSUBMIT, -EIO,
+		   "engine reset failed on %u:%u, reason=%#x\n",
+		   guc_class, instance, reason);
 
 	xe_gt_reset_async(gt);
 
-- 
2.43.0


  parent reply	other threads:[~2026-09-01  6:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01  6:30 [PATCH v6 0/4] drm/xe: Report GT TDR and VM rebind faults using SIGID Arvind Yadav
2026-09-01  6:30 ` [PATCH v6 1/4] drm/xe/log: Add GUCSUBMIT component Arvind Yadav
2026-09-02 12:33   ` Michal Wajdeczko
2026-09-03  3:16     ` Yadav, Arvind
2026-09-01  6:30 ` Arvind Yadav [this message]
2026-09-02 12:36   ` [PATCH v6 2/4] drm/xe/guc: Report reset failure using SIGID Michal Wajdeczko
2026-09-01  6:30 ` [PATCH v6 3/4] drm/xe/svm: Report terminal page-fault failures " Arvind Yadav
2026-09-02 11:54   ` Mallesh, Koujalagi
2026-09-02 12:43   ` Michal Wajdeczko
2026-09-03  3:44     ` Yadav, Arvind
2026-09-01  6:30 ` [PATCH v6 4/4] drm/xe/gt: Report GT reset failure " Arvind Yadav
2026-09-02 11:45   ` Mallesh, Koujalagi
2026-09-02 12:51   ` Michal Wajdeczko
2026-09-03  4:32     ` Yadav, Arvind
2026-09-01  6:39 ` ✓ CI.KUnit: success for drm/xe: Report GT TDR and VM rebind faults using SIGID (rev6) Patchwork
2026-09-01  7:20 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-01  8:27 ` ✗ Xe.CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260901063059.2547247-3-arvind.yadav@intel.com \
    --to=arvind.yadav@intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=dnyaneshwar.bhadane@intel.com \
    --cc=himal.prasad.ghimiray@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=mallesh.koujalagi@intel.com \
    --cc=matthew.brost@intel.com \
    --cc=michal.wajdeczko@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.