Re: [PATCH v6 1/4] drm/xe/log: Add GUCSUBMIT component

["Yadav, Arvind" <arvind.yadav@intel.com>]

On 02-09-2026 18:03, Michal Wajdeczko wrote:
>
> On 9/1/2026 8:30 AM, Arvind Yadav wrote:
>> Add a GUCSUBMIT component for structured SIGID logging.
>>
>> GuC submit failures can still map to an existing SIGID, but using the
>> generic GT component hides the source of the report. Add GUCSUBMIT as
>> a DRIVER component and map it to XE_SIGID_GT_TDR.
> nit: can we improve the commit message? maybe
>
>   "The proper SIGID for the GuC submission failures is GT_TDR, but use
>   "of the generic GT component may hide the real source of the report.
>   "Add GUCSUBMIT as a DRIVER component and map it to XE_SIGID_GT_TDR.


Noted, I will update the commit message.

>> Cc: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
>> Cc: Badal Nilawar <badal.nilawar@intel.com>
>> Cc: Matthew Brost <matthew.brost@intel.com>
>> Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
>> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Suggested-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> Signed-off-by: Arvind Yadav <arvind.yadav@intel.com>
>> ---
>> v6:
>>   - Moved GUCSUBMIT from DRIVER_FIRMWARE to DRIVER, since GuC submit
>>     is a driver submission component and not a firmware component.
>>     (Michal)
>>
>>   drivers/gpu/drm/xe/abi/xe_log_abi.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/xe/abi/xe_log_abi.h b/drivers/gpu/drm/xe/abi/xe_log_abi.h
>> index d6105520173e..91fe983ad917 100644
>> --- a/drivers/gpu/drm/xe/abi/xe_log_abi.h
>> +++ b/drivers/gpu/drm/xe/abi/xe_log_abi.h
>> @@ -144,6 +144,7 @@ enum xe_log_location_bits {
>>   	define(DRIVER, 4, RTP, SW, "Register Table Processing")			\
>>   	define(DRIVER, 5, WA, SW, "Workarounds")				\
>>   	define(DRIVER, 6, PAGEFAULT, MEM_FAULT, "Page Fault")			\
>> +	define(DRIVER, 7, GUCSUBMIT, GT_TDR, "GuC Submit")			\
> nit: we can have "GuC Submission" as a full name


Noted,


~Arvind

>
> Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
>>   	/* */									\
>>   	define(DRIVER_HARDWARE, 1, REGS, IO_BUS, "Registers")			\
>>   	define(DRIVER_HARDWARE, 2, GGTT, IO_BUS, "Global GTT")			\