Re: [PATCH v6 4/4] drm/xe/gt: Report GT reset failure using SIGID

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

On 9/1/2026 8:30 AM, Arvind Yadav wrote:
> Route the GT reset failure log through the structured SIGID logging helper.
> 
> Failure to complete the full graphics reset means GT reset did not finish
> as expected. Use the GT component, which maps to XE_SIGID_GT_TDR, and pass
> the reset errno value to the helper.
> 
> Also update the message to describe the actual failure. The driver does not
> clear GRDOM_FULL directly. the reset should complete and clear it within

The reset ...

> the timeout.
> 
> Cc: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
> Cc: Badal Nilawar <badal.nilawar@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Suggested-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
> Signed-off-by: Arvind Yadav <arvind.yadav@intel.com>
> ---
> v6:
>  - Corrected the GT reset timeout in the log message to 5 ms.
>    (sashiko)
> 
> v5:
>  - Kept this patch limited to the GT reset failure path. (Michal)
>  - Improved the GRDOM_FULL failure message to describe that full graphics
>    reset did not complete. (Michal)
> 
>  drivers/gpu/drm/xe/xe_gt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
> index 6805e0d3bf21..d72c7ec9a956 100644
> --- a/drivers/gpu/drm/xe/xe_gt.c
> +++ b/drivers/gpu/drm/xe/xe_gt.c
> @@ -824,8 +824,8 @@ static int do_gt_reset(struct xe_gt *gt)
>  	xe_mmio_write32(&gt->mmio, GDRST, GRDOM_FULL);
>  	err = xe_mmio_wait32(&gt->mmio, GDRST, GRDOM_FULL, 0, 5000, NULL, false);
>  	if (err)
> -		xe_gt_err(gt, "failed to clear GRDOM_FULL (%pe)\n",
> -			  ERR_PTR(err));
> +		xe_log_err(gt, GT, err,
> +			   "full graphics reset not completed in 5 ms\n");

hardcoding timeout value in the message seems wrong, to make it properly:

#define GRDOM_RESET_TIMEOUT_MS	5			/* 5 ms */
or
#define GRDOM_RESET_TIMEOUT_US	(5 * USEC_PER_MSEC)	/* 5 ms */

then
	xe_mmio_wait32(... GRDOM_RESET_TIMEOUT_MS * USEC_PER_MSEC, ...)
or
	xe_mmio_wait32(... GRDOM_RESET_TIMEOUT_US, ...)

and
	xe_log(... in %u ms\n", GRDOM_RESET_TIMEOUT_MS);
or
	xe_log(... in %u ms\n", GRDOM_RESET_TIMEOUT_US / USEC_PER_MSEC);
>  
>  	xe_gsc_wa_14015076503(gt, false);
>