All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] system: improve -mon deprecation warning
@ 2026-09-02 10:47 Daniel P. Berrangé
  2026-09-02 12:02 ` Peter Maydell
  2026-09-03 10:22 ` Philippe Mathieu-Daudé
  0 siblings, 2 replies; 3+ messages in thread
From: Daniel P. Berrangé @ 2026-09-02 10:47 UTC (permalink / raw)
  To: qemu-devel
  Cc: Paolo Bonzini, Peter Maydell, Markus Armbruster,
	Daniel P. Berrangé

Expand the text a bit to make the new syntax more explicit and point
users to the man page for further info.

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 system/vl.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/system/vl.c b/system/vl.c
index eded498fa7..d1d9209038 100644
--- a/system/vl.c
+++ b/system/vl.c
@@ -3239,8 +3239,13 @@ void qemu_init(int argc, char **argv)
                 default_monitor = 0;
                 break;
             case QEMU_OPTION_mon:
-                warn_report_once("'-mon' is deprecated, use '-object' with "
-                                 "'monitor-hmp' or 'monitor-qmp' types instead");
+                warn_report_once(
+                    "'-mon' is deprecated. Switch to either "
+                    "'-object monitor-hmp,id=ID,chardev=CHR-ID' or "
+                    "'-object monitor-qmp,id=ID,chardev=CHR-ID' instead. "
+                    "See '-object' docs in the QEMU manual for further "
+                    "configuration guidance: "
+                    "https://www.qemu.org/docs/master/system/invocation.html");
                 if (!qemu_opts_parse_noisily(qemu_find_opts("mon"), optarg,
                                              true)) {
                     exit(1);
-- 
2.55.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] system: improve -mon deprecation warning
  2026-09-02 10:47 [PATCH v2] system: improve -mon deprecation warning Daniel P. Berrangé
@ 2026-09-02 12:02 ` Peter Maydell
  2026-09-03 10:22 ` Philippe Mathieu-Daudé
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2026-09-02 12:02 UTC (permalink / raw)
  To: Daniel P. Berrangé; +Cc: qemu-devel, Paolo Bonzini, Markus Armbruster

On Wed, 2 Sept 2026 at 11:48, Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> Expand the text a bit to make the new syntax more explicit and point
> users to the man page for further info.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  system/vl.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/system/vl.c b/system/vl.c
> index eded498fa7..d1d9209038 100644
> --- a/system/vl.c
> +++ b/system/vl.c
> @@ -3239,8 +3239,13 @@ void qemu_init(int argc, char **argv)
>                  default_monitor = 0;
>                  break;
>              case QEMU_OPTION_mon:
> -                warn_report_once("'-mon' is deprecated, use '-object' with "
> -                                 "'monitor-hmp' or 'monitor-qmp' types instead");
> +                warn_report_once(
> +                    "'-mon' is deprecated. Switch to either "
> +                    "'-object monitor-hmp,id=ID,chardev=CHR-ID' or "
> +                    "'-object monitor-qmp,id=ID,chardev=CHR-ID' instead. "
> +                    "See '-object' docs in the QEMU manual for further "
> +                    "configuration guidance: "
> +                    "https://www.qemu.org/docs/master/system/invocation.html");
>                  if (!qemu_opts_parse_noisily(qemu_find_opts("mon"), optarg,
>                                               true)) {
>                      exit(1);
> --

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] system: improve -mon deprecation warning
  2026-09-02 10:47 [PATCH v2] system: improve -mon deprecation warning Daniel P. Berrangé
  2026-09-02 12:02 ` Peter Maydell
@ 2026-09-03 10:22 ` Philippe Mathieu-Daudé
  1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2026-09-03 10:22 UTC (permalink / raw)
  To: Daniel P. Berrangé, qemu-devel
  Cc: Paolo Bonzini, Peter Maydell, Markus Armbruster

On 2/9/26 12:47, Daniel P. Berrangé wrote:
> Expand the text a bit to make the new syntax more explicit and point
> users to the man page for further info.
> 
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   system/vl.c | 9 +++++++--
>   1 file changed, 7 insertions(+), 2 deletions(-)

Patch queued, thanks.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-09-03 10:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-02 10:47 [PATCH v2] system: improve -mon deprecation warning Daniel P. Berrangé
2026-09-02 12:02 ` Peter Maydell
2026-09-03 10:22 ` Philippe Mathieu-Daudé

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.