All of lore.kernel.org
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: John Erasmus Mari Geronimo <johnerasmusmari.geronimo@analog.com>
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, robh@kernel.org, sre@kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: power: supply: add adi,lt8491.yaml
Date: Thu, 3 Sep 2026 18:21:27 +0100	[thread overview]
Message-ID: <20260903-tapered-subsoil-a3ade82e1253@spud> (raw)
In-Reply-To: <4cf7fe04accbd558c4f0aa3da2f648b8144993be.1788432152.git.johnerasmusmari.geronimo@analog.com>

[-- Attachment #1: Type: text/plain, Size: 4261 bytes --]

On Thu, Sep 03, 2026 at 06:46:36PM +0800, John Erasmus Mari Geronimo wrote:
> Add documentation for devicetree bindings for LT8491
> 
> Signed-off-by: John Erasmus Mari Geronimo <johnerasmusmari.geronimo@analog.com>
> ---
>  .../bindings/power/supply/adi,lt8491.yaml     | 92 +++++++++++++++++++
>  MAINTAINERS                                   |  6 ++
>  2 files changed, 98 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/supply/adi,lt8491.yaml
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/adi,lt8491.yaml b/Documentation/devicetree/bindings/power/supply/adi,lt8491.yaml
> new file mode 100644
> index 0000000000000..bb364b48fee58
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/adi,lt8491.yaml
> @@ -0,0 +1,92 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/supply/adi,lt8491.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Linear Technology (Analog Devices) LT8491 Battery Charger
> +
> +maintainers:
> +  - John Erasmus Mari Geronimo <johnerasmusmari.geronimo@analog.com>
> +
> +description: |
> +  The LT8491 is a buck-boost switching regulator battery charger that implements
> +  a constant-current constant-voltage (CCCV) charging profile used for most
> +  battery types, including sealed lead-acid (SLA), flooded, gel and lithium-ion.
> +
> +  Specifications about the charger can be found at:
> +    https://www.analog.com/en/products/lt8491.html
> +
> +allOf:
> +  - $ref: power-supply.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - adi,lt8491
> +
> +  reg:
> +    maxItems: 1
> +
> +  adi,rsense1-micro-ohms:
> +    description: Resistance value of RSENSE1 in micro ohms.
> +
> +  adi,rimon-out-ohms:
> +    description: Resistance value of RIMON_OUT in ohms.
> +
> +  adi,rsense2-micro-ohms:
> +    description: Resistance value of RSENSE2 in micro ohms.
> +
> +  adi,rdaco-ohms:
> +    description: Resistance value of RDACO1 + RDACO2 in ohms.
> +
> +  adi,rfbout1-ohms:
> +    description: Resistance value of RFBOUT1 in ohms.
> +
> +  adi,rfbout2-ohms:
> +    description: Resistance value of RFBOUT2 in ohms.
> +
> +  adi,rdaci-ohms:
> +    description: Resistance value of RDACI1 + RDACI2 in ohms.
> +
> +  adi,rfbin2-ohms:
> +    description: Resistance value of RFBIN2 in ohms.
> +
> +  adi,rfbin1-ohms:
> +    description: Resistance value of RFBIN1 in ohms.
> +
> +required:
> +  - compatible
> +  - reg
> +  - adi,rsense1-micro-ohms
> +  - adi,rimon-out-ohms
> +  - adi,rsense2-micro-ohms
> +  - adi,rdaco-ohms
> +  - adi,rfbout1-ohms
> +  - adi,rfbout2-ohms
> +  - adi,rdaci-ohms
> +  - adi,rfbin2-ohms
> +  - adi,rfbin1-ohms
> +
> +additionalProperties: false

Valid point here from Sashiko.
pw-bot: changes-requested

Thanks,
Conor.

> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        battery-charger@10 {
> +            compatible = "adi,lt8491";
> +            reg = <0x10>;
> +            adi,rsense1-micro-ohms = <5000>;
> +            adi,rimon-out-ohms = <124000>;
> +            adi,rsense2-micro-ohms = <3000>;
> +            adi,rdaco-ohms = <64900>;
> +            adi,rfbout1-ohms = <113000>;
> +            adi,rfbout2-ohms = <10000>;
> +            adi,rdaci-ohms = <7000>;
> +            adi,rfbin2-ohms = <3480>;
> +            adi,rfbin1-ohms = <102000>;
> +        };
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2fb1c75afd163..d79187312f789 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15170,6 +15170,12 @@ F:	Documentation/devicetree/bindings/hwmon/pmbus/adi,lt3074.yaml
>  F:	Documentation/hwmon/lt3074.rst
>  F:	drivers/hwmon/pmbus/lt3074.c
>  
> +LT8491 BATTERY CHARGER DRIVER
> +M:	John Erasmus Mari Geronimo <johnerasmusmari.geronimo@analog.com>
> +L:	linux-pm@vger.kernel.org
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/power/supply/adi,lt8491.yaml
> +
>  LTC1660 DAC DRIVER
>  M:	Marcus Folkesson <marcus.folkesson@gmail.com>
>  L:	linux-iio@vger.kernel.org
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  parent reply	other threads:[~2026-09-03 17:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10  8:02 [PATCH 0/2] Add LT8491 driver John Erasmus Mari Geronimo
2025-01-10  8:02 ` [PATCH 1/2] dt-bindings: power: supply: add adi,lt8491.yaml John Erasmus Mari Geronimo
2025-01-10  9:26   ` Krzysztof Kozlowski
2025-01-10  8:02 ` [PATCH 2/2] power: supply: add LT8491 battery charger driver John Erasmus Mari Geronimo
2025-01-14 16:45   ` kernel test robot
2026-09-03 10:46 ` [PATCH v2 0/2] Add LT8491 driver John Erasmus Mari Geronimo
2026-09-03 10:46   ` [PATCH v2 1/2] dt-bindings: power: supply: add adi,lt8491.yaml John Erasmus Mari Geronimo
2026-09-03 10:52     ` sashiko-bot
2026-09-03 17:21     ` Conor Dooley [this message]
2026-09-03 10:46   ` [PATCH v2 2/2] power: supply: add LT8491 battery charger driver John Erasmus Mari Geronimo
2026-09-03 10:56     ` sashiko-bot
2026-09-07  8:28     ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260903-tapered-subsoil-a3ade82e1253@spud \
    --to=conor@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johnerasmusmari.geronimo@analog.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.