Re: [PATCH v2 1/2] dt-bindings: power: supply: add adi,lt8491.yaml

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incorrect use of `additionalProperties: false` when inheriting from a core schema via `$ref`.
--

commit 7d1541cad5388e9c078d722b3be849bc6995fe46
Author: John Erasmus Mari Geronimo <johnerasmusmari.geronimo@analog.com>

dt-bindings: power: supply: add adi,lt8491.yaml

This commit adds the devicetree binding documentation for the Analog Devices
LT8491 battery charger.

> diff --git a/Documentation/devicetree/bindings/power/supply/adi,lt8491.yaml b/Documentation/devicetree/bindings/power/supply/adi,lt8491.yaml
> new file mode 100644
> index 0000000000000..bb364b48fee58
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/adi,lt8491.yaml
> @@ -0,0 +1,92 @@
[ ... ]
> +allOf:
> +  - $ref: power-supply.yaml#
[ ... ]
> +required:
> +  - compatible
> +  - reg
> +  - adi,rsense1-micro-ohms
> +  - adi,rimon-out-ohms
> +  - adi,rsense2-micro-ohms
> +  - adi,rdaco-ohms
> +  - adi,rfbout1-ohms
> +  - adi,rfbout2-ohms
> +  - adi,rdaci-ohms
> +  - adi,rfbin2-ohms
> +  - adi,rfbin1-ohms
> +
> +additionalProperties: false

[Severity: Medium]
Since this schema inherits from power-supply.yaml via the allOf ref, will
setting additionalProperties to false cause the binding to incorrectly reject
valid standard power supply properties like monitored-battery or
power-supplies during validation?

Should this be set to unevaluatedProperties: false instead to allow properties
inherited from the core schema?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1788432152.git.johnerasmusmari.geronimo@analog.com?part=1