All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: John Erasmus Mari Geronimo <johnerasmusmari.geronimo@analog.com>
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, robh@kernel.org,  sre@kernel.org
Subject: Re: [PATCH v2 2/2] power: supply: add LT8491 battery charger driver
Date: Mon, 7 Sep 2026 10:28:12 +0200	[thread overview]
Message-ID: <ap501OIVvkOg_sAI@monoceros> (raw)
In-Reply-To: <9c260e1c2056c69be1cb7a05abcd10ba657c1548.1788432152.git.johnerasmusmari.geronimo@analog.com>

[-- Attachment #1: Type: text/plain, Size: 647 bytes --]

Hello,

On Thu, Sep 03, 2026 at 06:46:37PM +0800, John Erasmus Mari Geronimo wrote:
> +#include <linux/i2c.h>
> +#include <linux/mod_devicetable.h>

Please don't use <linux/mod_devicetable.h>. You can rely on
<linux/i2c.h> to provide i2c_device_id and of_device_id. Alternatively
include <linux/device-id/i2c.h> and <linux/device-id/of.h>.

> +static const struct i2c_device_id lt8491_id[] = {
> +	{ "lt8491", 0 },
> +	{ }
> +};

Please make this:

	static const struct i2c_device_id lt8491_id[] = {
		{ .name = "lt8491" },
		{ }
	};

(i.e. use a named initializer and don't explicitly initialize the unused
driver_data member.)

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      parent reply	other threads:[~2026-09-07  8:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10  8:02 [PATCH 0/2] Add LT8491 driver John Erasmus Mari Geronimo
2025-01-10  8:02 ` [PATCH 1/2] dt-bindings: power: supply: add adi,lt8491.yaml John Erasmus Mari Geronimo
2025-01-10  9:26   ` Krzysztof Kozlowski
2025-01-10  8:02 ` [PATCH 2/2] power: supply: add LT8491 battery charger driver John Erasmus Mari Geronimo
2025-01-14 16:45   ` kernel test robot
2026-09-03 10:46 ` [PATCH v2 0/2] Add LT8491 driver John Erasmus Mari Geronimo
2026-09-03 10:46   ` [PATCH v2 1/2] dt-bindings: power: supply: add adi,lt8491.yaml John Erasmus Mari Geronimo
2026-09-03 10:52     ` sashiko-bot
2026-09-03 17:21     ` Conor Dooley
2026-09-03 10:46   ` [PATCH v2 2/2] power: supply: add LT8491 battery charger driver John Erasmus Mari Geronimo
2026-09-03 10:56     ` sashiko-bot
2026-09-07  8:28     ` Uwe Kleine-König [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ap501OIVvkOg_sAI@monoceros \
    --to=u.kleine-koenig@baylibre.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johnerasmusmari.geronimo@analog.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.