Re: [PATCH net-next 00/33] Remove comma after sentinel entries in match table

From: Jakub Kicinski <kuba@kernel.org>
To: Siddharth Vadapalli <s-vadapalli@ti.com>
Cc: <dario.binacchi@amarulasolutions.com>, <mkl@pengutronix.de>,
	<mailhol@kernel.org>, <msp@baylibre.com>,
	<florian.fainelli@broadcom.com>, <jonas.gorski@gmail.com>,
	<andrew@lunn.ch>, <olteanv@gmail.com>, <davem@davemloft.net>,
	<edumazet@google.com>, <pabeni@redhat.com>, <kurt@linutronix.de>,
	<hauke@hauke-m.de>, <chester.a.unal@arinc9.com>,
	<daniel@makrotopia.org>, <matthias.bgg@gmail.com>,
	<angelogioacchino.delregno@collabora.com>, <ansuelsmth@gmail.com>,
	<linusw@kernel.org>, <luizluca@gmail.com>,
	<alvin.sipraga@analog.com>, <clement.leger@bootlin.com>,
	<justin.chen@broadcom.com>, <dlan@kernel.org>,
	<rogerq@kernel.org>, <hkallweit1@gmail.com>,
	<linux@armlinux.org.uk>, <rjui@broadcom.com>,
	<sbranden@broadcom.com>, <bcm-kernel-feedback-list@broadcom.com>,
	<opendmb@gmail.com>, <andrei.botila@oss.nxp.com>,
	<wangruikang@iscas.ac.cn>, <amadeus@jmu.edu.cn>,
	<kees@kernel.org>, <tmshlvck@gmail.com>, <c-vankar@ti.com>,
	<horms@kernel.org>, <vadim.fedorenko@linux.dev>,
	<daniel.zahka@gmail.com>, <nora.schiffer@ew.tq-group.com>,
	<v-singh1@ti.com>, <oss@vassilevski.com>, <haokexin@gmail.com>,
	<alex@sverdlin.org>, <aleksandr.loktionov@intel.com>,
	<lgs201920130244@gmail.com>, <linux-can@vger.kernel.org>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-renesas-soc@vger.kernel.org>,
	<linux-riscv@lists.infradead.org>, <spacemit@lists.linux.dev>,
	<linux-omap@vger.kernel.org>
Subject: Re: [PATCH net-next 00/33] Remove comma after sentinel entries in match table
Date: Fri, 4 Sep 2026 08:58:11 -0700	[thread overview]
Message-ID: <20260904085811.7e2c2db6@kernel.org> (raw)
In-Reply-To: <20260904043724.2955444-1-s-vadapalli@ti.com>

On Fri, 4 Sep 2026 10:06:06 +0530 Siddharth Vadapalli wrote:
> This series removes the comma present after sentinel entries in the match
> tables across all networking subsystem drivers, with the exception of the
> davinci_mdio.c driver, for which, the patch posted by Geert at:
> https://lore.kernel.org/r/e481b6de46cecc6ea604ae165272c667274cc621.1788437140.git.geert+renesas@glider.be/
> does the same.
> 
> Since I inquired about a cleanup across the entire networking subsystem but
> didn't get a response:
> https://lore.kernel.org/r/b3d19098-eccd-4619-b667-ad3b7e0a4422@ti.com/
> I decided to post this series. Given that Andrew Lunn acknowledged the
> cleanup of the davinci_mdio driver:
> https://lore.kernel.org/r/abec6831-d344-489d-b70c-1e5dd4d43c2d@lunn.ch/
> and I don't see why the cleanup is specific to davinci_mdio driver alone,
> I am hoping that this series is treated identically to the patch that
> Geert had posted for the davinci_mdio driver.
> 
> Series is based on commit
> 6ebcf5074cff net: openvswitch: don't schedule rebalancing if there are no datapaths
> of the 'main' branch of the net-next tree.

You failed to specify why this "cleanup" makes a difference.
have you ever seen the sentinel not be the last entry?