Re: [PATCH net-next 00/33] Remove comma after sentinel entries in match table

From: Jakub Kicinski <kuba@kernel.org>
To: Siddharth Vadapalli <s-vadapalli@ti.com>
Cc: <dario.binacchi@amarulasolutions.com>, <mkl@pengutronix.de>,
	<mailhol@kernel.org>, <msp@baylibre.com>,
	<florian.fainelli@broadcom.com>, <jonas.gorski@gmail.com>,
	<andrew@lunn.ch>, <olteanv@gmail.com>, <davem@davemloft.net>,
	<edumazet@google.com>, <pabeni@redhat.com>, <kurt@linutronix.de>,
	<hauke@hauke-m.de>, <chester.a.unal@arinc9.com>,
	<daniel@makrotopia.org>, <matthias.bgg@gmail.com>,
	<angelogioacchino.delregno@collabora.com>, <ansuelsmth@gmail.com>,
	<linusw@kernel.org>, <luizluca@gmail.com>,
	<alvin.sipraga@analog.com>, <clement.leger@bootlin.com>,
	<justin.chen@broadcom.com>, <dlan@kernel.org>,
	<rogerq@kernel.org>, <hkallweit1@gmail.com>,
	<linux@armlinux.org.uk>, <rjui@broadcom.com>,
	<sbranden@broadcom.com>, <bcm-kernel-feedback-list@broadcom.com>,
	<opendmb@gmail.com>, <andrei.botila@oss.nxp.com>,
	<wangruikang@iscas.ac.cn>, <amadeus@jmu.edu.cn>,
	<kees@kernel.org>, <tmshlvck@gmail.com>, <c-vankar@ti.com>,
	<horms@kernel.org>, <vadim.fedorenko@linux.dev>,
	<daniel.zahka@gmail.com>, <nora.schiffer@ew.tq-group.com>,
	<v-singh1@ti.com>, <oss@vassilevski.com>, <haokexin@gmail.com>,
	<alex@sverdlin.org>, <aleksandr.loktionov@intel.com>,
	<lgs201920130244@gmail.com>, <linux-can@vger.kernel.org>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-renesas-soc@vger.kernel.org>,
	<linux-riscv@lists.infradead.org>, <spacemit@lists.linux.dev>,
	<linux-omap@vger.kernel.org>
Subject: Re: [PATCH net-next 00/33] Remove comma after sentinel entries in match table
Date: Sat, 5 Sep 2026 11:03:00 -0700	[thread overview]
Message-ID: <20260905110300.2b4825d5@kernel.org> (raw)
In-Reply-To: <cc1f9d12-e853-4000-8236-9e7f5a9ed314@ti.com>

On Sat, 5 Sep 2026 11:09:54 +0530 Siddharth Vadapalli wrote:
> > You failed to specify why this "cleanup" makes a difference.
> > have you ever seen the sentinel not be the last entry?  
> 
> The 'cleanup' in a way 'guarantees'/'enforces' sentinel being the last 
> entry, by catching 'copy-paste' errors at compile-time rather than being 
> a silent bug that shows up at runtime. If a new entry were to be 
> accidentally added after the sentinel entry in the current drivers, it 
> will not cause any compile-time error, but will fail silently at 
> runtime. This series 'cleans up' the drivers by making it a compile-time 
> error going forward (adding a new entry below sentinel will cause a 
> build error with the comma removed after the sentinel entry). I do not 
> doubt the review process on the mailing lists where such errors will 
> certainly be caught, but isn't it better if they are caught at 
> build-time instead, thereby saving reviewers the trouble of pointing out 
> such trivial mistakes?

Is it polite to answer a question with a question? 🧐️

Please be mindful of maintainer's time going forward.

> Trailing commas are an indication of 'scope-for-extension' in the 
> future, which holds true for 'enums' or other structures where newer 
> entires are added towards the end rather than being inserted in the 
> middle. Since that isn't the case here, this series makes it clear by 
> removing the trailing comma.