All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Krishna Chaitanya Chundru" <krishna.chundru@oss.qualcomm.com>
Cc: linux-phy@lists.infradead.org, olteanv@gmail.com,
	conor+dt@kernel.org, neil.armstrong@linaro.org, robh@kernel.org,
	linux-pci@vger.kernel.org, vkoul@kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 4/5] phy: qcom: qmp: Move qphy_setbits/clrbits/checkbits to common header
Date: Wed, 09 Sep 2026 11:54:26 +0000	[thread overview]
Message-ID: <20260909115427.26C3F1F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260909-nord-v3-4-b0a82721c547@oss.qualcomm.com>

> qphy_setbits(), qphy_clrbits() and qphy_checkbits() were duplicated
> verbatim across phy-qcom-qmp-pcie.c, phy-qcom-qmp-pcie-msm8996.c,
> phy-qcom-qmp-ufs.c, phy-qcom-qmp-usb.c, phy-qcom-qmp-usbc.c and
> phy-qcom-qmp-combo.c. Move them to the shared phy-qcom-qmp-common.h,
> which all of these drivers already include, and drop the local copies.
> 
> This also makes the helpers available to phy-qcom-qmp-pcie-multiphy.c
> without introducing yet another copy.
> 
> Suggested-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
> Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260909-nord-v3-0-b0a82721c547@oss.qualcomm.com?part=4


WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Krishna Chaitanya Chundru" <krishna.chundru@oss.qualcomm.com>
Cc: linux-phy@lists.infradead.org, olteanv@gmail.com,
	conor+dt@kernel.org, neil.armstrong@linaro.org, robh@kernel.org,
	linux-pci@vger.kernel.org, vkoul@kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 4/5] phy: qcom: qmp: Move qphy_setbits/clrbits/checkbits to common header
Date: Wed, 09 Sep 2026 11:54:26 +0000	[thread overview]
Message-ID: <20260909115427.26C3F1F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260909-nord-v3-4-b0a82721c547@oss.qualcomm.com>

> qphy_setbits(), qphy_clrbits() and qphy_checkbits() were duplicated
> verbatim across phy-qcom-qmp-pcie.c, phy-qcom-qmp-pcie-msm8996.c,
> phy-qcom-qmp-ufs.c, phy-qcom-qmp-usb.c, phy-qcom-qmp-usbc.c and
> phy-qcom-qmp-combo.c. Move them to the shared phy-qcom-qmp-common.h,
> which all of these drivers already include, and drop the local copies.
> 
> This also makes the helpers available to phy-qcom-qmp-pcie-multiphy.c
> without introducing yet another copy.
> 
> Suggested-by: Qiang Yu <qiang.yu@oss.qualcomm.com>
> Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260909-nord-v3-0-b0a82721c547@oss.qualcomm.com?part=4


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2026-09-09 11:54 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-09 11:48 [PATCH v3 0/5] Add PCIe support for Qualcomm Nord platform Krishna Chaitanya Chundru
2026-09-09 11:48 ` Krishna Chaitanya Chundru
2026-09-09 11:48 ` [PATCH v3 1/5] dt-bindings: phy: qcom: add Nord QMP PCIe PHY binding Krishna Chaitanya Chundru
2026-09-09 11:48   ` Krishna Chaitanya Chundru
2026-09-09 11:53   ` sashiko-bot
2026-09-09 11:53     ` sashiko-bot
2026-09-10  6:43   ` Shawn Guo
2026-09-10  6:43     ` Shawn Guo
2026-09-10  7:14   ` Manivannan Sadhasivam
2026-09-10  7:14     ` Manivannan Sadhasivam
2026-09-10 10:03   ` Krzysztof Kozlowski
2026-09-10 10:03     ` Krzysztof Kozlowski
2026-09-09 11:48 ` [PATCH v3 2/5] dt-bindings: pci: qcom: add Nord PCIe controller compatible Krishna Chaitanya Chundru
2026-09-09 11:48   ` Krishna Chaitanya Chundru
2026-09-09 11:53   ` sashiko-bot
2026-09-09 11:53     ` sashiko-bot
2026-09-10  6:46   ` Shawn Guo
2026-09-10  6:46     ` Shawn Guo
2026-09-09 11:48 ` [PATCH v3 3/5] PCI: qcom: Add CGC disable workaround for Nord PCIe Krishna Chaitanya Chundru
2026-09-09 11:48   ` Krishna Chaitanya Chundru
2026-09-09 11:54   ` sashiko-bot
2026-09-09 11:54     ` sashiko-bot
2026-09-10  6:47   ` Shawn Guo
2026-09-10  6:47     ` Shawn Guo
2026-09-10  7:20   ` Manivannan Sadhasivam
2026-09-10  7:20     ` Manivannan Sadhasivam
2026-09-10  7:29     ` Konrad Dybcio
2026-09-10  7:29       ` Konrad Dybcio
2026-09-10  7:36       ` Manivannan Sadhasivam
2026-09-10  7:36         ` Manivannan Sadhasivam
2026-09-09 11:48 ` [PATCH v3 4/5] phy: qcom: qmp: Move qphy_setbits/clrbits/checkbits to common header Krishna Chaitanya Chundru
2026-09-09 11:48   ` Krishna Chaitanya Chundru
2026-09-09 11:54   ` sashiko-bot [this message]
2026-09-09 11:54     ` sashiko-bot
2026-09-10  6:48   ` Shawn Guo
2026-09-10  6:48     ` Shawn Guo
2026-09-10  7:24   ` Manivannan Sadhasivam
2026-09-10  7:24     ` Manivannan Sadhasivam
2026-09-09 11:48 ` [PATCH v3 5/5] phy: qcom: qmp-pcie: Add Nord Gen5x16 PCIe multi-PHY support Krishna Chaitanya Chundru
2026-09-09 11:48   ` Krishna Chaitanya Chundru
2026-09-09 12:07   ` sashiko-bot
2026-09-09 12:07     ` sashiko-bot
2026-09-10  5:52   ` Shawn Guo
2026-09-10  5:52     ` Shawn Guo
2026-09-10  7:35   ` Manivannan Sadhasivam
2026-09-10  7:35     ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260909115427.26C3F1F00A3D@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krishna.chundru@oss.qualcomm.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=neil.armstrong@linaro.org \
    --cc=olteanv@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.