All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Hans Zhang" <18255117159@163.com>
Cc: linux-amlogic@lists.infradead.org, linux-pci@vger.kernel.org,
	neil.armstrong@linaro.org
Subject: Re: [PATCH 2/2] PCI: dwc: Remove unused PCIE_ATU_UNR_* register definitions
Date: Fri, 11 Sep 2026 16:29:09 +0000	[thread overview]
Message-ID: <20260911162909.BD28E1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260911162537.469018-3-18255117159@163.com>

> The PCIE_ATU_UNR_* macros are not used anywhere in the kernel.  They
> were presumably intended for unrolled iATU register access, but the
> driver now uses the ATU_* macros and computes unrolled offsets via
> ATU_UNROLL_BASE().
> 
> Remove these unused definitions. No functional change intended.
> 
> Signed-off-by: Hans Zhang <18255117159@163.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260911162537.469018-1-18255117159@163.com?part=2


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Hans Zhang" <18255117159@163.com>
Cc: linux-amlogic@lists.infradead.org, linux-pci@vger.kernel.org,
	neil.armstrong@linaro.org
Subject: Re: [PATCH 2/2] PCI: dwc: Remove unused PCIE_ATU_UNR_* register definitions
Date: Fri, 11 Sep 2026 16:29:09 +0000	[thread overview]
Message-ID: <20260911162909.BD28E1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260911162537.469018-3-18255117159@163.com>

> The PCIE_ATU_UNR_* macros are not used anywhere in the kernel.  They
> were presumably intended for unrolled iATU register access, but the
> driver now uses the ATU_* macros and computes unrolled offsets via
> ATU_UNROLL_BASE().
> 
> Remove these unused definitions. No functional change intended.
> 
> Signed-off-by: Hans Zhang <18255117159@163.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260911162537.469018-1-18255117159@163.com?part=2


  reply	other threads:[~2026-09-11 16:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11 16:25 [PATCH 0/2] PCI: dwc: Clean up DWC PCIe register macros Hans Zhang
2026-09-11 16:25 ` Hans Zhang
2026-09-11 16:25 ` Hans Zhang
2026-09-11 16:25 ` [PATCH 1/2] PCI: dwc: Align register macros with Synopsys documentation Hans Zhang
2026-09-11 16:25   ` Hans Zhang
2026-09-11 16:25   ` Hans Zhang
2026-09-11 16:34   ` sashiko-bot
2026-09-11 16:34     ` sashiko-bot
2026-09-11 16:25 ` [PATCH 2/2] PCI: dwc: Remove unused PCIE_ATU_UNR_* register definitions Hans Zhang
2026-09-11 16:25   ` Hans Zhang
2026-09-11 16:25   ` Hans Zhang
2026-09-11 16:29   ` sashiko-bot [this message]
2026-09-11 16:29     ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260911162909.BD28E1F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=18255117159@163.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.