All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Hans Zhang" <18255117159@163.com>
Cc: linux-amlogic@lists.infradead.org, neil.armstrong@linaro.org,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI: dwc: Align register macros with Synopsys documentation
Date: Fri, 11 Sep 2026 16:34:38 +0000	[thread overview]
Message-ID: <20260911163438.9A6F61F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260911162537.469018-2-18255117159@163.com>

> The DWC PCIe register and field macros are inconsistently named and
> often do not match the Synopsys DesignWare PCIe Controller Reference
> Manual.  This makes it harder to cross-reference the code with the
> documentation when debugging or maintaining the driver.
> 
> As suggested during review, do not add an "_OFF" suffix to the Port Link
> Control register: the suffix is ambiguous (offset vs. off) and
> unnecessary.  Use PORT_LINK_CTRL, and include the register name in its
> field macros, e.g. PORT_LINK_CTRL_DLE, PORT_LINK_CTRL_FLM, and
> PORT_LINK_CTRL_LC_*.
> 
> Align other DWC PCIe controller-internal register macros in the same
> spirit by dropping the redundant PCIE_ prefix and using the documented
> base names, such as PORT_FORCE_LINK, PORT_AFAC, PORT_LANE_SKEW,
> TIMER_CTRL_MAX_FUNC_NUM, PORT_LINK_DEBUG0/1, LINK_WIDTH_SPEED_CTRL,
> GEN3_CTRL, GEN3_EQ_CTRL, MULTI_LANE_CTRL, MISC_CONTROL_1,
> MSIX_DOORBELL, and the ATU_* registers.  Field macros are renamed
> consistently so their register association is clear.
> 
> This improves code maintainability and eases future reference to the
> controller manual.
> 
> No functional change intended.
> 
> Co-developed-by: Feizhou Yu <yufeizhou201@163.com>
> Signed-off-by: Feizhou Yu <yufeizhou201@163.com>
> Signed-off-by: Hans Zhang <18255117159@163.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260911162537.469018-1-18255117159@163.com?part=1


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Hans Zhang" <18255117159@163.com>
Cc: linux-amlogic@lists.infradead.org, neil.armstrong@linaro.org,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI: dwc: Align register macros with Synopsys documentation
Date: Fri, 11 Sep 2026 16:34:38 +0000	[thread overview]
Message-ID: <20260911163438.9A6F61F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260911162537.469018-2-18255117159@163.com>

> The DWC PCIe register and field macros are inconsistently named and
> often do not match the Synopsys DesignWare PCIe Controller Reference
> Manual.  This makes it harder to cross-reference the code with the
> documentation when debugging or maintaining the driver.
> 
> As suggested during review, do not add an "_OFF" suffix to the Port Link
> Control register: the suffix is ambiguous (offset vs. off) and
> unnecessary.  Use PORT_LINK_CTRL, and include the register name in its
> field macros, e.g. PORT_LINK_CTRL_DLE, PORT_LINK_CTRL_FLM, and
> PORT_LINK_CTRL_LC_*.
> 
> Align other DWC PCIe controller-internal register macros in the same
> spirit by dropping the redundant PCIE_ prefix and using the documented
> base names, such as PORT_FORCE_LINK, PORT_AFAC, PORT_LANE_SKEW,
> TIMER_CTRL_MAX_FUNC_NUM, PORT_LINK_DEBUG0/1, LINK_WIDTH_SPEED_CTRL,
> GEN3_CTRL, GEN3_EQ_CTRL, MULTI_LANE_CTRL, MISC_CONTROL_1,
> MSIX_DOORBELL, and the ATU_* registers.  Field macros are renamed
> consistently so their register association is clear.
> 
> This improves code maintainability and eases future reference to the
> controller manual.
> 
> No functional change intended.
> 
> Co-developed-by: Feizhou Yu <yufeizhou201@163.com>
> Signed-off-by: Feizhou Yu <yufeizhou201@163.com>
> Signed-off-by: Hans Zhang <18255117159@163.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260911162537.469018-1-18255117159@163.com?part=1


  reply	other threads:[~2026-09-11 16:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11 16:25 [PATCH 0/2] PCI: dwc: Clean up DWC PCIe register macros Hans Zhang
2026-09-11 16:25 ` Hans Zhang
2026-09-11 16:25 ` Hans Zhang
2026-09-11 16:25 ` [PATCH 1/2] PCI: dwc: Align register macros with Synopsys documentation Hans Zhang
2026-09-11 16:25   ` Hans Zhang
2026-09-11 16:25   ` Hans Zhang
2026-09-11 16:34   ` sashiko-bot [this message]
2026-09-11 16:34     ` sashiko-bot
2026-09-11 16:25 ` [PATCH 2/2] PCI: dwc: Remove unused PCIE_ATU_UNR_* register definitions Hans Zhang
2026-09-11 16:25   ` Hans Zhang
2026-09-11 16:25   ` Hans Zhang
2026-09-11 16:29   ` sashiko-bot
2026-09-11 16:29     ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260911163438.9A6F61F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=18255117159@163.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.