From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Vrabel <david.vrabel@nutanix.com>
Cc: "Cédric Le Goater" <clg@redhat.com>,
qemu-devel@nongnu.org, "Alex Williamson" <alex@shazbot.org>,
"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>,
"Zhao Liu" <zhao1.liu@intel.com>
Subject: Re: [PATCH 0/2] hw/pci-bridge: Add x-speed and x-width properties to xio3130 ports
Date: Tue, 15 Sep 2026 10:22:54 -0400 [thread overview]
Message-ID: <20260915102221-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <81c899d9-a9fb-4eb2-ad85-7dde2f626646@nutanix.com>
On Tue, Sep 15, 2026 at 12:17:31PM +0100, David Vrabel wrote:
> On 15/09/2026 11:01, Michael S. Tsirkin wrote:
> >
> > On Tue, Sep 15, 2026 at 09:25:05AM +0200, Cédric Le Goater wrote:
> > > Hello,
> > >
> > > The xio3130-downstream and x3130-upstream devices lacks x-speed and
> > > x-width device properties, making it impossible to configure PCIe link
> > > speed/width when building PIX switch topologies for GPU/NIC passthrough.
> > >
> > > Fix that and preserve migration compatibility with a 2.5GT/s x1 default.
> > >
> > > Thanks,
> > >
> > > C.
> >
> > Given they are clearly intended for users, time to rename to width/speed
> > everywhere?
>
> A more comprehensive series (hw/pci-bridge: Configurable apparent bandwidth
> for the PCIe topology) is here:
>
> https://patchew.org/QEMU/20260908155223.164787-1-david.vrabel@nutanix.com/
>
> This adds new upstream and switch port devices with configurable speed/width
> and renames the options so they are non-experimental (but do not the open
> question about the usability of the speed option with the need to set 2.5
> GT/s as the string "2_5").
>
> I did consider adding options to the XIO3130 device but since the real
> hardware is Gen 1 only and does not support speeds/widths other 2.5GT/s/1x I
> didn't consider it appropriate to claim these emulated ports are more
> capable than the real hardware.
>
> David
Right that makes more sense to me. Cédric what do you think?
--
MST
next prev parent reply other threads:[~2026-09-15 14:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 7:25 [PATCH 0/2] hw/pci-bridge: Add x-speed and x-width properties to xio3130 ports Cédric Le Goater
2026-09-15 7:25 ` [PATCH 1/2] hw/pci-bridge: Add x-speed and x-width properties to xio3130-downstream Cédric Le Goater
2026-09-15 7:25 ` [PATCH 2/2] hw/pci-bridge: Add x-speed and x-width properties to x3130-upstream Cédric Le Goater
2026-09-15 8:27 ` [PATCH 0/2] hw/pci-bridge: Add x-speed and x-width properties to xio3130 ports Cédric Le Goater
2026-09-15 10:01 ` Michael S. Tsirkin
2026-09-15 11:17 ` David Vrabel
2026-09-15 14:22 ` Michael S. Tsirkin [this message]
2026-09-15 15:36 ` Cédric Le Goater
2026-09-15 16:40 ` Michael S. Tsirkin
2026-09-16 9:40 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915102221-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alex@shazbot.org \
--cc=clg@redhat.com \
--cc=david.vrabel@nutanix.com \
--cc=philmd@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.