From: Ruslan Ruslichenko <ruslichenko.r@gmail.com>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, artem_mygaiev@epam.com,
volodymyr_babchuk@epam.com, peter.maydell@linaro.org,
francisco.iglesias@amd.com, edgar.iglesias@gmail.com,
berrange@redhat.com, eugene@nuvacore.ai,
Ruslan_Ruslichenko@epam.com, takahiro.nakata.wr@renesas.com,
"Edgar E . Iglesias" <edgar.iglesias@amd.com>
Subject: [PATCH v2 15/20] hw/core: Add Remote Port memory slave device
Date: Tue, 15 Sep 2026 18:00:39 +0200 [thread overview]
Message-ID: <20260915160044.345788-16-ruslichenko.r@gmail.com> (raw)
In-Reply-To: <20260915160044.345788-1-ruslichenko.r@gmail.com>
From: Ruslan Ruslichenko <Ruslan_Ruslichenko@epam.com>
Introduce the 'remote-port-memory-slave' device to allow remote
peers to initiate memory transactions within QEMU.
The patch implements the logic to receive Remote Port bus access
commands, execute them within the QEMU Address Space, and return
the appropriate response.
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@amd.com>
Signed-off-by: Takahiro Nakata <takahiro.nakata.wr@renesas.com>
Signed-off-by: Ruslan Ruslichenko <Ruslan_Ruslichenko@epam.com>
---
hw/core/remote-port-memory-slave.c | 242 +++++++++++++++++++++
hw/core/trace-events | 4 +
include/hw/core/remote-port-memory-slave.h | 35 +++
3 files changed, 281 insertions(+)
create mode 100644 hw/core/remote-port-memory-slave.c
create mode 100644 include/hw/core/remote-port-memory-slave.h
diff --git a/hw/core/remote-port-memory-slave.c b/hw/core/remote-port-memory-slave.c
new file mode 100644
index 0000000000..ed161255c5
--- /dev/null
+++ b/hw/core/remote-port-memory-slave.c
@@ -0,0 +1,242 @@
+/*
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ *
+ * QEMU remote port memory slave. Read and write transactions
+ * recieved from the remote port are translated into an address space.
+ *
+ * Copyright (c) 2013 Xilinx Inc
+ * Written by Edgar E. Iglesias <edgar.iglesias@xilinx.com>
+ * Written by Peter Crosthwaite <peter.crosthwaite@xilinx.com>
+ *
+ * This code is licensed under the GNU GPL.
+ */
+
+#include "qemu/osdep.h"
+#include "system/system.h"
+#include "system/dma.h"
+#include "qemu/log.h"
+#include "qapi/qmp/qerror.h"
+#include "qapi/error.h"
+#include "hw/core/sysbus.h"
+#include "migration/vmstate.h"
+#include "hw/core/qdev-properties.h"
+#include "qemu/error-report.h"
+#include "trace.h"
+#include "qemu/cutils.h"
+
+#include "hw/core/remote-port-proto.h"
+#include "hw/core/remote-port-memory-slave.h"
+
+/* Slow path dealing with odd stuff like byte-enables. */
+static MemTxResult process_data_slow(RemotePortMemorySlave *s,
+ AddressSpace *as,
+ struct rp_pkt *pkt,
+ DMADirection dir,
+ uint8_t *data, uint8_t *byte_en)
+{
+ unsigned int i;
+ unsigned int byte_en_len = pkt->busaccess_ext_base.byte_enable_len;
+ unsigned int sw = pkt->busaccess.stream_width;
+ MemTxResult ret = MEMTX_OK;
+
+ assert(sw);
+
+ for (i = 0; i < pkt->busaccess.len; i++) {
+ if (byte_en && !byte_en[i % byte_en_len]) {
+ continue;
+ }
+
+ ret = dma_memory_rw(as, pkt->busaccess.addr + i % sw,
+ data + i, 1, dir, s->attr);
+
+ if (ret != MEMTX_OK) {
+ break;
+ }
+ }
+
+ return ret;
+}
+
+static AddressSpace *get_as_for_phys_busaccess(RemotePortMemorySlave *s,
+ struct rp_pkt *pkt)
+{
+ if (s->ats_cache) {
+ IOMMUTLBEntry *iotlb =
+ rp_ats_cache_lookup_translation(s->ats_cache,
+ pkt->busaccess.addr,
+ pkt->busaccess.len);
+ if (iotlb) {
+ /* Return the matching address space found. */
+ return iotlb->target_as;
+ }
+ }
+ /* Emit a warning on errors since this really should not happen. */
+ warn_report("Physical address error detected (range address: 0x%"
+ HWADDR_PRIx ", len: 0x%" PRIx32 " contains untranslated "
+ "addresses)", pkt->busaccess.addr, pkt->busaccess.len);
+ return NULL;
+}
+
+static void rp_cmd_rw(RemotePortMemorySlave *s, struct rp_pkt *pkt,
+ DMADirection dir)
+{
+ size_t pktlen = sizeof(struct rp_pkt_busaccess_ext_base);
+ struct rp_encode_busaccess_in in = {0};
+ size_t enclen;
+ int64_t delay;
+ uint8_t *data = NULL;
+ uint8_t *byte_en;
+ MemTxResult ret;
+ AddressSpace *as;
+
+ byte_en = rp_busaccess_byte_en_ptr(s->peer, &pkt->busaccess_ext_base);
+
+ if (dir == DMA_DIRECTION_TO_DEVICE) {
+ pktlen += pkt->busaccess.len;
+ } else {
+ data = rp_busaccess_rx_dataptr(s->peer, &pkt->busaccess_ext_base);
+ }
+
+ assert(pkt->busaccess.width == 0);
+ assert(!(pkt->hdr.flags & RP_PKT_FLAGS_response));
+
+ rp_dpkt_alloc(&s->rsp, pktlen);
+ if (dir == DMA_DIRECTION_TO_DEVICE) {
+ data = rp_busaccess_tx_dataptr(s->peer,
+ &s->rsp.pkt->busaccess_ext_base);
+ }
+
+ trace_remote_port_memory_slave_rx_busaccess(rp_cmd_to_string(pkt->hdr.cmd),
+ pkt->hdr.id, pkt->hdr.flags, pkt->hdr.dev, pkt->busaccess.addr,
+ pkt->busaccess.len, pkt->busaccess.attributes);
+
+ s->attr.secure = !!(pkt->busaccess.attributes & RP_BUS_ATTR_SECURE);
+ s->attr.requester_id = pkt->busaccess.master_id;
+
+ if (pkt->busaccess.attributes & RP_BUS_ATTR_PHYS_ADDR) {
+ as = get_as_for_phys_busaccess(s, pkt);
+ } else {
+ as = &s->as;
+ }
+ if (as) {
+ if (byte_en || pkt->busaccess.stream_width != pkt->busaccess.len) {
+ ret = process_data_slow(s, as, pkt, dir, data, byte_en);
+ } else {
+ ret = dma_memory_rw(as, pkt->busaccess.addr, data,
+ pkt->busaccess.len, dir, s->attr);
+ }
+ } else {
+ ret = MEMTX_ERROR;
+ }
+
+ /*
+ * delay here could be set to the annotated cost of doing issuing
+ * these accesses. QEMU doesn't support this kind of annotations
+ * at the moment. So we just clear the delay.
+ */
+ delay = 0;
+
+ rp_encode_busaccess_in_rsp_init(&in, pkt);
+ in.clk = pkt->busaccess.timestamp + delay;
+
+ switch (ret) {
+ case MEMTX_ERROR:
+ in.attr |= RP_RESP_BUS_GENERIC_ERROR << RP_BUS_RESP_SHIFT;
+ break;
+ case MEMTX_DECODE_ERROR:
+ in.attr |= RP_RESP_ADDR_ERROR << RP_BUS_RESP_SHIFT;
+ break;
+ default:
+ /* MEMTX_OK maps to RP_RESP_OK. */
+ break;
+ }
+
+ enclen = rp_encode_busaccess(s->peer, &s->rsp.pkt->busaccess_ext_base,
+ &in);
+ assert(enclen <= pktlen);
+
+ trace_remote_port_memory_slave_tx_busaccess(rp_cmd_to_string(in.cmd),
+ in.id, in.flags, in.dev, in.addr, in.size, in.attr);
+
+ rp_write(s->rp, (void *)s->rsp.pkt, enclen);
+}
+
+static void rp_memory_slave_realize(DeviceState *dev, Error **errp)
+{
+ RemotePortMemorySlave *s = REMOTE_PORT_MEMORY_SLAVE(dev);
+
+ s->peer = rp_get_peer(s->rp);
+ address_space_init(&s->as, s->mr ? s->mr : get_system_memory(), "dma");
+}
+
+static void rp_memory_slave_write(RemotePortDevice *s, struct rp_pkt *pkt)
+{
+ return rp_cmd_rw(REMOTE_PORT_MEMORY_SLAVE(s), pkt,
+ DMA_DIRECTION_FROM_DEVICE);
+}
+
+static void rp_memory_slave_read(RemotePortDevice *s, struct rp_pkt *pkt)
+{
+ return rp_cmd_rw(REMOTE_PORT_MEMORY_SLAVE(s), pkt,
+ DMA_DIRECTION_TO_DEVICE);
+}
+
+static void rp_prop_allow_set_link(const Object *obj, const char *name,
+ Object *val, Error **errp)
+{
+}
+
+static void rp_memory_slave_init(Object *obj)
+{
+ RemotePortMemorySlave *rpms = REMOTE_PORT_MEMORY_SLAVE(obj);
+
+ object_property_add_link(obj, "rp-adaptor0", "remote-port",
+ (Object **)&rpms->rp,
+ rp_prop_allow_set_link,
+ OBJ_PROP_LINK_STRONG);
+ object_property_add_link(obj, "mr", TYPE_MEMORY_REGION,
+ (Object **)&rpms->mr,
+ qdev_prop_allow_set_link_before_realize,
+ OBJ_PROP_LINK_STRONG);
+ object_property_add_link(obj, "rp-ats-cache", TYPE_REMOTE_PORT_ATS_CACHE,
+ (Object **)&rpms->ats_cache,
+ qdev_prop_allow_set_link_before_realize,
+ OBJ_PROP_LINK_STRONG);
+}
+
+static void rp_memory_slave_unrealize(DeviceState *dev)
+{
+ RemotePortMemorySlave *s = REMOTE_PORT_MEMORY_SLAVE(dev);
+
+ address_space_destroy(&s->as);
+}
+
+static void rp_memory_slave_class_init(ObjectClass *oc, const void *data)
+{
+ RemotePortDeviceClass *rpdc = REMOTE_PORT_DEVICE_CLASS(oc);
+ DeviceClass *dc = DEVICE_CLASS(oc);
+
+ rpdc->ops[RP_CMD_write] = rp_memory_slave_write;
+ rpdc->ops[RP_CMD_read] = rp_memory_slave_read;
+ dc->realize = rp_memory_slave_realize;
+ dc->unrealize = rp_memory_slave_unrealize;
+}
+
+static const TypeInfo rp_info = {
+ .name = TYPE_REMOTE_PORT_MEMORY_SLAVE,
+ .parent = TYPE_DEVICE,
+ .instance_size = sizeof(RemotePortMemorySlave),
+ .instance_init = rp_memory_slave_init,
+ .class_init = rp_memory_slave_class_init,
+ .interfaces = (InterfaceInfo[]) {
+ { TYPE_REMOTE_PORT_DEVICE },
+ { },
+ },
+};
+
+static void rp_register_types(void)
+{
+ type_register_static(&rp_info);
+}
+
+type_init(rp_register_types)
diff --git a/hw/core/trace-events b/hw/core/trace-events
index dc98745178..475c8439ba 100644
--- a/hw/core/trace-events
+++ b/hw/core/trace-events
@@ -42,3 +42,7 @@ rp_wait_resp(const char *rp) "'%s'"
# remote-port-memory-master.c
remote_port_memory_master_tx_busaccess(const char *cmd, uint32_t id, uint32_t flags, uint32_t dev, uint64_t addr, uint32_t len, uint64_t attr) "cmd=%s, id=0x%"PRIx32", flags=0x%"PRIx32", dev=0x%"PRIx32", addr=0x%"PRIx64", len=0x%"PRIx32", attr=0x%"PRIx64
remote_port_memory_master_rx_busaccess(const char *cmd, uint32_t id, uint32_t flags, uint32_t dev, uint64_t addr, uint32_t len, uint64_t attr) "cmd=%s, id=0x%"PRIx32", flags=0x%"PRIx32", dev=0x%"PRIx32", addr=0x%"PRIx64", len=0x%"PRIx32", attr=0x%"PRIx64
+
+# remote-port-memory-slave.c
+remote_port_memory_slave_tx_busaccess(const char *cmd, uint32_t id, uint32_t flags, uint32_t dev, uint64_t addr, uint32_t len, uint64_t attr) "cmd=%s, id=0x%"PRIx32", flags=0x%"PRIx32", dev=0x%"PRIx32", addr=0x%"PRIx64", len=0x%"PRIx32", attr=0x%"PRIx64
+remote_port_memory_slave_rx_busaccess(const char *cmd, uint32_t id, uint32_t flags, uint32_t dev, uint64_t addr, uint32_t len, uint64_t attr) "cmd=%s, id=0x%"PRIx32", flags=0x%"PRIx32", dev=0x%"PRIx32", addr=0x%"PRIx64", len=0x%"PRIx32", attr=0x%"PRIx64
diff --git a/include/hw/core/remote-port-memory-slave.h b/include/hw/core/remote-port-memory-slave.h
new file mode 100644
index 0000000000..ef264effc2
--- /dev/null
+++ b/include/hw/core/remote-port-memory-slave.h
@@ -0,0 +1,35 @@
+/*
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ *
+ * QEMU remote port memory slave. Read and write transactions
+ * recieved from the remote port are translated into an address space.
+ *
+ * Copyright (c) 2013 Xilinx Inc
+ * Written by Edgar E. Iglesias <edgar.iglesias@xilinx.com>
+ * Written by Peter Crosthwaite <peter.crosthwaite@xilinx.com>
+ *
+ * This code is licensed under the GNU GPL.
+ */
+#ifndef REMOTE_PORT_MEMORY_SLAVE_H
+#define REMOTE_PORT_MEMORY_SLAVE_H
+
+#include "hw/core/remote-port-ats.h"
+
+#define TYPE_REMOTE_PORT_MEMORY_SLAVE "remote-port-memory-slave"
+#define REMOTE_PORT_MEMORY_SLAVE(obj) \
+ OBJECT_CHECK(RemotePortMemorySlave, (obj), \
+ TYPE_REMOTE_PORT_MEMORY_SLAVE)
+
+typedef struct RemotePortMemorySlave {
+ /* private */
+ SysBusDevice parent;
+ /* public */
+ struct RemotePort *rp;
+ struct rp_peer_state *peer;
+ MemoryRegion *mr;
+ AddressSpace as;
+ MemTxAttrs attr;
+ RemotePortDynPkt rsp;
+ RemotePortATSCache *ats_cache;
+} RemotePortMemorySlave;
+#endif
--
2.43.0
next prev parent reply other threads:[~2026-09-15 16:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 16:00 [PATCH v2 00/20] hw/core: Introduce Remote Port Co-simulation Protocol Ruslan Ruslichenko
2026-09-15 16:00 ` [PATCH v2 01/20] hw/core: Add Remote Port protocol packet definition Ruslan Ruslichenko
2026-09-15 16:00 ` [PATCH v2 02/20] hw/core: Add Remote Port header helpers Ruslan Ruslichenko
2026-09-15 16:00 ` [PATCH v2 03/20] hw/core: Add Remote Port session state and hello protocol Ruslan Ruslichenko
2026-09-15 16:00 ` [PATCH v2 04/20] hw/core: Implement Remote Port bus access helpers Ruslan Ruslichenko
2026-09-15 16:00 ` [PATCH v2 05/20] hw/core: Implement Remote Port irq, sync and ATS helpers Ruslan Ruslichenko
2026-09-15 16:00 ` [PATCH v2 06/20] hw/core: Add Remote Port object skeleton Ruslan Ruslichenko
2026-09-15 16:00 ` [PATCH v2 07/20] hw/core: Add Remote Port protocol thread and handshake Ruslan Ruslichenko
2026-09-15 16:00 ` [PATCH v2 08/20] hw/core: Implement Remote Port response handling Ruslan Ruslichenko
2026-09-15 16:00 ` [PATCH v2 09/20] hw/core: Implement Remote Port time synchronization Ruslan Ruslichenko
2026-09-15 16:00 ` [PATCH v2 10/20] hw/core: Add Remote Port Memory Master object skeleton Ruslan Ruslichenko
2026-09-15 16:00 ` [PATCH v2 11/20] hw/core: Implement Remote Port Memory Master bus transactions Ruslan Ruslichenko
2026-10-13 16:09 ` Philippe Mathieu-Daudé
2026-10-13 16:10 ` Philippe Mathieu-Daudé
2026-10-14 8:24 ` Ruslan Ruslichenko
2026-09-15 16:00 ` [PATCH v2 12/20] system/physmem: Add ats_do_translate helper Ruslan Ruslichenko
2026-10-13 14:27 ` Clément MATHIEU--DRIF
2026-10-14 8:21 ` Ruslan Ruslichenko
2026-09-15 16:00 ` [PATCH v2 13/20] hw/core: Add Remote Port ATS device skeleton Ruslan Ruslichenko
2026-09-15 16:00 ` [PATCH v2 14/20] hw/core: Implement Remote Port ATS logic and cache management Ruslan Ruslichenko
2026-09-15 16:00 ` Ruslan Ruslichenko [this message]
2026-09-15 16:00 ` [PATCH v2 16/20] hw/core: Add Remote Port GPIO/Interrupt bridge Ruslan Ruslichenko
2026-09-15 16:00 ` [PATCH v2 17/20] hw/core: Add Remote Port Stream device Ruslan Ruslichenko
2026-09-15 16:00 ` [PATCH v2 18/20] hw/core: Add Remote Port files to build Ruslan Ruslichenko
2026-09-15 16:00 ` [PATCH v2 19/20] hw/core: Add FDT support to Remote Port GPIO Ruslan Ruslichenko
2026-09-15 16:00 ` [PATCH v2 20/20] hw/core: Add FDT support to Remote Port memory master Ruslan Ruslichenko
2026-09-28 7:30 ` [PATCH v2 00/20] hw/core: Introduce Remote Port Co-simulation Protocol Ruslan Ruslichenko
2026-10-13 16:17 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915160044.345788-16-ruslichenko.r@gmail.com \
--to=ruslichenko.r@gmail.com \
--cc=Ruslan_Ruslichenko@epam.com \
--cc=artem_mygaiev@epam.com \
--cc=berrange@redhat.com \
--cc=edgar.iglesias@amd.com \
--cc=edgar.iglesias@gmail.com \
--cc=eugene@nuvacore.ai \
--cc=francisco.iglesias@amd.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=takahiro.nakata.wr@renesas.com \
--cc=volodymyr_babchuk@epam.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.