Re: [PATCH 4/9] perf pmu: Include the headers that are used

[sashiko-bot@kernel.org]

> pmu.c uses errno, free() and the str*() functions but declares none of
> them directly. <string.h> arrives by way of <linux/string.h>, and
> <errno.h> and <stdlib.h> come from whatever the other headers happen to
> drag in, which is fragile and breaks on C libraries that don't nest
> their headers the same way.
> 
> Include the three directly.
> 
> <ctype.h> is deliberately not added. The isdigit(), tolower() and
> toupper() used here are the macros from <linux/ctype.h>, which is
> included on purpose and documents that it doesn't handle EOF the way the
> standard C library does, so pulling in <ctype.h> would change which
> implementation is used.
> 
> size_t is left alone too, as <stdio.h> is already included directly and
> declares it.
> 
> No functional change.
> 
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916061218.3061216-1-irogers@google.com?part=4