Re: [PATCH 3/9] perf libbfd: Include the headers that are used

[Namhyung Kim <namhyung@kernel.org>]

On Wed, Sep 16, 2026 at 08:54:16AM -0700, Ian Rogers wrote:
> On Tue, Sep 15, 2026 at 11:22 PM <sashiko-bot@kernel.org> wrote:
> >
> > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> > - [Low] perf libbfd: build failure on musl due to missing <stdarg.h>
> > --
> >
> > commit b4b64b7fbd73cf480fc5aaa2ad17802e8f46fbcc
> > Author: Ian Rogers <irogers@google.com>
> >
> > perf libbfd: Include the headers that are used
> >
> > This patch explicitly includes several POSIX headers directly into libbfd.c
> > instead of relying on indirect inclusions. It also reorders the includes to
> > group system headers before perf's own headers.
> >
> > > diff --git a/tools/perf/util/libbfd.c b/tools/perf/util/libbfd.c
> > > index 131bfedf48cdf..1b23a261a9ced 100644
> > > --- a/tools/perf/util/libbfd.c
> > > +++ b/tools/perf/util/libbfd.c
> > > @@ -1,5 +1,19 @@
> > >  // SPDX-License-Identifier: GPL-2.0
> > >  #include "libbfd.h"
> > > +
> > > +#include <errno.h>
> > > +#include <inttypes.h>
> > > +#include <limits.h>
> > > +#include <stdint.h>
> > > +#include <stdio.h>
> > > +#include <stdlib.h>
> > > +#include <string.h>
> > > +
> > > +#include <fcntl.h>
> > > +#include <pthread.h>
> > > +
> > > +#include <tools/dis-asm-compat.h>
> >
> > [Severity: Low]
> > Does this inclusion order break the build on musl libc?
> >
> > Because <tools/dis-asm-compat.h> uses va_start and va_end in an inline
> > function, it strictly requires <stdarg.h>. Previously, this requirement
> > was satisfied implicitly because it was included later in the file, after
> > other headers provided the necessary declarations.
> >
> > Moving <tools/dis-asm-compat.h> higher up in the file exposes this missing
> > dependency, which will cause va_start and va_end to be undeclared in strict
> > environments like musl.
> >
> > [ ... ]
> 
> I don't plan to fix this as the issue is minor and relates to an
> include, not the code itself. The series has no other Sashiko
> feedback.
> https://sashiko.dev/#/patchset/20260916061218.3061216-1-irogers%40google.com

I think <stdarg.h> should be included by <tools/dis-asm-compat.h> then.
But it looks like a separate issue.

Thanks,
Namhyung