From: sashiko-bot@kernel.org
To: "Ian Rogers" <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 7/9] perf build: Check the version of the compiler that is used
Date: Wed, 16 Sep 2026 06:16:52 +0000 [thread overview]
Message-ID: <20260916061652.B1D121F0089A@smtp.kernel.org> (raw)
In-Reply-To: <20260916061218.3061216-8-irogers@google.com>
> The flex and bison flags are adjusted for clang older than 13.0.0, which
> doesn't grok -Wno-unused-but-set-variable. The test is reached because
> CC_NO_CLANG says CC is clang, but the version comes from $(CLANG), which
> defaults to plain "clang" and needn't be the compiler in use:
>
> $ make CC=clang-19 CLANG=clang-12
> version from $(CLANG) -> 12.0.0, flag stripped
> version from $(CC) -> 19.1.7, flag kept
>
> Dropping the flag lets the warnings it suppresses in the generated flex
> and bison code through, and those are errors under -Werror.
>
> Ask $(CC) instead, as that is what compiles the code.
>
> Fixes: 878460e8d0ff ("perf build: Remove -Wno-unused-but-set-variable from the flex flags when building with clang < 13.0.0")
> Signed-off-by: Ian Rogers <irogers@google.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260916061218.3061216-1-irogers@google.com?part=7
next prev parent reply other threads:[~2026-09-16 6:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 6:12 [PATCH 0/9] perf build: Fix builds with clang and BUILD_NONDISTRO Ian Rogers
2026-09-16 6:12 ` [PATCH 1/9] perf libbfd: Fix the clang -Wthread-safety build failure Ian Rogers
2026-09-16 6:18 ` sashiko-bot
2026-09-16 6:12 ` [PATCH 2/9] perf symbol: Fix the build when demangling with libbfd Ian Rogers
2026-09-16 6:21 ` sashiko-bot
2026-09-16 6:12 ` [PATCH 3/9] perf libbfd: Include the headers that are used Ian Rogers
2026-09-16 6:22 ` sashiko-bot
2026-09-16 15:54 ` Ian Rogers
2026-09-16 17:37 ` Namhyung Kim
2026-09-16 6:12 ` [PATCH 4/9] perf pmu: " Ian Rogers
2026-09-16 6:14 ` sashiko-bot
2026-09-16 6:12 ` [PATCH 5/9] perf build: Only pass clang flags to CXX when CXX is clang Ian Rogers
2026-09-16 6:17 ` sashiko-bot
2026-09-16 6:12 ` [PATCH 6/9] perf build: Use the given CC rather than clang in clang builds Ian Rogers
2026-09-16 6:19 ` sashiko-bot
2026-09-16 6:12 ` [PATCH 7/9] perf build: Check the version of the compiler that is used Ian Rogers
2026-09-16 6:16 ` sashiko-bot [this message]
2026-09-16 6:12 ` [PATCH 8/9] perf build: Remove leftovers of removed build options Ian Rogers
2026-09-16 6:17 ` sashiko-bot
2026-09-16 6:12 ` [PATCH 9/9] perf test: Add build tests for clang and libbfd demangling Ian Rogers
2026-09-16 6:22 ` sashiko-bot
2026-09-16 17:35 ` [PATCH 0/9] perf build: Fix builds with clang and BUILD_NONDISTRO Namhyung Kim
2026-09-22 12:47 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260916061652.B1D121F0089A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=irogers@google.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.