From: Ian Rogers <irogers@google.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: sashiko-bot@kernel.org
Subject: [PATCH v1 06/11] perf test: missing stdio.h and signal.h inclusions in cmd_test()
Date: Wed, 16 Sep 2026 21:53:21 -0700 [thread overview]
Message-ID: <20260917045326.63601-6-irogers@google.com> (raw)
In-Reply-To: <20260917045326.63601-1-irogers@google.com>
Sashiko reported:
When compiling the perf tool against musl libc, the build fails in
tools/perf/tests/builtin-test.c due to missing explicit inclusions
of <stdio.h> and <signal.h>.
The file relies on standard I/O functions like fdopen() and
fprintf(), as well as signal handling constructs like signal(),
SIGINT, and SIGTERM within __cmd_test() and related helpers. While
glibc may implicitly pull in these definitions through other
standard headers such as <stdlib.h> or <unistd.h>, musl libc
strictly enforces POSIX namespace separation and avoids implicit
header inclusion. Because the required headers are absent, the
compiler cannot resolve these standard library types and macros,
resulting in a direct compilation failure on musl-based systems.
Add the header files and use git clang-format to sort.
Reported-by: sashiko-bot@kernel.org
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/tests/builtin-test.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
index 4d0784b16723..ca3e7b84d5d7 100644
--- a/tools/perf/tests/builtin-test.c
+++ b/tools/perf/tests/builtin-test.c
@@ -5,16 +5,15 @@
* Builtin regression testing command: ever growing number of sanity tests
*/
#include <ctype.h>
-#include <fcntl.h>
#include <errno.h>
-#ifdef HAVE_BACKTRACE_SUPPORT
-#include <execinfo.h>
-#endif
#include <setjmp.h>
+#include <signal.h>
+#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <dirent.h>
+#include <fcntl.h>
#include <linux/kernel.h>
#include <linux/string.h>
#include <linux/zalloc.h>
@@ -44,6 +43,10 @@
#include "util/strbuf.h"
#include "util/term.h"
+#ifdef HAVE_BACKTRACE_SUPPORT
+#include <execinfo.h>
+#endif
+
static const char *junit_filename;
static struct strbuf junit_xml_buf = STRBUF_INIT;
--
2.55.0.1082.g2b9226bbc0-goog
next prev parent reply other threads:[~2026-09-17 4:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 4:53 [PATCH v1 01/11] perf aslr: Add missing includes and sort headers Ian Rogers
2026-09-17 4:53 ` [PATCH v1 02/11] perf bench messaging: " Ian Rogers
2026-09-17 4:59 ` sashiko-bot
2026-09-17 4:53 ` [PATCH v1 03/11] perf unwind-libdw: missing <stdlib.h> in libdw_set_initial_registers() Ian Rogers
2026-09-17 4:59 ` sashiko-bot
2026-09-17 4:53 ` [PATCH v1 04/11] perf llvm: missing explicit POSIX headers in symbol__disassemble_llvm() Ian Rogers
2026-09-17 5:00 ` sashiko-bot
2026-09-17 4:53 ` [PATCH v1 05/11] perf dso: missing POSIX headers string.h and limits.h Ian Rogers
2026-09-17 4:59 ` sashiko-bot
2026-09-17 4:53 ` Ian Rogers [this message]
2026-09-17 4:58 ` [PATCH v1 06/11] perf test: missing stdio.h and signal.h inclusions in cmd_test() sashiko-bot
2026-09-17 4:53 ` [PATCH v1 07/11] perf ui annotate-data: missing explicit inclusion of stdlib.h and stdio.h Ian Rogers
2026-09-17 5:00 ` sashiko-bot
2026-09-17 4:53 ` [PATCH v1 08/11] perf annotate-data: missing <string.h> inclusion for libc string functions Ian Rogers
2026-09-17 4:59 ` sashiko-bot
2026-09-17 4:53 ` [PATCH v1 09/11] perf mem: missing stdio.h and limits.h in mem-events.c Ian Rogers
2026-09-17 4:59 ` sashiko-bot
2026-09-17 4:53 ` [PATCH v1 10/11] perf config: undeclared PATH_MAX due to missing <limits.h> inclusion Ian Rogers
2026-09-17 5:01 ` sashiko-bot
2026-09-17 4:53 ` [PATCH v1 11/11] perf mem: missing standard POSIX headers in builtin-mem.c Ian Rogers
2026-09-17 5:02 ` sashiko-bot
2026-09-17 5:00 ` [PATCH v1 01/11] perf aslr: Add missing includes and sort headers sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917045326.63601-6-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=sashiko-bot@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.