From: sashiko-bot@kernel.org
To: "Ian Rogers" <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v1 03/11] perf unwind-libdw: missing <stdlib.h> in libdw_set_initial_registers()
Date: Thu, 17 Sep 2026 04:59:18 +0000 [thread overview]
Message-ID: <20260917045918.6A05B1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260917045326.63601-3-irogers@google.com>
> Sashiko reported:
>
> When building the perf tool against strict C standard libraries
> (such as musl libc), compilation fails in
> tools/perf/util/unwind-libdw.c due to implicit declarations of
> memory allocation functions.
>
> The libdw_set_initial_registers() function dynamically allocates an
> array of DWARF registers using calloc() and subsequently releases it
> with free(). However, the source file lacks an explicit #include
> <stdlib.h>. On build environments where standard headers do not
> implicitly chain-include <stdlib.h>, these functions remain
> undeclared, resulting in fatal implicit function declaration errors
> that break the build.
>
> Add the header files and use git clang-format to sort.
>
> Reported-by: sashiko-bot@kernel.org
> Signed-off-by: Ian Rogers <irogers@google.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260917045326.63601-1-irogers@google.com?part=3
next prev parent reply other threads:[~2026-09-17 4:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 4:53 [PATCH v1 01/11] perf aslr: Add missing includes and sort headers Ian Rogers
2026-09-17 4:53 ` [PATCH v1 02/11] perf bench messaging: " Ian Rogers
2026-09-17 4:59 ` sashiko-bot
2026-09-17 4:53 ` [PATCH v1 03/11] perf unwind-libdw: missing <stdlib.h> in libdw_set_initial_registers() Ian Rogers
2026-09-17 4:59 ` sashiko-bot [this message]
2026-09-17 4:53 ` [PATCH v1 04/11] perf llvm: missing explicit POSIX headers in symbol__disassemble_llvm() Ian Rogers
2026-09-17 5:00 ` sashiko-bot
2026-09-17 4:53 ` [PATCH v1 05/11] perf dso: missing POSIX headers string.h and limits.h Ian Rogers
2026-09-17 4:59 ` sashiko-bot
2026-09-17 4:53 ` [PATCH v1 06/11] perf test: missing stdio.h and signal.h inclusions in cmd_test() Ian Rogers
2026-09-17 4:58 ` sashiko-bot
2026-09-17 4:53 ` [PATCH v1 07/11] perf ui annotate-data: missing explicit inclusion of stdlib.h and stdio.h Ian Rogers
2026-09-17 5:00 ` sashiko-bot
2026-09-17 4:53 ` [PATCH v1 08/11] perf annotate-data: missing <string.h> inclusion for libc string functions Ian Rogers
2026-09-17 4:59 ` sashiko-bot
2026-09-17 4:53 ` [PATCH v1 09/11] perf mem: missing stdio.h and limits.h in mem-events.c Ian Rogers
2026-09-17 4:59 ` sashiko-bot
2026-09-17 4:53 ` [PATCH v1 10/11] perf config: undeclared PATH_MAX due to missing <limits.h> inclusion Ian Rogers
2026-09-17 5:01 ` sashiko-bot
2026-09-17 4:53 ` [PATCH v1 11/11] perf mem: missing standard POSIX headers in builtin-mem.c Ian Rogers
2026-09-17 5:02 ` sashiko-bot
2026-09-17 5:00 ` [PATCH v1 01/11] perf aslr: Add missing includes and sort headers sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917045918.6A05B1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=irogers@google.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.