Re: [PATCH v1 06/11] perf test: missing stdio.h and signal.h inclusions in cmd_test()

[sashiko-bot@kernel.org]

> Sashiko reported:
> 
>   When compiling the perf tool against musl libc, the build fails in
>   tools/perf/tests/builtin-test.c due to missing explicit inclusions
>   of <stdio.h> and <signal.h>.
> 
>   The file relies on standard I/O functions like fdopen() and
>   fprintf(), as well as signal handling constructs like signal(),
>   SIGINT, and SIGTERM within __cmd_test() and related helpers. While
>   glibc may implicitly pull in these definitions through other
>   standard headers such as <stdlib.h> or <unistd.h>, musl libc
>   strictly enforces POSIX namespace separation and avoids implicit
>   header inclusion. Because the required headers are absent, the
>   compiler cannot resolve these standard library types and macros,
>   resulting in a direct compilation failure on musl-based systems.
> 
> Add the header files and use git clang-format to sort.
> 
> Reported-by: sashiko-bot@kernel.org
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917045326.63601-1-irogers@google.com?part=6