From: sashiko-bot@kernel.org
To: "Andrew Gaylard" <ag@ffroot.co.za>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: vendor-prefixes: Add Tibbo
Date: Thu, 17 Sep 2026 08:32:27 +0000 [thread overview]
Message-ID: <20260917083227.8CFDD1F00898@smtp.kernel.org> (raw)
In-Reply-To: <20260917082632.626614-2-ag@ffroot.co.za>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: vendor-prefixes: vendor prefix '^tibbo,.*' is not in alphabetical order
--
commit 82f70f6fee71fff5d4d4526f6ffdde8383c90112
Author: Andrew Gaylard <ag@ffroot.co.za>
dt-bindings: vendor-prefixes: Add Tibbo
This commit adds the vendor prefix for Tibbo Technology Inc., manufacturer
of the LTPP3G2 board, to the vendor-prefixes schema.
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 396044f368e7c..bee050d59baa6 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
[ ... ]
> @@ -1692,6 +1692,8 @@ patternProperties:
> description: Thundercomm Technology Co., Ltd.
> "^thwc,.*":
> description: Shenzhen Tong Heng Wei Chuang Technology Co., Ltd.
> + "^tibbo,.*":
> + description: Tibbo Technology Inc.
> "^ti,.*":
[Severity: Low]
This isn't a bug, but does this insertion break the alphabetical ordering
requirement of the patternProperties list? Alphabetically, "tibbo" should
be placed after both "ti" and "tianma" rather than before them.
> description: Texas Instruments
> "^tianma,.*":
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260917082632.626614-1-ag@ffroot.co.za?part=1
next prev parent reply other threads:[~2026-09-17 8:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 8:26 [PATCH v2 0/4] arm: sunplus: add SP7021 LTPP3G2 board support Andrew Gaylard
2026-09-17 8:26 ` [PATCH 1/4] dt-bindings: vendor-prefixes: Add Tibbo Andrew Gaylard
2026-09-17 8:32 ` sashiko-bot [this message]
2026-09-18 11:29 ` Krzysztof Kozlowski
2026-09-18 11:31 ` Krzysztof Kozlowski
2026-09-17 8:26 ` [PATCH 2/4] arm: dts: sunplus: add PWM, watchdog and MMC nodes to SP7021 DTSI Andrew Gaylard
2026-09-17 8:26 ` [PATCH 3/4] arm: dts: sunplus: add Tibbo LTPP3G2 board Andrew Gaylard
2026-09-17 8:43 ` sashiko-bot
2026-09-18 11:31 ` Krzysztof Kozlowski
2026-09-18 14:21 ` Andrew Gaylard
2026-09-17 8:26 ` [PATCH 4/4] configs: sp7021: fix defaults and enable existing device drivers Andrew Gaylard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917083227.8CFDD1F00898@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=ag@ffroot.co.za \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.