All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Gaylard <ag@ffroot.co.za>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
	 devicetree@vger.kernel.org, qinjian@cqplus1.com,
	 robh@kernel.org,  krzk+dt@kernel.org, conor+dt@kernel.org,
	 linux@armlinux.org.uk
Subject: Re: [PATCH 3/4] arm: dts: sunplus: add Tibbo LTPP3G2 board
Date: Fri, 18 Sep 2026 16:21:43 +0200	[thread overview]
Message-ID: <sa6bj9ufxmw.fsf@dev-ag> (raw)
In-Reply-To: <20260918-silent-zircon-cuttlefish-bafcbc@quoll> (Krzysztof Kozlowski's message of "Fri, 18 Sep 2026 13:31:00 +0200")

Krzysztof Kozlowski <krzk@kernel.org> writes:

> On Thu, Sep 17, 2026 at 10:26:31AM +0200, Andrew Gaylard wrote:
>> +		bootargs = "console=ttySUP0,115200 earlycon root=/dev/mmcblk0p8 rootwait";
>
> None of above should be here. earlycon is for debugging. Console is
> below. root - why booting is fixed to mmc? Why none of other boot
> methods are suitable or allowed?

Because as of linux-next 20260915, ethernet does not work (crashes the
chip hard; I have a patch series coming that will fix this), and the SD
and USB drivers are not yet upstream.  That leaves only the eMMC for a
rootfs.

Nonetheless, you're right, none of this belongs in the DTS.
I'll remove the whole line.

>> +	pins_bt_reset: pinmux_bt_reset-pins {
>
> Please follow DTS coding style for naming.

Will do.

-- 
Andrew

  reply	other threads:[~2026-09-18 14:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-17  8:26 [PATCH v2 0/4] arm: sunplus: add SP7021 LTPP3G2 board support Andrew Gaylard
2026-09-17  8:26 ` [PATCH 1/4] dt-bindings: vendor-prefixes: Add Tibbo Andrew Gaylard
2026-09-17  8:32   ` sashiko-bot
2026-09-18 11:29   ` Krzysztof Kozlowski
2026-09-18 11:31     ` Krzysztof Kozlowski
2026-09-17  8:26 ` [PATCH 2/4] arm: dts: sunplus: add PWM, watchdog and MMC nodes to SP7021 DTSI Andrew Gaylard
2026-09-17  8:26 ` [PATCH 3/4] arm: dts: sunplus: add Tibbo LTPP3G2 board Andrew Gaylard
2026-09-17  8:43   ` sashiko-bot
2026-09-18 11:31   ` Krzysztof Kozlowski
2026-09-18 14:21     ` Andrew Gaylard [this message]
2026-09-17  8:26 ` [PATCH 4/4] configs: sp7021: fix defaults and enable existing device drivers Andrew Gaylard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sa6bj9ufxmw.fsf@dev-ag \
    --to=ag@ffroot.co.za \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=qinjian@cqplus1.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.