From: Krzysztof Kozlowski <krzk@kernel.org>
To: Andrew Gaylard <ag@ffroot.co.za>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
qinjian@cqplus1.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux@armlinux.org.uk
Subject: Re: [PATCH 1/4] dt-bindings: vendor-prefixes: Add Tibbo
Date: Fri, 18 Sep 2026 13:31:58 +0200 [thread overview]
Message-ID: <2b3536a5-786d-44cd-9f47-e008a14e9a96@kernel.org> (raw)
In-Reply-To: <20260918-noble-black-numbat-e5ecbf@quoll>
On 18/09/2026 13:29, Krzysztof Kozlowski wrote:
> On Thu, Sep 17, 2026 at 10:26:29AM +0200, Andrew Gaylard wrote:
>> Add the vendor prefix for Tibbo Technology Inc., manufacturer of the LTPP3G2 board.
>>
>> Signed-off-by: Andrew Gaylard <ag@ffroot.co.za>
>
> Wrong order.
Also:
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-18 11:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 8:26 [PATCH v2 0/4] arm: sunplus: add SP7021 LTPP3G2 board support Andrew Gaylard
2026-09-17 8:26 ` [PATCH 1/4] dt-bindings: vendor-prefixes: Add Tibbo Andrew Gaylard
2026-09-17 8:32 ` sashiko-bot
2026-09-18 11:29 ` Krzysztof Kozlowski
2026-09-18 11:31 ` Krzysztof Kozlowski [this message]
2026-09-17 8:26 ` [PATCH 2/4] arm: dts: sunplus: add PWM, watchdog and MMC nodes to SP7021 DTSI Andrew Gaylard
2026-09-17 8:26 ` [PATCH 3/4] arm: dts: sunplus: add Tibbo LTPP3G2 board Andrew Gaylard
2026-09-17 8:43 ` sashiko-bot
2026-09-18 11:31 ` Krzysztof Kozlowski
2026-09-18 14:21 ` Andrew Gaylard
2026-09-17 8:26 ` [PATCH 4/4] configs: sp7021: fix defaults and enable existing device drivers Andrew Gaylard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b3536a5-786d-44cd-9f47-e008a14e9a96@kernel.org \
--to=krzk@kernel.org \
--cc=ag@ffroot.co.za \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=qinjian@cqplus1.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.