* [PATCH] perf: remove unused empty help-unknown-cmd.h header
@ 2026-09-18 3:23 Ethan Nelson-Moore
2026-09-18 3:26 ` sashiko-bot
2026-09-18 5:12 ` Ian Rogers
0 siblings, 2 replies; 4+ messages in thread
From: Ethan Nelson-Moore @ 2026-09-18 3:23 UTC (permalink / raw)
To: Mark Rutland, Alexander Shishkin, Jiri Olsa, Ian Rogers,
Adrian Hunter, James Clark, linux-perf-users
Cc: Ethan Nelson-Moore, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Namhyung Kim
tools/perf/util/help-unknown-cmd.h has been empty and unused ever since
it was added to the kernel in commit 5feaac248a46 ("perf tools: Move
help_unknown_cmd() to its own file"). Remove it.
Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
---
tools/perf/util/help-unknown-cmd.h | 0
1 file changed, 0 insertions(+), 0 deletions(-)
delete mode 100644 tools/perf/util/help-unknown-cmd.h
diff --git a/tools/perf/util/help-unknown-cmd.h b/tools/perf/util/help-unknown-cmd.h
deleted file mode 100644
index e69de29bb2d1..000000000000
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] perf: remove unused empty help-unknown-cmd.h header
2026-09-18 3:23 [PATCH] perf: remove unused empty help-unknown-cmd.h header Ethan Nelson-Moore
@ 2026-09-18 3:26 ` sashiko-bot
2026-09-18 5:12 ` Ian Rogers
1 sibling, 0 replies; 4+ messages in thread
From: sashiko-bot @ 2026-09-18 3:26 UTC (permalink / raw)
To: Ethan Nelson-Moore; +Cc: linux-perf-users
> tools/perf/util/help-unknown-cmd.h has been empty and unused ever since
> it was added to the kernel in commit 5feaac248a46 ("perf tools: Move
> help_unknown_cmd() to its own file"). Remove it.
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260918032356.466938-1-enelsonmoore@gmail.com?part=1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] perf: remove unused empty help-unknown-cmd.h header
2026-09-18 3:23 [PATCH] perf: remove unused empty help-unknown-cmd.h header Ethan Nelson-Moore
2026-09-18 3:26 ` sashiko-bot
@ 2026-09-18 5:12 ` Ian Rogers
2026-09-25 11:06 ` Arnaldo Carvalho de Melo
1 sibling, 1 reply; 4+ messages in thread
From: Ian Rogers @ 2026-09-18 5:12 UTC (permalink / raw)
To: Ethan Nelson-Moore
Cc: Mark Rutland, Alexander Shishkin, Jiri Olsa, Adrian Hunter,
James Clark, linux-perf-users, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Namhyung Kim
On Thu, Sep 17, 2026 at 8:24 PM Ethan Nelson-Moore
<enelsonmoore@gmail.com> wrote:
>
> tools/perf/util/help-unknown-cmd.h has been empty and unused ever since
> it was added to the kernel in commit 5feaac248a46 ("perf tools: Move
> help_unknown_cmd() to its own file"). Remove it.
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
This seems like an accident, the declaration has been in
tools/perf/builtin.h ever since the commit above. Perhaps the header
file is a more natural location, but an empty header file is clearly
useless.
Reviewed-by: Ian Rogers <irogers@google.com>
Thanks,
Ian
> ---
> tools/perf/util/help-unknown-cmd.h | 0
> 1 file changed, 0 insertions(+), 0 deletions(-)
> delete mode 100644 tools/perf/util/help-unknown-cmd.h
>
> diff --git a/tools/perf/util/help-unknown-cmd.h b/tools/perf/util/help-unknown-cmd.h
> deleted file mode 100644
> index e69de29bb2d1..000000000000
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] perf: remove unused empty help-unknown-cmd.h header
2026-09-18 5:12 ` Ian Rogers
@ 2026-09-25 11:06 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2026-09-25 11:06 UTC (permalink / raw)
To: Ian Rogers
Cc: Ethan Nelson-Moore, Mark Rutland, Alexander Shishkin, Jiri Olsa,
Adrian Hunter, James Clark, linux-perf-users, Peter Zijlstra,
Ingo Molnar, Namhyung Kim
On Thu, Sep 17, 2026 at 10:12:44PM -0700, Ian Rogers wrote:
> On Thu, Sep 17, 2026 at 8:24 PM Ethan Nelson-Moore
> <enelsonmoore@gmail.com> wrote:
> >
> > tools/perf/util/help-unknown-cmd.h has been empty and unused ever since
> > it was added to the kernel in commit 5feaac248a46 ("perf tools: Move
> > help_unknown_cmd() to its own file"). Remove it.
> >
> > Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
>
> This seems like an accident, the declaration has been in
> tools/perf/builtin.h ever since the commit above. Perhaps the header
> file is a more natural location, but an empty header file is clearly
> useless.
>
> Reviewed-by: Ian Rogers <irogers@google.com>
Thanks, applied to perf-tools-next, for v7.4.
- Arnaldo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-25 11:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-18 3:23 [PATCH] perf: remove unused empty help-unknown-cmd.h header Ethan Nelson-Moore
2026-09-18 3:26 ` sashiko-bot
2026-09-18 5:12 ` Ian Rogers
2026-09-25 11:06 ` Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.