* [PATCH v3 1/4] dt-bindings: mfd: ti,tps65910: Add wakeup-source and GPIO hogs
2026-09-18 21:01 [PATCH v3 0/4] regulator: dt-bindings: Tegra coupling DT conversions and cleanup Bhargav Joshi
@ 2026-09-18 21:01 ` Bhargav Joshi
2026-09-18 21:05 ` sashiko-bot
2026-09-23 15:18 ` (subset) " Lee Jones
2026-09-18 21:01 ` [PATCH v3 2/4] regulator: dt-bindings: nvidia,tegra-regulators-coupling: Convert to DT schema Bhargav Joshi
` (3 subsequent siblings)
4 siblings, 2 replies; 12+ messages in thread
From: Bhargav Joshi @ 2026-09-18 21:01 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Thierry Reding, Lee Jones, Shree Ramamoorthy,
Thierry Reding, Jonathan Hunter, Dmitry Osipenko,
Svyatoslav Ryhel, Laxman Dewangan
Cc: linux-kernel, devicetree, goledhruva, m-chawdhry, daniel.baluta,
simona.toaca, j.bhargav.u, mfd, Thierry Reding, linux-tegra
Device tree validation throws warnings for the TPS65911 PMIC on Tegra
boards because wakeup-source and GPIO hog nodes are not documented in
the schema, even though the hardware supports them.
Add wakeup-source property and allow child nodes that match the "-hog"
pattern.
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
---
Documentation/devicetree/bindings/mfd/ti,tps65910.yaml | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd/ti,tps65910.yaml b/Documentation/devicetree/bindings/mfd/ti,tps65910.yaml
index f1a76f88fc0c..caff9dc0b2bb 100644
--- a/Documentation/devicetree/bindings/mfd/ti,tps65910.yaml
+++ b/Documentation/devicetree/bindings/mfd/ti,tps65910.yaml
@@ -37,6 +37,8 @@ properties:
interrupt-controller: true
+ wakeup-source: true
+
'#interrupt-cells':
description: Specifies the IRQ number and flags
const: 2
@@ -163,6 +165,12 @@ patternProperties:
vcc7-supply: VRTC input.
vccio-supply: VIO input.
+ "^.+-hog$":
+ type: object
+
+ required:
+ - gpio-hog
+
required:
- compatible
- reg
--
2.55.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH v3 1/4] dt-bindings: mfd: ti,tps65910: Add wakeup-source and GPIO hogs
2026-09-18 21:01 ` [PATCH v3 1/4] dt-bindings: mfd: ti,tps65910: Add wakeup-source and GPIO hogs Bhargav Joshi
@ 2026-09-18 21:05 ` sashiko-bot
2026-09-23 15:18 ` (subset) " Lee Jones
1 sibling, 0 replies; 12+ messages in thread
From: sashiko-bot @ 2026-09-18 21:05 UTC (permalink / raw)
To: Bhargav Joshi; +Cc: robh, conor+dt, mfd, lee, devicetree
> Device tree validation throws warnings for the TPS65911 PMIC on Tegra
> boards because wakeup-source and GPIO hog nodes are not documented in
> the schema, even though the hardware supports them.
>
> Add wakeup-source property and allow child nodes that match the "-hog"
> pattern.
>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260919-ti-tps6586x-v3-0-63dd240f4684@gmail.com?part=1
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: (subset) [PATCH v3 1/4] dt-bindings: mfd: ti,tps65910: Add wakeup-source and GPIO hogs
2026-09-18 21:01 ` [PATCH v3 1/4] dt-bindings: mfd: ti,tps65910: Add wakeup-source and GPIO hogs Bhargav Joshi
2026-09-18 21:05 ` sashiko-bot
@ 2026-09-23 15:18 ` Lee Jones
1 sibling, 0 replies; 12+ messages in thread
From: Lee Jones @ 2026-09-23 15:18 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Thierry Reding, Lee Jones, Shree Ramamoorthy,
Thierry Reding, Jonathan Hunter, Dmitry Osipenko,
Svyatoslav Ryhel, Laxman Dewangan, Bhargav Joshi
Cc: linux-kernel, devicetree, goledhruva, m-chawdhry, daniel.baluta,
simona.toaca, mfd, Thierry Reding, linux-tegra
On Sat, 19 Sep 2026 02:31:22 +0530, Bhargav Joshi wrote:
> Device tree validation throws warnings for the TPS65911 PMIC on Tegra
> boards because wakeup-source and GPIO hog nodes are not documented in
> the schema, even though the hardware supports them.
>
> Add wakeup-source property and allow child nodes that match the "-hog"
> pattern.
>
> [...]
Applied, thanks!
[1/4] dt-bindings: mfd: ti,tps65910: Add wakeup-source and GPIO hogs
commit: 6d39f6cc5ae3a84bccc9acf11ef71e7219c3d35e
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3 2/4] regulator: dt-bindings: nvidia,tegra-regulators-coupling: Convert to DT schema
2026-09-18 21:01 [PATCH v3 0/4] regulator: dt-bindings: Tegra coupling DT conversions and cleanup Bhargav Joshi
2026-09-18 21:01 ` [PATCH v3 1/4] dt-bindings: mfd: ti,tps65910: Add wakeup-source and GPIO hogs Bhargav Joshi
@ 2026-09-18 21:01 ` Bhargav Joshi
2026-09-18 21:10 ` sashiko-bot
2026-09-23 17:44 ` Mark Brown
2026-09-18 21:01 ` [PATCH v3 3/4] regulator: dt-bindings: Reference Tegra regulator coupling schema Bhargav Joshi
` (2 subsequent siblings)
4 siblings, 2 replies; 12+ messages in thread
From: Bhargav Joshi @ 2026-09-18 21:01 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Thierry Reding, Lee Jones, Shree Ramamoorthy,
Thierry Reding, Jonathan Hunter, Dmitry Osipenko,
Svyatoslav Ryhel, Laxman Dewangan
Cc: linux-kernel, devicetree, goledhruva, m-chawdhry, daniel.baluta,
simona.toaca, j.bhargav.u, mfd, Thierry Reding, linux-tegra
Convert NVIDIA Tegra Regulators Coupling from legacy text to DT schema.
Set additionalProperties true as this is shared schema.
Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
---
.../regulator/nvidia,tegra-regulators-coupling.txt | 65 -------------------
.../nvidia,tegra-regulators-coupling.yaml | 74 ++++++++++++++++++++++
2 files changed, 74 insertions(+), 65 deletions(-)
diff --git a/Documentation/devicetree/bindings/regulator/nvidia,tegra-regulators-coupling.txt b/Documentation/devicetree/bindings/regulator/nvidia,tegra-regulators-coupling.txt
deleted file mode 100644
index 4bf2dbf7c6cc..000000000000
--- a/Documentation/devicetree/bindings/regulator/nvidia,tegra-regulators-coupling.txt
+++ /dev/null
@@ -1,65 +0,0 @@
-NVIDIA Tegra Regulators Coupling
-================================
-
-NVIDIA Tegra SoC's have a mandatory voltage-coupling between regulators.
-Thus on Tegra20 there are 3 coupled regulators and on NVIDIA Tegra30
-there are 2.
-
-Tegra20 voltage coupling
-------------------------
-
-On Tegra20 SoC's there are 3 coupled regulators: CORE, RTC and CPU.
-The CORE and RTC voltages shall be in a range of 170mV from each other
-and they both shall be higher than the CPU voltage by at least 120mV.
-
-Tegra30 voltage coupling
-------------------------
-
-On Tegra30 SoC's there are 2 coupled regulators: CORE and CPU. The CORE
-and CPU voltages shall be in a range of 300mV from each other and CORE
-voltage shall be higher than the CPU by N mV, where N depends on the CPU
-voltage.
-
-Required properties:
-- nvidia,tegra-core-regulator: Boolean property that designates regulator
- as the "Core domain" voltage regulator.
-- nvidia,tegra-rtc-regulator: Boolean property that designates regulator
- as the "RTC domain" voltage regulator.
-- nvidia,tegra-cpu-regulator: Boolean property that designates regulator
- as the "CPU domain" voltage regulator.
-
-Example:
-
- pmic {
- regulators {
- core_vdd_reg: core {
- regulator-name = "vdd_core";
- regulator-min-microvolt = <950000>;
- regulator-max-microvolt = <1300000>;
- regulator-coupled-with = <&rtc_vdd_reg &cpu_vdd_reg>;
- regulator-coupled-max-spread = <170000 550000>;
-
- nvidia,tegra-core-regulator;
- };
-
- rtc_vdd_reg: rtc {
- regulator-name = "vdd_rtc";
- regulator-min-microvolt = <950000>;
- regulator-max-microvolt = <1300000>;
- regulator-coupled-with = <&core_vdd_reg &cpu_vdd_reg>;
- regulator-coupled-max-spread = <170000 550000>;
-
- nvidia,tegra-rtc-regulator;
- };
-
- cpu_vdd_reg: cpu {
- regulator-name = "vdd_cpu";
- regulator-min-microvolt = <750000>;
- regulator-max-microvolt = <1125000>;
- regulator-coupled-with = <&core_vdd_reg &rtc_vdd_reg>;
- regulator-coupled-max-spread = <550000 550000>;
-
- nvidia,tegra-cpu-regulator;
- };
- };
- };
diff --git a/Documentation/devicetree/bindings/regulator/nvidia,tegra-regulators-coupling.yaml b/Documentation/devicetree/bindings/regulator/nvidia,tegra-regulators-coupling.yaml
new file mode 100644
index 000000000000..aae951cdce8b
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/nvidia,tegra-regulators-coupling.yaml
@@ -0,0 +1,74 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/nvidia,tegra-regulators-coupling.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NVIDIA Tegra Regulators Coupling
+
+description: >
+ NVIDIA Tegra SoC's have a mandatory voltage-coupling between regulators. Thus
+ on Tegra20 there are 3 coupled regulators and on NVIDIA Tegra30 there are 2.
+
+ On Tegra20 SoC's - there are 3 coupled regulators:CORE, RTC and CPU. The CORE
+ and RTC voltages shall be in a range of 170mV from each other and they both
+ shall be higher than the CPU voltage by at least 120mV.
+
+ On Tegra30 SoC's - there are 2 coupled regulators:CORE and CPU. The CORE and
+ CPU voltages shall be in a range of 300mV from each other and CORE voltage
+ shall be higher than the CPU by N mV, where N depends on the CPU voltage.
+
+maintainers:
+ - Dmitry Osipenko <digetx@gmail.com>
+ - Thierry Reding <treding@nvidia.com>
+
+properties:
+ nvidia,tegra-core-regulator:
+ description: designates regulator as the "Core domain" voltage regulator.
+ type: boolean
+
+ nvidia,tegra-rtc-regulator:
+ description: designates regulator as the "RTC domain" voltage regulator.
+ type: boolean
+
+ nvidia,tegra-cpu-regulator:
+ description: designates regulator as the "CPU domain" voltage regulator.
+ type: boolean
+
+additionalProperties: true
+
+examples:
+ - |
+ pmic {
+ regulators {
+ core_vdd_reg: core {
+ regulator-name = "vdd_core";
+ regulator-min-microvolt = <950000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-coupled-with = <&rtc_vdd_reg &cpu_vdd_reg>;
+ regulator-coupled-max-spread = <170000 550000>;
+
+ nvidia,tegra-core-regulator;
+ };
+
+ rtc_vdd_reg: rtc {
+ regulator-name = "vdd_rtc";
+ regulator-min-microvolt = <950000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-coupled-with = <&core_vdd_reg &cpu_vdd_reg>;
+ regulator-coupled-max-spread = <170000 550000>;
+
+ nvidia,tegra-rtc-regulator;
+ };
+
+ cpu_vdd_reg: cpu {
+ regulator-name = "vdd_cpu";
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <1125000>;
+ regulator-coupled-with = <&core_vdd_reg &rtc_vdd_reg>;
+ regulator-coupled-max-spread = <550000 550000>;
+
+ nvidia,tegra-cpu-regulator;
+ };
+ };
+ };
--
2.55.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH v3 2/4] regulator: dt-bindings: nvidia,tegra-regulators-coupling: Convert to DT schema
2026-09-18 21:01 ` [PATCH v3 2/4] regulator: dt-bindings: nvidia,tegra-regulators-coupling: Convert to DT schema Bhargav Joshi
@ 2026-09-18 21:10 ` sashiko-bot
2026-09-23 17:44 ` Mark Brown
1 sibling, 0 replies; 12+ messages in thread
From: sashiko-bot @ 2026-09-18 21:10 UTC (permalink / raw)
To: Bhargav Joshi; +Cc: conor+dt, devicetree, lee, mfd, robh
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: example properties are bypassed during schema validation
--
commit 6fc294a8a0e1ff8d45fed563be8b2e544b6e1cc3
Author: Bhargav Joshi <j.bhargav.u@gmail.com>
regulator: dt-bindings: nvidia,tegra-regulators-coupling: Convert to DT schema
Convert NVIDIA Tegra Regulators Coupling from legacy text to DT schema.
Set additionalProperties true as this is shared schema.
> diff --git a/Documentation/devicetree/bindings/regulator/nvidia,tegra-regulators-coupling.yaml b/Documentation/devicetree/bindings/regulator/nvidia,tegra-regulators-coupling.yaml
> new file mode 100644
> index 0000000000000..aae951cdce8ba
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/nvidia,tegra-regulators-coupling.yaml
[ ... ]
> +examples:
> + - |
> + pmic {
> + regulators {
[Severity: Low]
Since the example encapsulates the regulator nodes inside 'pmic' and
'regulators' parent nodes, and the schema lacks a selection mechanism for these
subnodes while allowing 'additionalProperties: true', will the validation tool
only check the root 'pmic' node?
This causes the actual 'nvidia,tegra-*-regulator' properties defined in
the subnodes to be ignored by dt_binding_check. Wrapping the nodes prevents
the root-level schema from validating the properties within the specific
regulator nodes.
> + core_vdd_reg: core {
> + regulator-name = "vdd_core";
> + regulator-min-microvolt = <950000>;
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260919-ti-tps6586x-v3-0-63dd240f4684@gmail.com?part=2
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v3 2/4] regulator: dt-bindings: nvidia,tegra-regulators-coupling: Convert to DT schema
2026-09-18 21:01 ` [PATCH v3 2/4] regulator: dt-bindings: nvidia,tegra-regulators-coupling: Convert to DT schema Bhargav Joshi
2026-09-18 21:10 ` sashiko-bot
@ 2026-09-23 17:44 ` Mark Brown
1 sibling, 0 replies; 12+ messages in thread
From: Mark Brown @ 2026-09-23 17:44 UTC (permalink / raw)
To: Bhargav Joshi
Cc: Liam Girdwood, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Thierry Reding, Lee Jones, Shree Ramamoorthy, Thierry Reding,
Jonathan Hunter, Dmitry Osipenko, Svyatoslav Ryhel,
Laxman Dewangan, linux-kernel, devicetree, goledhruva, m-chawdhry,
daniel.baluta, simona.toaca, mfd, Thierry Reding, linux-tegra
[-- Attachment #1: Type: text/plain, Size: 272 bytes --]
On Sat, Sep 19, 2026 at 02:31:23AM +0530, Bhargav Joshi wrote:
> Convert NVIDIA Tegra Regulators Coupling from legacy text to DT schema.
> Set additionalProperties true as this is shared schema.
This and patch 3 don't apply against current code, please check and
resend.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v3 3/4] regulator: dt-bindings: Reference Tegra regulator coupling schema
2026-09-18 21:01 [PATCH v3 0/4] regulator: dt-bindings: Tegra coupling DT conversions and cleanup Bhargav Joshi
2026-09-18 21:01 ` [PATCH v3 1/4] dt-bindings: mfd: ti,tps65910: Add wakeup-source and GPIO hogs Bhargav Joshi
2026-09-18 21:01 ` [PATCH v3 2/4] regulator: dt-bindings: nvidia,tegra-regulators-coupling: Convert to DT schema Bhargav Joshi
@ 2026-09-18 21:01 ` Bhargav Joshi
2026-09-18 21:07 ` sashiko-bot
2026-09-18 21:01 ` [PATCH v3 4/4] regulator: dt-bindings: ti,tps6586x: Convert to DT schema Bhargav Joshi
2026-09-23 17:46 ` (subset) [PATCH v3 0/4] regulator: dt-bindings: Tegra coupling DT conversions and cleanup Mark Brown
4 siblings, 1 reply; 12+ messages in thread
From: Bhargav Joshi @ 2026-09-18 21:01 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Thierry Reding, Lee Jones, Shree Ramamoorthy,
Thierry Reding, Jonathan Hunter, Dmitry Osipenko,
Svyatoslav Ryhel, Laxman Dewangan
Cc: linux-kernel, devicetree, goledhruva, m-chawdhry, daniel.baluta,
simona.toaca, j.bhargav.u, mfd, Thierry Reding, linux-tegra
Several PMICs used on Tegra boards TPS65910, TPS62360, and MAX77620 use
Tegra-specific regulator coupling properties. Update their dt bindings
to reference the shared nvidia,tegra-regulators-coupling.yaml schema.
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
---
Documentation/devicetree/bindings/mfd/ti,tps65910.yaml | 12 +++++++++---
.../bindings/regulator/maxim,max77620-regulator.yaml | 5 ++++-
Documentation/devicetree/bindings/regulator/ti,tps62360.yaml | 1 +
3 files changed, 14 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/ti,tps65910.yaml b/Documentation/devicetree/bindings/mfd/ti,tps65910.yaml
index caff9dc0b2bb..798d27099401 100644
--- a/Documentation/devicetree/bindings/mfd/ti,tps65910.yaml
+++ b/Documentation/devicetree/bindings/mfd/ti,tps65910.yaml
@@ -99,7 +99,9 @@ properties:
patternProperties:
"^(vrtc|vio|vpll|vdac|vmmc|vbb|vddctrl)$":
type: object
- $ref: /schemas/regulator/regulator.yaml#
+ allOf:
+ - $ref: /schemas/regulator/regulator.yaml#
+ - $ref: /schemas/regulator/nvidia,tegra-regulators-coupling.yaml#
properties:
ti,regulator-ext-sleep-control:
description: |
@@ -112,7 +114,9 @@ properties:
"^(vdd[1-3]|vaux([1-2]|33)|vdig[1-2])$":
type: object
- $ref: /schemas/regulator/regulator.yaml#
+ allOf:
+ - $ref: /schemas/regulator/regulator.yaml#
+ - $ref: /schemas/regulator/nvidia,tegra-regulators-coupling.yaml#
properties:
ti,regulator-ext-sleep-control:
description: |
@@ -125,7 +129,9 @@ properties:
"^ldo[1-8]$":
type: object
- $ref: /schemas/regulator/regulator.yaml#
+ allOf:
+ - $ref: /schemas/regulator/regulator.yaml#
+ - $ref: /schemas/regulator/nvidia,tegra-regulators-coupling.yaml#
properties:
ti,regulator-ext-sleep-control:
description: |
diff --git a/Documentation/devicetree/bindings/regulator/maxim,max77620-regulator.yaml b/Documentation/devicetree/bindings/regulator/maxim,max77620-regulator.yaml
index 7118c34961ba..67fbe7d6dc1c 100644
--- a/Documentation/devicetree/bindings/regulator/maxim,max77620-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/maxim,max77620-regulator.yaml
@@ -22,7 +22,10 @@ patternProperties:
"^(sd[0-3]|ldo[0-8])$":
type: object
- $ref: /schemas/regulator/regulator.yaml#
+ allOf:
+ - $ref: /schemas/regulator/regulator.yaml#
+ - $ref: /schemas/regulator/nvidia,tegra-regulators-coupling.yaml#
+
unevaluatedProperties: false
properties:
diff --git a/Documentation/devicetree/bindings/regulator/ti,tps62360.yaml b/Documentation/devicetree/bindings/regulator/ti,tps62360.yaml
index 90c39275c150..6768fc6ea0d3 100644
--- a/Documentation/devicetree/bindings/regulator/ti,tps62360.yaml
+++ b/Documentation/devicetree/bindings/regulator/ti,tps62360.yaml
@@ -20,6 +20,7 @@ description: |
allOf:
- $ref: regulator.yaml#
+ - $ref: /schemas/regulator/nvidia,tegra-regulators-coupling.yaml#
properties:
compatible:
--
2.55.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v3 4/4] regulator: dt-bindings: ti,tps6586x: Convert to DT schema
2026-09-18 21:01 [PATCH v3 0/4] regulator: dt-bindings: Tegra coupling DT conversions and cleanup Bhargav Joshi
` (2 preceding siblings ...)
2026-09-18 21:01 ` [PATCH v3 3/4] regulator: dt-bindings: Reference Tegra regulator coupling schema Bhargav Joshi
@ 2026-09-18 21:01 ` Bhargav Joshi
2026-09-18 21:10 ` sashiko-bot
2026-09-23 17:46 ` (subset) [PATCH v3 0/4] regulator: dt-bindings: Tegra coupling DT conversions and cleanup Mark Brown
4 siblings, 1 reply; 12+ messages in thread
From: Bhargav Joshi @ 2026-09-18 21:01 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Thierry Reding, Lee Jones, Shree Ramamoorthy,
Thierry Reding, Jonathan Hunter, Dmitry Osipenko,
Svyatoslav Ryhel, Laxman Dewangan
Cc: linux-kernel, devicetree, goledhruva, m-chawdhry, daniel.baluta,
simona.toaca, j.bhargav.u, mfd, Thierry Reding, linux-tegra
Convert Texas Instruments tps6586x regulator binding from text to DT
schema. Reference to nvidia,tegra-regulators-coupling in child regulator
nodes.
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
---
.../devicetree/bindings/regulator/ti,tps6586x.yaml | 196 +++++++++++++++++++++
.../devicetree/bindings/regulator/tps6586x.txt | 135 --------------
2 files changed, 196 insertions(+), 135 deletions(-)
diff --git a/Documentation/devicetree/bindings/regulator/ti,tps6586x.yaml b/Documentation/devicetree/bindings/regulator/ti,tps6586x.yaml
new file mode 100644
index 000000000000..1f7c7b35066f
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/ti,tps6586x.yaml
@@ -0,0 +1,196 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/ti,tps6586x.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TI TPS6586x family of regulators
+
+maintainers:
+ - Thierry Reding <thierry.reding@avionic-design.de>
+
+properties:
+ compatible:
+ const: ti,tps6586x
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ "#gpio-cells":
+ const: 2
+
+ gpio-controller: true
+
+ sys-supply:
+ description: The input supply for SYS.
+
+ ti,system-power-controller:
+ type: boolean
+ description:
+ Whether or not this PMIC is controlling the system power.
+
+ regulators:
+ type: object
+ additionalProperties: false
+ description:
+ list of regulators provided by this controller, LDO5 and LDO_RTC is
+ supplied by SYS regulator internally and driver take care of making
+ proper parent child relationship.
+
+ properties:
+ sys:
+ type: object
+ $ref: regulator.yaml#
+ unevaluatedProperties: false
+
+ patternProperties:
+ "^ldo([0-9]|_rtc)$":
+ type: object
+ allOf:
+ - $ref: /schemas/regulator/regulator.yaml#
+ - $ref: /schemas/regulator/nvidia,tegra-regulators-coupling.yaml#
+ unevaluatedProperties: false
+
+ "^sm[0-2]$":
+ type: object
+ allOf:
+ - $ref: /schemas/regulator/regulator.yaml#
+ - $ref: /schemas/regulator/nvidia,tegra-regulators-coupling.yaml#
+ unevaluatedProperties: false
+
+patternProperties:
+ "^vin-sm[0-2]-supply$":
+ description: The input supply for the corresponding SM (SM0, SM1, or SM2).
+
+ "^vinldo(01|23|4|678|9)-supply$":
+ description: The input supply for the corresponding LDO or group of LDOs.
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - regulators
+ - "#gpio-cells"
+ - gpio-controller
+ - sys-supply
+ - vin-sm0-supply
+ - vin-sm1-supply
+ - vin-sm2-supply
+ - vinldo01-supply
+ - vinldo23-supply
+ - vinldo4-supply
+ - vinldo678-supply
+ - vinldo9-supply
+
+additionalProperties: false
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pmic@34 {
+ compatible = "ti,tps6586x";
+ reg = <0x34>;
+ interrupts = <0 88 0x4>;
+
+ #gpio-cells = <2>;
+ gpio-controller;
+
+ ti,system-power-controller;
+
+ sys-supply = <&vdd_5v0_sys>;
+ vin-sm0-supply = <&sys_reg>;
+ vin-sm1-supply = <&sys_reg>;
+ vin-sm2-supply = <&sys_reg>;
+ vinldo01-supply = <&sm2_reg>;
+ vinldo23-supply = <&sm2_reg>;
+ vinldo4-supply = <&sm2_reg>;
+ vinldo678-supply = <&sm2_reg>;
+ vinldo9-supply = <&sm2_reg>;
+
+ regulators {
+ sys {
+ regulator-name = "vdd_sys";
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ sm0 {
+ regulator-min-microvolt = < 725000>;
+ regulator-max-microvolt = <1500000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ sm1 {
+ regulator-min-microvolt = < 725000>;
+ regulator-max-microvolt = <1500000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ sm2 {
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <4550000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo0 {
+ regulator-name = "PCIE CLK";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ ldo1 {
+ regulator-min-microvolt = < 725000>;
+ regulator-max-microvolt = <1500000>;
+ };
+
+ ldo2 {
+ regulator-min-microvolt = < 725000>;
+ regulator-max-microvolt = <1500000>;
+ };
+
+ ldo3 {
+ regulator-min-microvolt = <1250000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ ldo4 {
+ regulator-min-microvolt = <1700000>;
+ regulator-max-microvolt = <2475000>;
+ };
+
+ ldo5 {
+ regulator-min-microvolt = <1250000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ ldo6 {
+ regulator-min-microvolt = <1250000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ ldo7 {
+ regulator-min-microvolt = <1250000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ ldo8 {
+ regulator-min-microvolt = <1250000>;
+ regulator-max-microvolt = <3300000>;
+ };
+
+ ldo9 {
+ regulator-min-microvolt = <1250000>;
+ regulator-max-microvolt = <3300000>;
+ };
+ };
+ };
+ };
diff --git a/Documentation/devicetree/bindings/regulator/tps6586x.txt b/Documentation/devicetree/bindings/regulator/tps6586x.txt
deleted file mode 100644
index 8b40cac24d93..000000000000
--- a/Documentation/devicetree/bindings/regulator/tps6586x.txt
+++ /dev/null
@@ -1,135 +0,0 @@
-TPS6586x family of regulators
-
-Required properties:
-- compatible: "ti,tps6586x"
-- reg: I2C slave address
-- interrupts: the interrupt outputs of the controller
-- #gpio-cells: number of cells to describe a GPIO
-- gpio-controller: mark the device as a GPIO controller
-- regulators: A node that houses a sub-node for each regulator within the
- device. Each sub-node is identified using the node's name (or the deprecated
- regulator-compatible property if present), with valid values listed below.
- The content of each sub-node is defined by the standard binding for
- regulators; see regulator.txt.
- sys, sm[0-2], ldo[0-9] and ldo_rtc
-- sys-supply: The input supply for SYS.
-- vin-sm0-supply: The input supply for the SM0.
-- vin-sm1-supply: The input supply for the SM1.
-- vin-sm2-supply: The input supply for the SM2.
-- vinldo01-supply: The input supply for the LDO1 and LDO2
-- vinldo23-supply: The input supply for the LDO2 and LDO3
-- vinldo4-supply: The input supply for the LDO4
-- vinldo678-supply: The input supply for the LDO6, LDO7 and LDO8
-- vinldo9-supply: The input supply for the LDO9
-
-Optional properties:
-- ti,system-power-controller: Telling whether or not this pmic is controlling
- the system power.
-
-Each regulator is defined using the standard binding for regulators.
-
-Note: LDO5 and LDO_RTC is supplied by SYS regulator internally and driver
- take care of making proper parent child relationship.
-
-Example:
-
- pmu: tps6586x@34 {
- compatible = "ti,tps6586x";
- reg = <0x34>;
- interrupts = <0 88 0x4>;
-
- #gpio-cells = <2>;
- gpio-controller;
-
- ti,system-power-controller;
-
- sys-supply = <&some_reg>;
- vin-sm0-supply = <&some_reg>;
- vin-sm1-supply = <&some_reg>;
- vin-sm2-supply = <&some_reg>;
- vinldo01-supply = <...>;
- vinldo23-supply = <...>;
- vinldo4-supply = <...>;
- vinldo678-supply = <...>;
- vinldo9-supply = <...>;
-
- regulators {
- sys_reg: sys {
- regulator-name = "vdd_sys";
- regulator-boot-on;
- regulator-always-on;
- };
-
- sm0_reg: sm0 {
- regulator-min-microvolt = < 725000>;
- regulator-max-microvolt = <1500000>;
- regulator-boot-on;
- regulator-always-on;
- };
-
- sm1_reg: sm1 {
- regulator-min-microvolt = < 725000>;
- regulator-max-microvolt = <1500000>;
- regulator-boot-on;
- regulator-always-on;
- };
-
- sm2_reg: sm2 {
- regulator-min-microvolt = <3000000>;
- regulator-max-microvolt = <4550000>;
- regulator-boot-on;
- regulator-always-on;
- };
-
- ldo0_reg: ldo0 {
- regulator-name = "PCIE CLK";
- regulator-min-microvolt = <3300000>;
- regulator-max-microvolt = <3300000>;
- };
-
- ldo1_reg: ldo1 {
- regulator-min-microvolt = < 725000>;
- regulator-max-microvolt = <1500000>;
- };
-
- ldo2_reg: ldo2 {
- regulator-min-microvolt = < 725000>;
- regulator-max-microvolt = <1500000>;
- };
-
- ldo3_reg: ldo3 {
- regulator-min-microvolt = <1250000>;
- regulator-max-microvolt = <3300000>;
- };
-
- ldo4_reg: ldo4 {
- regulator-min-microvolt = <1700000>;
- regulator-max-microvolt = <2475000>;
- };
-
- ldo5_reg: ldo5 {
- regulator-min-microvolt = <1250000>;
- regulator-max-microvolt = <3300000>;
- };
-
- ldo6_reg: ldo6 {
- regulator-min-microvolt = <1250000>;
- regulator-max-microvolt = <3300000>;
- };
-
- ldo7_reg: ldo7 {
- regulator-min-microvolt = <1250000>;
- regulator-max-microvolt = <3300000>;
- };
-
- ldo8_reg: ldo8 {
- regulator-min-microvolt = <1250000>;
- regulator-max-microvolt = <3300000>;
- };
-
- ldo9_reg: ldo9 {
- regulator-min-microvolt = <1250000>;
- regulator-max-microvolt = <3300000>;
- };
- };
- };
--
2.55.0
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH v3 4/4] regulator: dt-bindings: ti,tps6586x: Convert to DT schema
2026-09-18 21:01 ` [PATCH v3 4/4] regulator: dt-bindings: ti,tps6586x: Convert to DT schema Bhargav Joshi
@ 2026-09-18 21:10 ` sashiko-bot
0 siblings, 0 replies; 12+ messages in thread
From: sashiko-bot @ 2026-09-18 21:10 UTC (permalink / raw)
To: Bhargav Joshi; +Cc: conor+dt, mfd, devicetree, lee, robh
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: regulator: ti,tps6586x: dt_binding_check failure
--
commit 73abdb102237b2babb6d5bfccbbceba8f14006bb
Author: Bhargav Joshi <j.bhargav.u@gmail.com>
regulator: dt-bindings: ti,tps6586x: Convert to DT schema
Convert Texas Instruments tps6586x regulator binding from text to DT
schema. Reference to nvidia,tegra-regulators-coupling in child regulator
nodes.
> diff --git a/Documentation/devicetree/bindings/regulator/ti,tps6586x.yaml b/Documentation/devicetree/bindings/regulator/ti,tps6586x.yaml
> new file mode 100644
> index 0000000000000..1f7c7b35066f8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/ti,tps6586x.yaml
> @@ -0,0 +1,196 @@
[ ... ]
> + sys-supply = <&vdd_5v0_sys>;
> + vin-sm0-supply = <&sys_reg>;
> + vin-sm1-supply = <&sys_reg>;
> + vin-sm2-supply = <&sys_reg>;
> + vinldo01-supply = <&sm2_reg>;
> + vinldo23-supply = <&sm2_reg>;
> + vinldo4-supply = <&sm2_reg>;
> + vinldo678-supply = <&sm2_reg>;
> + vinldo9-supply = <&sm2_reg>;
[Severity: Low]
These properties reference phandle labels (&vdd_5v0_sys, &sys_reg, &sm2_reg)
that are not defined anywhere in the example snippet.
dtc throws a fatal 'Reference to non-existent node or label' error for
unresolved phandles during compilation.
Does this regression cause the example to fail make dt_binding_check?
> +
> + regulators {
> + sys {
> + regulator-name = "vdd_sys";
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + sm0 {
> + regulator-min-microvolt = < 725000>;
> + regulator-max-microvolt = <1500000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + sm1 {
> + regulator-min-microvolt = < 725000>;
> + regulator-max-microvolt = <1500000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + sm2 {
> + regulator-min-microvolt = <3000000>;
[Severity: Low]
The sys and sm2 child regulator nodes are missing the sys_reg: and sm2_reg:
labels that were present in the original text binding and are required to
resolve the internal phandle references.
Are these labels missing here?
> + regulator-max-microvolt = <4550000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260919-ti-tps6586x-v3-0-63dd240f4684@gmail.com?part=4
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: (subset) [PATCH v3 0/4] regulator: dt-bindings: Tegra coupling DT conversions and cleanup
2026-09-18 21:01 [PATCH v3 0/4] regulator: dt-bindings: Tegra coupling DT conversions and cleanup Bhargav Joshi
` (3 preceding siblings ...)
2026-09-18 21:01 ` [PATCH v3 4/4] regulator: dt-bindings: ti,tps6586x: Convert to DT schema Bhargav Joshi
@ 2026-09-23 17:46 ` Mark Brown
4 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2026-09-23 17:46 UTC (permalink / raw)
To: Liam Girdwood, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Thierry Reding, Lee Jones, Shree Ramamoorthy, Thierry Reding,
Jonathan Hunter, Dmitry Osipenko, Svyatoslav Ryhel,
Laxman Dewangan, Bhargav Joshi
Cc: linux-kernel, devicetree, goledhruva, m-chawdhry, daniel.baluta,
simona.toaca, mfd, Thierry Reding, linux-tegra
On Sat, 19 Sep 2026 02:31:21 +0530, Bhargav Joshi wrote:
> regulator: dt-bindings: Tegra coupling DT conversions and cleanup
>
> This series adds a shared DT schema for Tegra regulator coupling,
> updates relevant PMICs to use it, and converts the TI TPS6586x
> bindings to DT schema.
>
> Summary:
> - Patch 1: Fixes existing TPS65910 validation warnings.
> - Patch 2: Converts Tegra regulator coupling to DT schema.
> - Patch 3: Updates Tegra-related PMICs to reference the new schema.
> - Patch 4: Converts TI TPS6586x to DT schema.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-7.4
Thanks!
[4/4] regulator: dt-bindings: ti,tps6586x: Convert to DT schema
https://git.kernel.org/broonie/regulator/c/05a3330f490c
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 12+ messages in thread