Re: [PATCH v3 2/3] EDAC/cadence: Add Cadence DDR EDAC driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] build: build failure due to non-constant mask in FIELD_MODIFY()
--

commit 15d5e31eb920d20f3a957994bd91676f00f4633a
Author: Paul Louvel <paul.louvel@bootlin.com>

EDAC/cadence: Add Cadence DDR EDAC driver
    
Add the Cadence EDAC driver found on the Renesas RZ/N1x SoC. The driver 
adds support for single bit error correction, double bit error detection, 
and software scrubbing.

> diff --git a/drivers/edac/cadence_edac.c b/drivers/edac/cadence_edac.c
> new file mode 100644
> index 0000000000000..409cc792b534e
> --- /dev/null
> +++ b/drivers/edac/cadence_edac.c

[ ... ]

> +static void cdns_rmw(struct cdns_mc_priv *priv, u32 reg, u32 mask, u32 val)
> +{
> +	u32 regval;
> +
> +	mutex_lock(&priv->lock);
> +	regval = readl(priv->io_base + reg);
> +	FIELD_MODIFY(mask, &regval, val);

[Severity: Low]
Will this cause a build failure with certain compiler optimization levels?

FIELD_MODIFY() relies on __BF_FIELD_CHECK(), which requires the passed mask
to be a compile-time constant via a static assertion. Because cdns_rmw()
takes the mask as a parameter and is not explicitly marked inline, if the
compiler decides to outline this function, the mask loses its compile-time
constant property and will trigger a guaranteed build failure.

> +	writel(regval, priv->io_base + reg);
> +	mutex_unlock(&priv->lock);
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260924-paul-v7-3-rc1-edac-v3-0-bd8054a5b180@bootlin.com?part=2