From: "Paul Louvel" <paul.louvel@bootlin.com>
To: "Wolfram Sang" <wsa+renesas@sang-engineering.com>,
<sashiko-reviews@lists.linux.dev>
Cc: "Paul Louvel" <paul.louvel@bootlin.com>,
<devicetree@vger.kernel.org>, <robh@kernel.org>,
<conor+dt@kernel.org>
Subject: Re: [PATCH v3 2/3] EDAC/cadence: Add Cadence DDR EDAC driver
Date: Mon, 28 Sep 2026 09:41:32 +0200 [thread overview]
Message-ID: <DLQS3DSRUIV5.YXZN8EGCJRAW@bootlin.com> (raw)
In-Reply-To: <arZmkv1mbjkHrdFl@shikoro>
On Fri Sep 25, 2026 at 2:18 PM CEST, Wolfram Sang wrote:
>
>> FIELD_MODIFY() relies on __BF_FIELD_CHECK(), which requires the passed mask
>> to be a compile-time constant via a static assertion. Because cdns_rmw()
>> takes the mask as a parameter and is not explicitly marked inline, if the
>> compiler decides to outline this function, the mask loses its compile-time
>> constant property and will trigger a guaranteed build failure.
>
> Maybe just use the binary operators?
Yes, bummer because FIELD_MODIFY() is exactly what I need here. I could add the
__always_inline GCC attribute but the compiler is free anyway to ignore that..
--
Paul Louvel, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-09-28 7:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 14:12 [PATCH v3 0/3] Add Renesas RZ/N1x EDAC driver Paul Louvel
2026-09-24 14:12 ` [PATCH v3 1/3] dt-bindings: edac: cdns,ddr-edac: add Cadence DDR EDAC binding Paul Louvel
2026-09-25 12:30 ` Wolfram Sang
2026-09-25 12:50 ` Miquel Raynal
2026-09-25 12:57 ` Geert Uytterhoeven
2026-09-25 13:14 ` Miquel Raynal
2026-09-24 14:12 ` [PATCH v3 2/3] EDAC/cadence: Add Cadence DDR EDAC driver Paul Louvel
2026-09-24 14:25 ` sashiko-bot
2026-09-25 12:18 ` Wolfram Sang
2026-09-28 7:41 ` Paul Louvel [this message]
2026-09-25 12:02 ` Wolfram Sang
2026-09-28 7:32 ` Paul Louvel
2026-09-24 14:12 ` [PATCH v3 3/3] ARM: dts: renesas: r9a06g032: add EDAC node Paul Louvel
2026-09-25 12:19 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DLQS3DSRUIV5.YXZN8EGCJRAW@bootlin.com \
--to=paul.louvel@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.