From: sashiko-bot@kernel.org
To: "Karl Mehltretter" <kmehltretter@gmail.com>
Cc: damon@lists.linux.dev
Subject: Re: [PATCH v2 1/2] mm/damon/core: preserve the quota passed to damon_new_scheme()
Date: Thu, 24 Sep 2026 20:21:58 +0000 [thread overview]
Message-ID: <20260924202159.6655B1F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260924201615.4478-2-kmehltretter@gmail.com>
> damon_commit_ctx() first commits the running context's parameters to a
> temporary context for validating proposed updates. When
> damon_commit_schemes() creates the temporary schemes, it passes the
> running scheme's quota as the quota parameter of damon_new_scheme().
>
> damon_new_scheme() calls damos_quota_init() on that quota before copying
> it to the new scheme. This clears the running scheme's effective quota,
> feedback input and charging state. Even an update rejected with -EINVAL
> loses the running quota state.
>
> For a size quota, this discards the bytes already charged and allows the
> scheme to use a fresh quota before the reset interval has elapsed. For a
> goal-driven quota, the consist tuner loses its accumulated input and
> restarts from its minimum input. A time quota loses its throughput
> estimate and falls back to the initial estimate.
> [ ... ]
> Fixes: 60bd24f272d0 ("mm/damon/sysfs: test commit input against realistic destination")
> Cc: <stable@vger.kernel.org>
> Link: https://lore.kernel.org/r/20260702212143.0CB6D1F00A3D@smtp.kernel.org/ [1]
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260924201615.4478-1-kmehltretter@gmail.com?part=1
next prev parent reply other threads:[~2026-09-24 20:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 20:16 [PATCH v2 0/2] mm/damon: preserve quota state when constructing schemes Karl Mehltretter
2026-09-24 20:16 ` [PATCH v2 1/2] mm/damon/core: preserve the quota passed to damon_new_scheme() Karl Mehltretter
2026-09-24 20:21 ` sashiko-bot [this message]
2026-09-25 8:47 ` SJ Park
2026-09-24 20:16 ` [PATCH v2 2/2] mm/damon/tests/core-kunit: test preservation of quota state Karl Mehltretter
2026-09-24 20:22 ` sashiko-bot
2026-09-25 8:52 ` [PATCH v2 0/2] mm/damon: preserve quota state when constructing schemes SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924202159.6655B1F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=damon@lists.linux.dev \
--cc=kmehltretter@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.