From: sashiko-bot@kernel.org
To: "Karl Mehltretter" <kmehltretter@gmail.com>
Cc: damon@lists.linux.dev
Subject: Re: [PATCH v2 2/2] mm/damon/tests/core-kunit: test preservation of quota state
Date: Thu, 24 Sep 2026 20:22:54 +0000 [thread overview]
Message-ID: <20260924202255.210EA1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260924201615.4478-3-kmehltretter@gmail.com>
> Check that damon_new_scheme() initializes the new scheme's quota without
> changing the quota passed as a parameter. Cover all eight fields
> initialized by damos_quota_init().
>
> Also check that damon_commit_ctx() preserves those fields in the
> destination scheme for both accepted and rejected parameter updates.
> Use an invalid min_region_sz for the rejected update and confirm that
> returning -EINVAL leaves the running quota state unchanged.
>
> Without the preceding fix, all eight fields are cleared in the
> constructor test and in both context update cases.
>
> Reviewed-by: SJ Park <sj@kernel.org>
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260924201615.4478-1-kmehltretter@gmail.com?part=2
next prev parent reply other threads:[~2026-09-24 20:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 20:16 [PATCH v2 0/2] mm/damon: preserve quota state when constructing schemes Karl Mehltretter
2026-09-24 20:16 ` [PATCH v2 1/2] mm/damon/core: preserve the quota passed to damon_new_scheme() Karl Mehltretter
2026-09-24 20:21 ` sashiko-bot
2026-09-25 8:47 ` SJ Park
2026-09-24 20:16 ` [PATCH v2 2/2] mm/damon/tests/core-kunit: test preservation of quota state Karl Mehltretter
2026-09-24 20:22 ` sashiko-bot [this message]
2026-09-25 8:52 ` [PATCH v2 0/2] mm/damon: preserve quota state when constructing schemes SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260924202255.210EA1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=damon@lists.linux.dev \
--cc=kmehltretter@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.