From: SJ Park <sj@kernel.org>
To: Karl Mehltretter <kmehltretter@gmail.com>
Cc: SJ Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Bijan Tabatabai <bijan311@gmail.com>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] mm/damon: preserve quota state when constructing schemes
Date: Fri, 25 Sep 2026 01:52:20 -0700 [thread overview]
Message-ID: <20260925085221.47343-1-sj@kernel.org> (raw)
In-Reply-To: <20260924201615.4478-1-kmehltretter@gmail.com>
On Thu, 24 Sep 2026 22:16:12 +0200 Karl Mehltretter <kmehltretter@gmail.com> wrote:
> damon_commit_ctx() first commits the running context's parameters to a
> temporary context for validating proposed updates. Constructing the
> temporary schemes clears the running schemes' quota state because
> damon_new_scheme() initializes the quota passed as a parameter before
> copying it to the new scheme. Even an update later rejected with -EINVAL
> loses the running quota state.
>
> Initialize the new scheme's copy instead, and add KUnit tests for the
> constructor and for accepted and rejected context updates.
Looks good to me. Thank you for this series, Karl.
This series is applied to damon/next [1] tree, with an addition of user impact
detail on patch 1. If there is no more change requests and this series is not
added to mm.git in short term (~1 week?), I will ask mm.git maintainer (Andrew
Morton) to pick this. So, no action from your side is needed for now. If it
seems I also forgot doing that or you cannot wait for my action, please feel
free to ping me or Andrew.
[1] https://origin.kernel.org/doc/html/latest/mm/damon/maintainer-profile.html#scm-trees
Thanks,
SJ
prev parent reply other threads:[~2026-09-25 8:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 20:16 [PATCH v2 0/2] mm/damon: preserve quota state when constructing schemes Karl Mehltretter
2026-09-24 20:16 ` [PATCH v2 1/2] mm/damon/core: preserve the quota passed to damon_new_scheme() Karl Mehltretter
2026-09-24 20:21 ` sashiko-bot
2026-09-25 8:47 ` SJ Park
2026-09-24 20:16 ` [PATCH v2 2/2] mm/damon/tests/core-kunit: test preservation of quota state Karl Mehltretter
2026-09-24 20:22 ` sashiko-bot
2026-09-25 8:52 ` SJ Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925085221.47343-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bijan311@gmail.com \
--cc=damon@lists.linux.dev \
--cc=kmehltretter@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.