From: sashiko-bot@kernel.org
To: "Michal Wilczynski" <m.wilczynski@samsung.com>
Cc: "Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
linux-s390@vger.kernel.org, "Heiko Carstens" <hca@linux.ibm.com>
Subject: Re: [PATCH RFC 2/9] lib/lz4: backport upstream's -Wmissing-prototypes fix
Date: Fri, 25 Sep 2026 11:42:20 +0000 [thread overview]
Message-ID: <20260925114221.8DEA61F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260925-lz4-vendor-upstream-v1-2-1c7ffbe21c4b@samsung.com>
> v1.10.0 defines LZ4_loadDict_internal() in lz4.c and LZ4HC_searchExtDict()
> in lz4hc.c with external linkage and no prototype, which the kernel's
> -Wmissing-prototypes rejects. The first also prevents linking, since
> lz4_compress.c and lz4_decompress.c both include lz4.c and would each
> define it.
>
> Neither can be forward declared static in lz4_deps.h like the other bare
> helpers, because their signatures use types declared inside the .c files.
>
> Take the two hunks of upstream commit 5ef1f16929b5
> ("fix -Wmissing-prototypes warnings") that apply to the files we vendor.
> This is the only deviation from the tag, and goes away at the next
> re-sync.
>
> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260925-lz4-vendor-upstream-v1-0-1c7ffbe21c4b@samsung.com?part=2
next prev parent reply other threads:[~2026-09-25 11:42 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260925113450eucas1p2fcf838f00f35e1bce0ca04a694cd0cd2@eucas1p2.samsung.com>
2026-09-25 11:27 ` [PATCH RFC 0/9] lib/lz4: stop forking upstream LZ4, vendor it instead Michal Wilczynski
2026-09-25 11:27 ` [f2fs-dev] " Michal Wilczynski
2026-09-25 11:27 ` [PATCH RFC 1/9] lib/lz4: import upstream LZ4 sources verbatim Michal Wilczynski
2026-09-25 11:27 ` [f2fs-dev] " Michal Wilczynski
2026-09-25 11:38 ` sashiko-bot
2026-09-28 4:12 ` Sergey Senozhatsky
2026-09-28 4:12 ` [f2fs-dev] " Sergey Senozhatsky
2026-10-03 23:34 ` Michal Wilczynski
2026-10-03 23:34 ` [f2fs-dev] " Michal Wilczynski
2026-09-28 5:19 ` Sergey Senozhatsky
2026-09-28 5:19 ` [f2fs-dev] " Sergey Senozhatsky
2026-10-03 23:50 ` Michal Wilczynski
2026-10-03 23:50 ` [f2fs-dev] " Michal Wilczynski
2026-10-04 8:33 ` David Laight
2026-10-04 8:33 ` [f2fs-dev] " David Laight
2026-09-30 6:07 ` Sergey Senozhatsky
2026-09-30 6:07 ` [f2fs-dev] " Sergey Senozhatsky
2026-10-03 23:52 ` Michal Wilczynski
2026-10-03 23:52 ` [f2fs-dev] " Michal Wilczynski
2026-09-25 11:27 ` [PATCH RFC 2/9] lib/lz4: backport upstream's -Wmissing-prototypes fix Michal Wilczynski
2026-09-25 11:27 ` [f2fs-dev] " Michal Wilczynski
2026-09-25 11:42 ` sashiko-bot [this message]
2026-09-25 11:27 ` [PATCH RFC 3/9] lib/lz4: add the build environment for the vendored sources Michal Wilczynski
2026-09-25 11:27 ` [f2fs-dev] " Michal Wilczynski
2026-09-25 11:47 ` sashiko-bot
2026-09-28 5:48 ` Sergey Senozhatsky
2026-09-28 5:48 ` [f2fs-dev] " Sergey Senozhatsky
2026-10-04 0:05 ` Michal Wilczynski
2026-10-04 0:05 ` [f2fs-dev] " Michal Wilczynski
2026-09-25 11:27 ` [PATCH RFC 4/9] arch: boot: put the LZ4 freestanding headers on the decompressor path Michal Wilczynski
2026-09-25 11:27 ` [f2fs-dev] " Michal Wilczynski
2026-09-25 11:43 ` sashiko-bot
2026-09-25 11:27 ` [PATCH RFC 5/9] lib/lz4: switch the compressor to the vendored sources Michal Wilczynski
2026-09-25 11:27 ` [f2fs-dev] " Michal Wilczynski
2026-09-25 11:43 ` sashiko-bot
2026-09-25 11:27 ` [PATCH RFC 6/9] lib/lz4: switch the HC " Michal Wilczynski
2026-09-25 11:27 ` [f2fs-dev] " Michal Wilczynski
2026-09-25 11:43 ` sashiko-bot
2026-09-25 11:27 ` [PATCH RFC 7/9] lib/lz4: switch the decompressor " Michal Wilczynski
2026-09-25 11:27 ` [f2fs-dev] " Michal Wilczynski
2026-09-25 11:42 ` sashiko-bot
2026-09-28 4:16 ` Sergey Senozhatsky
2026-09-28 4:16 ` [f2fs-dev] " Sergey Senozhatsky
2026-10-03 23:38 ` Michal Wilczynski
2026-10-03 23:38 ` [f2fs-dev] " Michal Wilczynski
2026-09-25 11:27 ` [PATCH RFC 8/9] lib/lz4: fold lz4_kernel_api.h into <linux/lz4.h> Michal Wilczynski
2026-09-25 11:27 ` [f2fs-dev] " Michal Wilczynski
2026-09-25 11:43 ` sashiko-bot
2026-09-25 11:27 ` [PATCH RFC 9/9] MAINTAINERS: add an entry for the LZ4 compression library Michal Wilczynski
2026-09-25 11:27 ` [f2fs-dev] " Michal Wilczynski
2026-09-25 21:39 ` Eric Biggers
2026-09-25 21:39 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-10-03 22:45 ` Michal Wilczynski
2026-10-03 22:45 ` [f2fs-dev] " Michal Wilczynski
2026-09-25 22:07 ` [PATCH RFC 0/9] lib/lz4: stop forking upstream LZ4, vendor it instead Eric Biggers
2026-09-25 22:07 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-09-28 4:25 ` Sergey Senozhatsky
2026-09-28 4:25 ` [f2fs-dev] " Sergey Senozhatsky
2026-09-28 8:27 ` Sergey Senozhatsky
2026-09-28 8:27 ` [f2fs-dev] " Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925114221.8DEA61F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=m.wilczynski@samsung.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.