Re: [PATCH RFC 7/9] lib/lz4: switch the decompressor to the vendored sources

[sashiko-bot@kernel.org]

> Replace the forked decompressor with thin entry points over the vendored
> lz4.c. The API is already signature-compatible, so every export is a
> plain forwarder. lz4defs.h has no users left and goes.
> 
> lib/decompress_unlz4.c still includes this file for the pre-boot
> decompressor; the exports stay behind #ifndef STATIC.
> 
> That include is why LZ4_streamDecode_t is incomplete: under PREBOOT the
> translation unit has both <linux/lz4.h> and upstream's lz4.h, so both
> must name the same type. Both repeat upstream's forward declaration,
> and the file builds without guards.
> 
> LZ4_streamDecode_t is the last of the three, so LZ4_STREAMDECODESIZE and
> LZ4_STREAMDECODESIZE_U64 go and LZ4_MEM_DECOMPRESS takes over, 32 bytes.
> 
> [ ... ]
> The decompression speed fix has an upstream equivalent, carried since
> v1.9.3 as upstream commit fe2a1b3707d5
> ("Call LZ4_memcpy() instead of memcpy()").
> 
> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925-lz4-vendor-upstream-v1-0-1c7ffbe21c4b@samsung.com?part=7