Re: [PATCH RFC 8/9] lib/lz4: fold lz4_kernel_api.h into <linux/lz4.h>

[sashiko-bot@kernel.org]

> lz4_kernel_api.h carried its own copy of the twenty public prototypes
> because it could not include <linux/lz4.h>, which defined the stream
> types that upstream's headers also define.
> 
> The types are incomplete now, so it can. Two prototype lists for one
> ABI is a drift hazard: the entry points were built against one and their
> callers against the other, so no compiler ever saw both, and MODVERSIONS
> would not catch a mismatch either, since it hashes the exporter's view
> only. Now there is one list.
> 
> It also puts the public constants in scope of the entry points, so the
> size assertions can name them, and the HC level clamp can use
> LZ4HC_CLAMP_CLEVEL, static_asserted equal to upstream's
> LZ4HC_CLEVEL_OPT_MIN.
> 
> Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260925-lz4-vendor-upstream-v1-0-1c7ffbe21c4b@samsung.com?part=8