[PATCH v1] perf build: Clean libperf-gtk.so in 'make clean'

[PATCH v1] perf build: Clean libperf-gtk.so in 'make clean'

[Ian Rogers]

When GTK support was made opt-in (first via GTK2=1 and recently ported
to GTK4=1), $(OUTPUT)libperf-gtk.so is only added to ALL_PROGRAMS when
GTK4 is defined. As a result, running 'make clean' without GTK4=1 does
not remove $(OUTPUT)libperf-gtk.so.

Add $(OUTPUT)libperf-gtk.so explicitly to the core-progs clean list so
it is always removed by 'make clean'.

Fixes: 4751bddd3f983af2 ("perf tools: Make GTK2 support opt-in")
Reported-by: Ian Rogers <irogers@google.com>
Closes: https://lore.kernel.org/linux-perf-users/CAP-5=fV6+mzN3Lf_mCAJ4aP42JFZsF55ekvt8XrX505xOWwrmA@mail.gmail.com/
Assisted-by: Antigravity:gemini-3.1-pro
Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/Makefile.perf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 5e89ff37d5b0..c35316bf5e09 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -985,7 +985,7 @@ clean:: $(LIBAPI)-clean $(LIBBPF)-clean $(LIBSUBCMD)-clean $(LIBSYMBOL)-clean $(
 		-name '*.mypy_log' -delete -o -name '*.pylint_log' -delete
 	$(Q)$(RM) $(OUTPUT).config-detected
 	$(call QUIET_CLEAN, core-progs) $(RM) $(ALL_PROGRAMS) perf perf-read-vdso32 \
-		perf-read-vdsox32 $(OUTPUT)$(LIBJVMTI).so
+		perf-read-vdsox32 $(OUTPUT)$(LIBJVMTI).so $(OUTPUT)libperf-gtk.so
 	$(call QUIET_CLEAN, core-gen)   $(RM)  *.spec *.pyc *.pyo */*.pyc */*.pyo \
 		TAGS tags cscope* $(OUTPUT)PERF-VERSION-FILE \
 		$(OUTPUT)FEATURE-DUMP $(OUTPUT)util/*-bison* $(OUTPUT)util/*-flex* \
-- 
2.56.0.rc1.315.gc6ed9934b7-goog

Re: [PATCH v1] perf build: Clean libperf-gtk.so in 'make clean'

[sashiko-bot]

> When GTK support was made opt-in (first via GTK2=1 and recently ported
> to GTK4=1), $(OUTPUT)libperf-gtk.so is only added to ALL_PROGRAMS when
> GTK4 is defined. As a result, running 'make clean' without GTK4=1 does
> not remove $(OUTPUT)libperf-gtk.so.
> 
> Add $(OUTPUT)libperf-gtk.so explicitly to the core-progs clean list so
> it is always removed by 'make clean'.
> 
> Fixes: 4751bddd3f983af2 ("perf tools: Make GTK2 support opt-in")
> Reported-by: Ian Rogers <irogers@google.com>
> Closes: https://lore.kernel.org/linux-perf-users/CAP-5=fV6+mzN3Lf_mCAJ4aP42JFZsF55ekvt8XrX505xOWwrmA@mail.gmail.com/
> Assisted-by: Antigravity:gemini-3.1-pro
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928163649.3463451-1-irogers@google.com?part=1

Re: [PATCH v1] perf build: Clean libperf-gtk.so in 'make clean'

[Arnaldo Carvalho de Melo]

On Mon, Sep 28, 2026 at 09:36:49AM -0700, Ian Rogers wrote:
> When GTK support was made opt-in (first via GTK2=1 and recently ported
> to GTK4=1), $(OUTPUT)libperf-gtk.so is only added to ALL_PROGRAMS when
> GTK4 is defined. As a result, running 'make clean' without GTK4=1 does
> not remove $(OUTPUT)libperf-gtk.so.
> 
> Add $(OUTPUT)libperf-gtk.so explicitly to the core-progs clean list so
> it is always removed by 'make clean'.

Thanks, applied to perf-tools-next, for v7.4.

- Arnaldo