From: Filip Hejsek <filip.hejsek@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Amit Shah" <amit@kernel.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Zhao Liu" <zhao1.liu@intel.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Maximilian Immanuel Brandtner" <maxbr@linux.ibm.com>,
"Dominique Martinet" <asmadeus@codewreck.org>,
"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>,
"Szymon Lukasz" <noh4hss@gmail.com>
Subject: [PATCH v8 12/12] virtio-console: notify the guest about terminal resizes
Date: Tue, 29 Sep 2026 18:38:40 +0200 [thread overview]
Message-ID: <20260929-console-resize-v8-12-2ff9183f8750@gmail.com> (raw)
In-Reply-To: <20260929-console-resize-v8-0-2ff9183f8750@gmail.com>
From: Szymon Lukasz <noh4hss@gmail.com>
If a virtio serial port is a console port, forward terminal resize
messages from the chardev backend to the guest.
Signed-off-by: Szymon Lukasz <noh4hss@gmail.com>
[Filip: rename things, remove logic that is now handled in virtio-serial-bus.c]
Signed-off-by: Filip Hejsek <filip.hejsek@gmail.com>
---
hw/char/virtio-console.c | 34 +++++++++++++++++++++++++++++++---
1 file changed, 31 insertions(+), 3 deletions(-)
diff --git a/hw/char/virtio-console.c b/hw/char/virtio-console.c
index 36ad2ddc3f..db9d8ca797 100644
--- a/hw/char/virtio-console.c
+++ b/hw/char/virtio-console.c
@@ -107,6 +107,15 @@ static ssize_t flush_buf(VirtIOSerialPort *port,
return ret;
}
+static void virtconsole_update_size(VirtIOSerialPort *port)
+{
+ uint16_t cols, rows;
+ VirtConsole *vcon = VIRTIO_CONSOLE(port);
+
+ qemu_chr_fe_get_winsize(&vcon->chr, &cols, &rows);
+ virtio_serial_resize_console(port, cols, rows);
+}
+
/* Callback function that's called when the guest opens/closes the port */
static void set_guest_connected(VirtIOSerialPort *port, int guest_connected)
{
@@ -171,6 +180,23 @@ static void chr_event(void *opaque, QEMUChrEvent event)
}
}
+static void chr_event_console(void *opaque, QEMUChrEvent event)
+{
+ VirtConsole *vcon = opaque;
+ VirtIOSerialPort *port = VIRTIO_SERIAL_PORT(vcon);
+
+ trace_virtio_console_chr_event(port->id, event);
+ switch (event) {
+ case CHR_EVENT_OPENED:
+ case CHR_EVENT_MUX_IN:
+ case CHR_EVENT_RESIZE:
+ virtconsole_update_size(port);
+ break;
+ default:
+ break;
+ }
+}
+
static int chr_be_change(void *opaque)
{
VirtConsole *vcon = opaque;
@@ -179,7 +205,9 @@ static int chr_be_change(void *opaque)
if (k->is_console) {
qemu_chr_fe_set_handlers(&vcon->chr, chr_can_read, chr_read,
- NULL, chr_be_change, vcon, NULL, true);
+ chr_event_console, chr_be_change,
+ vcon, NULL, true);
+ virtconsole_update_size(port);
} else {
qemu_chr_fe_set_handlers(&vcon->chr, chr_can_read, chr_read,
chr_event, chr_be_change, vcon, NULL, false);
@@ -207,7 +235,7 @@ static void virtconsole_enable_backend(VirtIOSerialPort *port, bool enable)
VirtIOSerialPortClass *k = VIRTIO_SERIAL_PORT_GET_CLASS(port);
qemu_chr_fe_set_handlers(&vcon->chr, chr_can_read, chr_read,
- k->is_console ? NULL : chr_event,
+ k->is_console ? chr_event_console : chr_event,
chr_be_change, vcon, NULL, false);
} else {
qemu_chr_fe_set_handlers(&vcon->chr, NULL, NULL, NULL,
@@ -239,7 +267,7 @@ static void virtconsole_realize(DeviceState *dev, Error **errp)
*/
if (k->is_console) {
qemu_chr_fe_set_handlers(&vcon->chr, chr_can_read, chr_read,
- NULL, chr_be_change,
+ chr_event_console, chr_be_change,
vcon, NULL, true);
virtio_serial_open(port);
} else {
--
2.55.0
prev parent reply other threads:[~2026-09-29 16:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 16:38 [PATCH v8 00/12] virtio-console: notify about the terminal size Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 01/12] chardev: add cols, rows fields Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 02/12] chardev: add CHR_EVENT_RESIZE Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 03/12] chardev: add qemu_chr_resize() Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 04/12] char-mux: add support for the terminal size Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 05/12] main-loop: change the handling of SIGWINCH Filip Hejsek
2026-09-30 8:45 ` marcandre.lureau
2026-09-29 16:38 ` [PATCH v8 06/12] char-stdio: add support for the terminal size Filip Hejsek
2026-09-30 8:45 ` marcandre.lureau
2026-09-29 16:38 ` [PATCH v8 07/12] char-win-stdio: add support for " Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 08/12] ui/console-vc: forward text console size to vc chardev Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 09/12] ui/gtk: forward gtk " Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 10/12] qmp: add chardev-window-size-changed command Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 11/12] virtio-serial-bus: add terminal resize messages Filip Hejsek
2026-09-29 16:38 ` Filip Hejsek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929-console-resize-v8-12-2ff9183f8750@gmail.com \
--to=filip.hejsek@gmail.com \
--cc=amit@kernel.org \
--cc=armbru@redhat.com \
--cc=asmadeus@codewreck.org \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=maxbr@linux.ibm.com \
--cc=mst@redhat.com \
--cc=noh4hss@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
--cc=wangyanan55@huawei.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.