From: Filip Hejsek <filip.hejsek@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Amit Shah" <amit@kernel.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Zhao Liu" <zhao1.liu@intel.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Maximilian Immanuel Brandtner" <maxbr@linux.ibm.com>,
"Dominique Martinet" <asmadeus@codewreck.org>,
"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>,
"Szymon Lukasz" <noh4hss@gmail.com>
Subject: [PATCH v8 06/12] char-stdio: add support for the terminal size
Date: Tue, 29 Sep 2026 18:38:34 +0200 [thread overview]
Message-ID: <20260929-console-resize-v8-6-2ff9183f8750@gmail.com> (raw)
In-Reply-To: <20260929-console-resize-v8-0-2ff9183f8750@gmail.com>
From: Szymon Lukasz <noh4hss@gmail.com>
Update the terminal size upon SIGWINCH delivery.
Signed-off-by: Szymon Lukasz <noh4hss@gmail.com>
[Filip: use DECLARE_INSTANCE_CHECKER, qemu_chr_resize_stdio -> stdio_chr_resize]
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Filip Hejsek <filip.hejsek@gmail.com>
---
chardev/char-stdio.c | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/chardev/char-stdio.c b/chardev/char-stdio.c
index fe1cbb2d88..4fc8db212c 100644
--- a/chardev/char-stdio.c
+++ b/chardev/char-stdio.c
@@ -34,7 +34,9 @@
#include "chardev/char-win-stdio.h"
#else
#include <termios.h>
+#include <sys/ioctl.h>
#include "chardev/char-fd.h"
+#include "qemu/main-loop.h"
#endif
#ifndef _WIN32
@@ -46,6 +48,14 @@ static bool stdio_in_use;
static bool stdio_allow_signal;
static bool stdio_echo_state;
+typedef struct {
+ FDChardev parent;
+ Notifier resize_notifier;
+} StdioChardev;
+
+DECLARE_INSTANCE_CHECKER(StdioChardev, STDIO_CHARDEV,
+ TYPE_CHARDEV_STDIO)
+
static void term_exit(void)
{
if (stdio_in_use) {
@@ -85,8 +95,23 @@ static void term_stdio_handler(int sig)
stdio_chr_set_echo(NULL, stdio_echo_state);
}
+static void stdio_chr_resize(Chardev *chr)
+{
+ struct winsize ws;
+ if (ioctl(1, TIOCGWINSZ, &ws) != -1) {
+ qemu_chr_resize(chr, ws.ws_col, ws.ws_row);
+ }
+}
+
+static void term_resize_notify(Notifier *n, void *data)
+{
+ StdioChardev *s = container_of(n, StdioChardev, resize_notifier);
+ stdio_chr_resize(CHARDEV(s));
+}
+
static bool stdio_chr_open(Chardev *chr, ChardevBackend *backend, Error **errp)
{
+ StdioChardev *s = STDIO_CHARDEV(chr);
ChardevStdio *opts = backend->u.stdio.data;
struct sigaction act;
@@ -121,6 +146,10 @@ static bool stdio_chr_open(Chardev *chr, ChardevBackend *backend, Error **errp)
stdio_allow_signal = !opts->has_signal || opts->signal;
stdio_chr_set_echo(chr, false);
+ s->resize_notifier.notify = term_resize_notify;
+ sigwinch_add_notifier(&s->resize_notifier);
+ stdio_chr_resize(chr);
+
qemu_chr_be_event(chr, CHR_EVENT_OPENED);
return true;
}
@@ -162,6 +191,7 @@ static const TypeInfo char_stdio_type_info = {
.parent = TYPE_CHARDEV_WIN_STDIO,
#else
.parent = TYPE_CHARDEV_FD,
+ .instance_size = sizeof(StdioChardev),
#endif
.instance_finalize = char_stdio_finalize,
.class_init = char_stdio_class_init,
--
2.55.0
next prev parent reply other threads:[~2026-09-29 16:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 16:38 [PATCH v8 00/12] virtio-console: notify about the terminal size Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 01/12] chardev: add cols, rows fields Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 02/12] chardev: add CHR_EVENT_RESIZE Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 03/12] chardev: add qemu_chr_resize() Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 04/12] char-mux: add support for the terminal size Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 05/12] main-loop: change the handling of SIGWINCH Filip Hejsek
2026-09-30 8:45 ` marcandre.lureau
2026-09-29 16:38 ` Filip Hejsek [this message]
2026-09-30 8:45 ` [PATCH v8 06/12] char-stdio: add support for the terminal size marcandre.lureau
2026-09-29 16:38 ` [PATCH v8 07/12] char-win-stdio: add support for " Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 08/12] ui/console-vc: forward text console size to vc chardev Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 09/12] ui/gtk: forward gtk " Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 10/12] qmp: add chardev-window-size-changed command Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 11/12] virtio-serial-bus: add terminal resize messages Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 12/12] virtio-console: notify the guest about terminal resizes Filip Hejsek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929-console-resize-v8-6-2ff9183f8750@gmail.com \
--to=filip.hejsek@gmail.com \
--cc=amit@kernel.org \
--cc=armbru@redhat.com \
--cc=asmadeus@codewreck.org \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=maxbr@linux.ibm.com \
--cc=mst@redhat.com \
--cc=noh4hss@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
--cc=wangyanan55@huawei.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.