From: Filip Hejsek <filip.hejsek@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Amit Shah" <amit@kernel.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Zhao Liu" <zhao1.liu@intel.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Maximilian Immanuel Brandtner" <maxbr@linux.ibm.com>,
"Dominique Martinet" <asmadeus@codewreck.org>,
"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>
Subject: [PATCH v8 08/12] ui/console-vc: forward text console size to vc chardev
Date: Tue, 29 Sep 2026 18:38:36 +0200 [thread overview]
Message-ID: <20260929-console-resize-v8-8-2ff9183f8750@gmail.com> (raw)
In-Reply-To: <20260929-console-resize-v8-0-2ff9183f8750@gmail.com>
Update the vc chardev size when initializing the console and after
changing the surface image.
NOTE: There seems to be a bug in the code where the dpy_text_resize
callback is not called when the size changes due to changing the
surface image. (Though it doesn't cause any problem in practice
because the callback is only used by ui/ncurses for fixed
consoles, whose size never changes.)
Signed-off-by: Filip Hejsek <filip.hejsek@gmail.com>
---
ui/console-vc.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/ui/console-vc.c b/ui/console-vc.c
index 53d9e9d39b..99cc8f09c8 100644
--- a/ui/console-vc.c
+++ b/ui/console-vc.c
@@ -115,12 +115,19 @@ static int vc_chr_write(Chardev *chr, const uint8_t *buf, int len)
return vt100_input(&s->vt, buf, len);
}
+static void text_console_chr_resize(QemuTextConsole *s)
+{
+ qemu_chr_resize(s->chr, s->vt.width, s->vt.height);
+}
+
static void text_console_invalidate(void *opaque)
{
QemuTextConsole *s = QEMU_TEXT_CONSOLE(opaque);
if (!QEMU_IS_FIXED_TEXT_CONSOLE(s)) {
vt100_set_image(&s->vt, QEMU_CONSOLE(s)->surface->image);
+ text_console_chr_resize(s);
+ /* XXX Shouldn't qemu_text_console_update_size() also be called here? */
}
vt100_refresh(&s->vt);
}
@@ -254,6 +261,7 @@ static bool vc_chr_open(Chardev *chr, ChardevBackend *backend, Error **errp)
s->vt.t_attrib = TEXT_ATTRIBUTES_DEFAULT;
}
+ text_console_chr_resize(s);
qemu_chr_be_event(chr, CHR_EVENT_OPENED);
qemu_console_notify(QEMU_CONSOLE_ADDED, QEMU_CONSOLE(s));
return true;
--
2.55.0
next prev parent reply other threads:[~2026-09-29 16:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 16:38 [PATCH v8 00/12] virtio-console: notify about the terminal size Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 01/12] chardev: add cols, rows fields Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 02/12] chardev: add CHR_EVENT_RESIZE Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 03/12] chardev: add qemu_chr_resize() Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 04/12] char-mux: add support for the terminal size Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 05/12] main-loop: change the handling of SIGWINCH Filip Hejsek
2026-09-30 8:45 ` marcandre.lureau
2026-09-29 16:38 ` [PATCH v8 06/12] char-stdio: add support for the terminal size Filip Hejsek
2026-09-30 8:45 ` marcandre.lureau
2026-09-29 16:38 ` [PATCH v8 07/12] char-win-stdio: add support for " Filip Hejsek
2026-09-29 16:38 ` Filip Hejsek [this message]
2026-09-29 16:38 ` [PATCH v8 09/12] ui/gtk: forward gtk console size to vc chardev Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 10/12] qmp: add chardev-window-size-changed command Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 11/12] virtio-serial-bus: add terminal resize messages Filip Hejsek
2026-09-29 16:38 ` [PATCH v8 12/12] virtio-console: notify the guest about terminal resizes Filip Hejsek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929-console-resize-v8-8-2ff9183f8750@gmail.com \
--to=filip.hejsek@gmail.com \
--cc=amit@kernel.org \
--cc=armbru@redhat.com \
--cc=asmadeus@codewreck.org \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=maxbr@linux.ibm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
--cc=wangyanan55@huawei.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.