Re: [PATCH 10/13] xfs/2305: version of generic/475 that run xfs_scrub -x for each iteration

["Darrick J. Wong" <djwong@kernel.org>]

On Thu, Sep 24, 2026 at 12:07:51PM +0200, Christoph Hellwig wrote:
> To check both the metadata integrity and file system checksums after
> log replay.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  tests/xfs/2305     | 75 ++++++++++++++++++++++++++++++++++++++++++++++
>  tests/xfs/2305.out |  2 ++
>  2 files changed, 77 insertions(+)
>  create mode 100755 tests/xfs/2305
>  create mode 100644 tests/xfs/2305.out
> 
> diff --git a/tests/xfs/2305 b/tests/xfs/2305
> new file mode 100755
> index 000000000000..277f81c13887
> --- /dev/null
> +++ b/tests/xfs/2305
> @@ -0,0 +1,75 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2017 Oracle, Inc.  All Rights Reserved.
> +#
> +# FS QA Test No. 2305
> +#
> +# Copied from generic/475, with added xfs_scrub -x calls for each iteration to
> +# verify the integrity of all file data and metadata.

Same questions that I had for xfs/2304. :D

--D

> +# Test log recovery with repeated (simulated) disk failures.  We kick
> +# off fsstress on the scratch fs, then switch out the underlying device
> +# with dm-error to see what happens when the disk goes down.  Having
> +# taken down the fs in this manner, remount it and repeat.  This test
> +# is a Good Enough (tm) simulation of our internal multipath failure
> +# testing efforts.
> +#
> +. ./common/preamble
> +_begin_fstest shutdown auto log metadata eio recoveryloop smoketest datacsum
> +
> +# Override the default cleanup function.
> +_cleanup()
> +{
> +	_kill_fsstress
> +	_dmerror_unmount
> +	_dmerror_cleanup
> +	cd /
> +	rm -f $tmp.*
> +}
> +
> +# Import common functions.
> +. ./common/dmerror
> +
> +# Modify as appropriate.
> +
> +_require_scratch
> +_require_dm_target error
> +
> +echo "Silence is golden."
> +
> +_scratch_mkfs >> $seqres.full 2>&1
> +_require_metadata_journaling $SCRATCH_DEV
> +_dmerror_init
> +_dmerror_mount
> +
> +while _soak_loop_running $((50 * TIME_FACTOR)); do
> +	_run_fsstress_bg -d $SCRATCH_MNT -n 999999 -p $((LOAD_FACTOR * 4))
> +
> +	# purposely include 0 second sleeps to test shutdown immediately after
> +	# recovery
> +	sleep $((RANDOM % 3))
> +
> +	# This test aims to simulate sudden disk failure, which means that we
> +	# do not want to quiesce the filesystem or otherwise give it a chance
> +	# to flush its logs.  Therefore we want to call dmsetup with the
> +	# --nolockfs parameter; to make this happen we must call the load
> +	# error table helper *without* 'lockfs'.
> +	_dmerror_load_error_table
> +
> +	_kill_fsstress
> +
> +	# Mount again to replay log after loading working table, so we have a
> +	# consistent XFS after test.
> +	_dmerror_unmount || _fail "unmount failed"
> +	_dmerror_load_working_table
> +	_dmerror_mount || _fail "mount failed"
> +
> +	$XFS_SCRUB_PROG -x $SCRATCH_MNT >> $seqres.full 2>&1
> +	if [ $? -ne 0 ]; then
> +		_fail "scrub found errors"
> +	fi
> +done
> +
> +# success, all done
> +status=0
> +exit
> diff --git a/tests/xfs/2305.out b/tests/xfs/2305.out
> new file mode 100644
> index 000000000000..8265227294ca
> --- /dev/null
> +++ b/tests/xfs/2305.out
> @@ -0,0 +1,2 @@
> +QA output created by 2305
> +Silence is golden.
> -- 
> 2.53.0
> 
>