Re: [PATCH 11/13] xfs/2306: test mkfs input validation for RT data csum options

["Darrick J. Wong" <djwong@kernel.org>]

On Thu, Sep 24, 2026 at 12:07:52PM +0200, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  tests/xfs/2306     | 50 ++++++++++++++++++++++++++++++++++++++++++++++
>  tests/xfs/2306.out | 20 +++++++++++++++++++
>  2 files changed, 70 insertions(+)
>  create mode 100755 tests/xfs/2306
>  create mode 100644 tests/xfs/2306.out
> 
> diff --git a/tests/xfs/2306 b/tests/xfs/2306
> new file mode 100755
> index 000000000000..76dac5bb2a69
> --- /dev/null
> +++ b/tests/xfs/2306
> @@ -0,0 +1,50 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +# Copyright (c) 2026 Christoph Hellwig.
> +#
> +# FS QA Test No. 2306
> +#
> +# Test mkfs input checking for the csum and csumbsize options.

I wonder if you want -N so that *only* the options parsing occurs?
That would speed up this test by skipping the actual writes.

OTOH it's useful to test writing out the rtcsum files...

--D

> +#
> +. ./common/preamble
> +_begin_fstest auto quick mkfs zone datacsum
> +
> +. ./common/filter
> +
> +_require_scratch_nocheck
> +
> +expect_fail()
> +{
> +	opts=$1
> +	msg=$2
> +
> +	echo "Testing $msg (expect failure)"
> +	$MKFS_XFS_PROG -f $opts $SCRATCH_DEV 2>&1 | head -n1
> +}
> +
> +expect_fail "-r csum=crc32c" "csum option without zoned"
> +expect_fail "-r csumbsize=32k" "csumbsize option without zoned"
> +expect_fail "-r zoned,csum=crc16" "invalid csum value"
> +expect_fail "-r zoned,csum=crc32c,csumbsize=1k" "too small csumbsize"
> +expect_fail "-r zoned,csum=crc32c,csumbsize=48k" "non-pow2 csumbsize"
> +expect_fail "-r zoned,csum=crc32c,csumbsize=128k" "too large csumbsize"
> +expect_fail "-b size=64k -r zoned,csum=crc32c,csumbsize=32k" "csumbsize < bsize"
> +
> +expect_pass()
> +{
> +	opts=$1
> +	msg=$2
> +
> +	echo "Testing $msg (expect pass)"
> +	$MKFS_XFS_PROG -f $opts $SCRATCH_DEV >> $seqres.full 2>&1 || \
> +		_fail "could not mkfs for $opts"
> +}
> +
> +expect_pass "-r zoned,csum=none" "csum=none"
> +expect_pass "-r zoned,csum=crc32c" "csum=crc32c"
> +expect_pass "-r zoned,csum=crc64" "csum=crc64"
> +expect_pass "-r zoned,csum=crc64,csumbsize=32k" "csum=crc64,csumbsize=32k"
> +expect_pass "-r zoned,csum=crc64,csumbsize=64k" "csum=crc64,csumbsize=64k"
> +
> +status=0
> +exit
> diff --git a/tests/xfs/2306.out b/tests/xfs/2306.out
> new file mode 100644
> index 000000000000..5e79103212ad
> --- /dev/null
> +++ b/tests/xfs/2306.out
> @@ -0,0 +1,20 @@
> +QA output created by 2306
> +Testing csum option without zoned (expect failure)
> +data checksums not supported without zoned mode
> +Testing csumbsize option without zoned (expect failure)
> +RT data csum block size options requires RT data csum type.
> +Testing invalid csum value (expect failure)
> +unknown option -r crc16
> +Testing too small csumbsize (expect failure)
> +Invalid value 1k for -r csumbsize option. Value is too small.
> +Testing non-pow2 csumbsize (expect failure)
> +RT data csum block size of 49152 bytes is not a power of 2
> +Testing too large csumbsize (expect failure)
> +Invalid value 128k for -r csumbsize option. Value is too large.
> +Testing csumbsize < bsize (expect failure)
> +RT data csum block size of 32768 bytes is smaller than fsblock size 65536.
> +Testing csum=none (expect pass)
> +Testing csum=crc32c (expect pass)
> +Testing csum=crc64 (expect pass)
> +Testing csum=crc64,csumbsize=32k (expect pass)
> +Testing csum=crc64,csumbsize=64k (expect pass)
> -- 
> 2.53.0
> 
>