From: sashiko-bot@kernel.org
To: "Marek Vasut" <marex@nabladev.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/5] arm64: dts: st: Fix PF7 AF10 comment
Date: Tue, 29 Sep 2026 19:45:28 +0000 [thread overview]
Message-ID: <20260929194529.46C2B1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260929194035.496244-2-marex@nabladev.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: commit message body incorrectly refers to PF10 instead of PF7
--
commit 78899a4544e13cd3538df70fff331acfca47086d
Author: Marek Vasut <marex@nabladev.com>
arm64: dts: st: Fix PF7 AF10 comment
This commit fixes a comment in the device tree for the STM32MP25 to correctly
identify the AF10 function for pin PF7 as ETH_RGMII_GTX_CLK.
> The PF10 AF10 is ETH_RGMII_GTX_CLK , fix the comment.
[Severity: Low]
This isn't a bug, but the commit message body refers to PF10, while the code
changes and the commit subject both correctly refer to PF7. Should this say
PF7 instead?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260929194035.496244-1-marex@nabladev.com?part=2
next prev parent reply other threads:[~2026-09-29 19:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 19:39 [PATCH 1/5] arm64: dts: st: Add st,io-sync into eth2_rgmii_pins_b Marek Vasut
2026-09-29 19:39 ` [PATCH 2/5] arm64: dts: st: Fix PF7 AF10 comment Marek Vasut
2026-09-29 19:45 ` sashiko-bot [this message]
2026-09-29 19:39 ` [PATCH 3/5] arm64: dts: st: Reuse sdmmc1_*_pins_a pinmux Marek Vasut
2026-10-01 20:32 ` Linus Walleij
2026-09-29 19:39 ` [PATCH 4/5] arm64: dts: st: Drop sdmmc1_*_pins_b pinmux Marek Vasut
2026-09-29 19:39 ` [PATCH 5/5] arm64: dts: st: Do not encode path in sdmmc2_*_pins_a/pins2 phandle Marek Vasut
2026-10-01 9:43 ` Alexandre TORGUE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260929194529.46C2B1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=marex@nabladev.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.