From: sashiko-bot@kernel.org
To: "Ryan Chen" <ryan_chen@aspeedtech.com>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 9/9] MAINTAINERS: Step down as Aspeed AST2500 EDAC driver maintainer
Date: Wed, 30 Sep 2026 05:20:41 +0000 [thread overview]
Message-ID: <20260930052042.6E81D1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260930-edac-v4-9-c2e526f3ed79@aspeedtech.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: edac: incomplete maintainer step-down in yaml file
--
commit 62cc943c15805204002d63eaa041815c7d089e62
Author: Stefan M Schaeckeler <sschaeck@cisco.com>
MAINTAINERS: Step down as Aspeed AST2500 EDAC driver maintainer
This commit moves the original author from MAINTAINERS to CREDITS for the
AST2500 EDAC driver. It also retains the EDAC-AST2500 entry but updates it
to list a reviewer instead.
Link: https://lore.kernel.org/r/20260920225846.4039017-1-sschaeck@cisco.com
> I am stepping down as a maintainer for drivers/edac/aspeed_edac.c and
> Documentation/devicetree/bindings/edac/aspeed,ast2400-sdram-edac.yaml
[Severity: Medium]
The commit message states a step-down from maintaining
Documentation/devicetree/bindings/edac/aspeed,ast2400-sdram-edac.yaml,
but the maintainers list embedded inside the YAML file was not updated.
Currently, the unmodified YAML file still contains:
Documentation/devicetree/bindings/edac/aspeed,ast2400-sdram-edac.yaml:
maintainers:
- Stefan Schaeckeler <sschaeck@cisco.com>
When a developer modifies the AST2500 EDAC binding, patch management
scripts like get_maintainer.pl will still extract this email address
from the unmodified YAML field. Should the maintainers field in the
YAML file be updated to match the commit message?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260930-edac-v4-0-c2e526f3ed79@aspeedtech.com?part=9
prev parent reply other threads:[~2026-09-30 5:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 5:14 [PATCH v4 0/9] Add Aspeed AST2700 SDRAM EDAC support Ryan Chen
2026-09-30 5:14 ` [PATCH v4 1/9] EDAC/aspeed: Set the DIMM grain Ryan Chen
2026-09-30 5:15 ` [PATCH v4 2/9] EDAC/aspeed: Free the interrupt before the mem_ctl_info on remove Ryan Chen
2026-10-04 21:21 ` Borislav Petkov
2026-10-05 3:00 ` Ryan Chen
2026-09-30 5:15 ` [PATCH v4 3/9] EDAC/aspeed: Clean up whitespace and include ordering Ryan Chen
2026-09-30 5:15 ` [PATCH v4 4/9] EDAC/aspeed: Free the mem_ctl_info unconditionally on remove Ryan Chen
2026-09-30 5:15 ` [PATCH v4 5/9] dt-bindings: edac: aspeed: Add AST2700 SDRAM EDAC Ryan Chen
2026-09-30 5:15 ` [PATCH v4 6/9] EDAC/aspeed: Replace regmap with direct register access Ryan Chen
2026-09-30 5:25 ` sashiko-bot
2026-09-30 5:15 ` [PATCH v4 7/9] EDAC/aspeed: Abstract SoC differences behind chip data Ryan Chen
2026-09-30 5:15 ` [PATCH v4 8/9] EDAC/aspeed: Add AST2700 support Ryan Chen
2026-09-30 5:15 ` [PATCH v4 9/9] MAINTAINERS: Step down as Aspeed AST2500 EDAC driver maintainer Ryan Chen
2026-09-30 5:20 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930052042.6E81D1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ryan_chen@aspeedtech.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.