[PATCH 0/4] arm: rockchip: TPL/SPL config options minor fixes

[PATCH 0/4] arm: rockchip: TPL/SPL config options minor fixes

[Massimo Pegorer]

The series fixes some minor issues in TPL and SPL configuration options
handling, improving configurations consistency. Neither functional nor
binary changes intended.

Signed-off-by: Massimo Pegorer <massimo.pegorer+oss@gmail.com>
---
Massimo Pegorer (4):
      arm: rockchip: rv1126: Remove useless TPL_LDSCRIPT default
      arm: rockchip: Avoid TPL_LDSCRIPT configuration when unneeded
      arm: rockchip: Avoid BSS SPL config options when unneeded
      arm: rockchip: Remove useless SPL_SHARES_INIT_SP_ADDR check

 arch/arm/mach-rockchip/Kconfig        | 4 +++-
 arch/arm/mach-rockchip/px30/Kconfig   | 2 +-
 arch/arm/mach-rockchip/rk3328/Kconfig | 2 +-
 arch/arm/mach-rockchip/rk3399/Kconfig | 2 +-
 arch/arm/mach-rockchip/rv1126/Kconfig | 3 ---
 5 files changed, 6 insertions(+), 7 deletions(-)
---
base-commit: a000f2af240eaa996cec92f8d44bad96fdf3f898
change-id: 20261002-config-36524677a702

Best regards,
--  
Massimo Pegorer <massimo.pegorer+oss@gmail.com>

[PATCH 1/4] arm: rockchip: rv1126: Remove useless TPL_LDSCRIPT default

[Massimo Pegorer]

The arch/arm/mach-rockchip/u-boot-tpl.lds linker script file does not
exist. Therefore, in the end, scripts/Makefile.xpl logic fallbacks on
using the arch common linker script: arch/$(ARCH)/cpu/u-boot-spl.lds.
This is also the default value of TPL_LDSCRIPT option common definition
in common/spl/Kconfig, thus dropping this RV1126 specific definition
simplifies the configuration and has no side effect on binary outputs.

The RV1126 Kconfig file with TPL_LDSCRIPT definition has been added by
ffb191e458c ("arm: rockchip: Add RV1126 arch core support") just a few
days after 957848882c8 ("rk32xx: Use standard TPL linker script") that
removed the arch/arm/mach-rockchip/u-boot-tpl.lds linker script file.
The commit date of the second follows the author date of the first: I
suppose this caused the inconsistency.

Signed-off-by: Massimo Pegorer <massimo.pegorer+oss@gmail.com>
---
 arch/arm/mach-rockchip/rv1126/Kconfig | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm/mach-rockchip/rv1126/Kconfig b/arch/arm/mach-rockchip/rv1126/Kconfig
index d066df9a86e..57ef4e1aaf7 100644
--- a/arch/arm/mach-rockchip/rv1126/Kconfig
+++ b/arch/arm/mach-rockchip/rv1126/Kconfig
@@ -43,9 +43,6 @@ config SPL_STACK
 config SPL_STACK_R_ADDR
 	default 0x800000
 
-config TPL_LDSCRIPT
-	default "arch/arm/mach-rockchip/u-boot-tpl.lds"
-
 config TPL_STACK
 	default 0xff718000
 

-- 
2.34.1

Re: [PATCH 1/4] arm: rockchip: rv1126: Remove useless TPL_LDSCRIPT default

[Quentin Schulz]

Hi Massimo,

On 10/2/26 6:35 PM, Massimo Pegorer wrote:
> The arch/arm/mach-rockchip/u-boot-tpl.lds linker script file does not
> exist. Therefore, in the end, scripts/Makefile.xpl logic fallbacks on
> using the arch common linker script: arch/$(ARCH)/cpu/u-boot-spl.lds.
> This is also the default value of TPL_LDSCRIPT option common definition
> in common/spl/Kconfig, thus dropping this RV1126 specific definition
> simplifies the configuration and has no side effect on binary outputs.
> 
> The RV1126 Kconfig file with TPL_LDSCRIPT definition has been added by
> ffb191e458c ("arm: rockchip: Add RV1126 arch core support") just a few
> days after 957848882c8 ("rk32xx: Use standard TPL linker script") that
> removed the arch/arm/mach-rockchip/u-boot-tpl.lds linker script file.
> The commit date of the second follows the author date of the first: I
> suppose this caused the inconsistency.
> 

The CONFIG_[ST]PL_TEXT_BASE symbol wasn't used in 
arch/arm/cpu/u-boot-spl.lds so the undef was unnecessary. 
CONFIG_[ST]PL_MAX_SIZE is handled by scripts/Makefile.xpl and set as 
IMAGE_MAX_SIZE in the linker scripts. I also printed the value of 
LDSCRIPT in scripts/Makefile.xpl, it is the same before and after this 
patch, therefore:

Fixes: ffb191e458c ("arm: rockchip: Add RV1126 arch core support")
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin

[PATCH 2/4] arm: rockchip: Avoid TPL_LDSCRIPT configuration when unneeded

[Massimo Pegorer]

There is no need to define TPL linker script file through TPL_LDSCRIPT
configuration option value when CONFIG_TPL is not selected. Avoid this
useless row in the configuration with no side effect on binary outputs.

Involved boards being built without TPL are a subset of those based on
RK3328 or RK3399. Anyway, keep aligned PX30 Kconfig with this fix, too.

Signed-off-by: Massimo Pegorer <massimo.pegorer+oss@gmail.com>
---
 arch/arm/mach-rockchip/px30/Kconfig   | 2 +-
 arch/arm/mach-rockchip/rk3328/Kconfig | 2 +-
 arch/arm/mach-rockchip/rk3399/Kconfig | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-rockchip/px30/Kconfig b/arch/arm/mach-rockchip/px30/Kconfig
index adba1b49a52..ee36cf213be 100644
--- a/arch/arm/mach-rockchip/px30/Kconfig
+++ b/arch/arm/mach-rockchip/px30/Kconfig
@@ -75,7 +75,7 @@ config SPL_SERIAL
 	default y
 
 config TPL_LDSCRIPT
-	default "arch/arm/mach-rockchip/u-boot-tpl-v8.lds"
+	default "arch/arm/mach-rockchip/u-boot-tpl-v8.lds" if TPL
 
 config TPL_TEXT_BASE
 	default 0xff0e1000
diff --git a/arch/arm/mach-rockchip/rk3328/Kconfig b/arch/arm/mach-rockchip/rk3328/Kconfig
index ec1dae8d413..032d90927f3 100644
--- a/arch/arm/mach-rockchip/rk3328/Kconfig
+++ b/arch/arm/mach-rockchip/rk3328/Kconfig
@@ -22,7 +22,7 @@ config SYS_SOC
 	default "rk3328"
 
 config TPL_LDSCRIPT
-	default "arch/arm/mach-rockchip/u-boot-tpl-v8.lds"
+	default "arch/arm/mach-rockchip/u-boot-tpl-v8.lds" if TPL
 
 config TPL_TEXT_BASE
 	default 0xff091000
diff --git a/arch/arm/mach-rockchip/rk3399/Kconfig b/arch/arm/mach-rockchip/rk3399/Kconfig
index d84a9da8ed5..250e3728948 100644
--- a/arch/arm/mach-rockchip/rk3399/Kconfig
+++ b/arch/arm/mach-rockchip/rk3399/Kconfig
@@ -142,7 +142,7 @@ config SYS_SOC
 	default "rk3399"
 
 config TPL_LDSCRIPT
-	default "arch/arm/mach-rockchip/u-boot-tpl-v8.lds"
+	default "arch/arm/mach-rockchip/u-boot-tpl-v8.lds" if TPL
 
 config TPL_STACK
 	default 0xff8effff

-- 
2.34.1

Re: [PATCH 2/4] arm: rockchip: Avoid TPL_LDSCRIPT configuration when unneeded

[Quentin Schulz]

Hi Massimo,

On 10/2/26 6:35 PM, Massimo Pegorer wrote:
> There is no need to define TPL linker script file through TPL_LDSCRIPT
> configuration option value when CONFIG_TPL is not selected. Avoid this
> useless row in the configuration with no side effect on binary outputs.
> 

What is this helping with?

TPL_LDSCRIPT should only be reachable if TPL is enabled, so adding an

if TPL

is not supposed to do anything. menuconfig incorrectly reports a 
dependency on ROCKCHIP_PX30 (or ROCKCHIP_RK3328 if I entirely remove 
TPL_LDSCRIPT from arch/arm/mach-rockchip/px30/Kconfig), but this patch 
doesn't help with it.

> Involved boards being built without TPL are a subset of those based on
> RK3328 or RK3399. Anyway, keep aligned PX30 Kconfig with this fix, too.
> 

Yes, but PX30 force-enables TPL while the other two don't.

Cheers,
Quentin

Re: [PATCH 2/4] arm: rockchip: Avoid TPL_LDSCRIPT configuration when unneeded

[Massimo Pegorer]

Hi Quentin,

Il giorno mer 14 ott 2026 alle ore 11:31 Quentin Schulz ha scritto:
>
> Hi Massimo,
>
> On 10/2/26 6:35 PM, Massimo Pegorer wrote:
> > There is no need to define TPL linker script file through TPL_LDSCRIPT
> > configuration option value when CONFIG_TPL is not selected. Avoid this
> > useless row in the configuration with no side effect on binary outputs.
> >
>
> What is this helping with?

If you make generic-rk3328_defconfig which has ROCKCHIP_EXTERNAL_TPL=y (and
therefore CONFIG_TPL is not selected), you will see in the .config the line:

CONFIG_TPL_LDSCRIPT="arch/arm/mach-rockchip/u-boot-tpl-v8.lds"

which is useless and misleading. As an example, if you use the qconfig tool,
it will report that generic-rk3328 is using TPL_LDSCRIPT. Indeed, the
generic-rk3328 configuration profile does not need any definition of
TPL_LDSCRIPT because it does not build TPL, being CONFIG_TPL not selected.

This is what I meant by "Avoid this useless row in the configuration".

And by "with no side effect on binary outputs" I meant that the build artifacts
are the same as before.

>
> TPL_LDSCRIPT should only be reachable if TPL is enabled, so adding an
>
> if TPL
>
> is not supposed to do anything. menuconfig incorrectly reports a
> dependency on ROCKCHIP_PX30 (or ROCKCHIP_RK3328 if I entirely remove
> TPL_LDSCRIPT from arch/arm/mach-rockchip/px30/Kconfig), but this patch
> doesn't help with it.
>
> > Involved boards being built without TPL are a subset of those based on
> > RK3328 or RK3399. Anyway, keep aligned PX30 Kconfig with this fix, too.
> >
>
> Yes, but PX30 force-enables TPL while the other two don't.

Correct, ROCKCHIP_PX30 selects TPL while the others do not, therefore the
change I made in px30/Kconfig has no effect on the resulting .config file.
Anyway, it is correct to bind any TPL_LDSCRIPT secondary definition (those in
the SoC Kconfig files) to TPL, because this config option is created in the
context of and to be used within TPL, as stated in common/spl/Kconfig.tpl.

In general, this approach helps to keep configurations cleaner and simpler.

Thanks for your review!
Massimo

>
> Cheers,
> Quentin

[PATCH 3/4] arm: rockchip: Avoid BSS SPL config options when unneeded

[Massimo Pegorer]

The configuration options SPL_BSS_START_ADDR and SPL_BSS_MAX_SIZE are
guarded by SPL_HAS_BSS_LINKER_SECTION and SPL_BSS_LIMIT options in the
common/spl/Kconfig file where they are originally defined. Addition of
a second config statement without 'depends on' guard causes these two
options to be put in the configuration even when the guard is not
selected, which is unneeded and sounds wrong.

Signed-off-by: Massimo Pegorer <massimo.pegorer+oss@gmail.com>
---
 arch/arm/mach-rockchip/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
index 1a2e7847c9e..5ed774159be 100644
--- a/arch/arm/mach-rockchip/Kconfig
+++ b/arch/arm/mach-rockchip/Kconfig
@@ -836,11 +836,13 @@ config SPL_HAS_BSS_LINKER_SECTION
 	default y if ARM64
 
 config SPL_BSS_START_ADDR
+	depends on SPL_HAS_BSS_LINKER_SECTION
 	default 0x63f80000 if SPL_TEXT_BASE = 0x60000000
 	default 0x43f80000 if SPL_TEXT_BASE = 0x40000000
 	default 0x03f80000 if SPL_TEXT_BASE = 0x00000000
 
 config SPL_BSS_MAX_SIZE
+	depends on SPL_BSS_LIMIT
 	default 0x8000 if SPL_BSS_START_ADDR = 0x63f80000
 	default 0x8000 if SPL_BSS_START_ADDR = 0x43f80000
 	default 0x8000 if SPL_BSS_START_ADDR = 0x03f80000

-- 
2.34.1

Re: [PATCH 3/4] arm: rockchip: Avoid BSS SPL config options when unneeded

[Jonas Karlman]

Hi Massimo,

On 10/2/2026 6:36 PM, Massimo Pegorer wrote:
> The configuration options SPL_BSS_START_ADDR and SPL_BSS_MAX_SIZE are
> guarded by SPL_HAS_BSS_LINKER_SECTION and SPL_BSS_LIMIT options in the
> common/spl/Kconfig file where they are originally defined. Addition of
> a second config statement without 'depends on' guard causes these two
> options to be put in the configuration even when the guard is not
> selected, which is unneeded and sounds wrong.
> 
> Signed-off-by: Massimo Pegorer <massimo.pegorer+oss@gmail.com>
> ---
>  arch/arm/mach-rockchip/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
> index 1a2e7847c9e..5ed774159be 100644
> --- a/arch/arm/mach-rockchip/Kconfig
> +++ b/arch/arm/mach-rockchip/Kconfig
> @@ -836,11 +836,13 @@ config SPL_HAS_BSS_LINKER_SECTION
>  	default y if ARM64
>  
>  config SPL_BSS_START_ADDR
> +	depends on SPL_HAS_BSS_LINKER_SECTION

This change is causing make to prompt for SPL_BSS_MAX_SIZE when building
e.g. tinker-s-rk3288_defconfig.

  Maximum size in memory allocated to the SPL BSS (SPL_BSS_MAX_SIZE) [] (NEW)

>  	default 0x63f80000 if SPL_TEXT_BASE = 0x60000000
>  	default 0x43f80000 if SPL_TEXT_BASE = 0x40000000
>  	default 0x03f80000 if SPL_TEXT_BASE = 0x00000000
>  
>  config SPL_BSS_MAX_SIZE
> +	depends on SPL_BSS_LIMIT
>  	default 0x8000 if SPL_BSS_START_ADDR = 0x63f80000
>  	default 0x8000 if SPL_BSS_START_ADDR = 0x43f80000
>  	default 0x8000 if SPL_BSS_START_ADDR = 0x03f80000

Possible adding something like following?

	default 0x8000 if !SPL_HAS_BSS_LINKER_SECTION

Regards,
Jonas

Re: [PATCH 3/4] arm: rockchip: Avoid BSS SPL config options when unneeded

[Massimo Pegorer]

Hi Jonas,

Il giorno dom 4 ott 2026 alle ore 20:54 Jonas Karlman
<jonas@kwiboo.se> ha scritto:
>
> Hi Massimo,
>
> On 10/2/2026 6:36 PM, Massimo Pegorer wrote:
> > The configuration options SPL_BSS_START_ADDR and SPL_BSS_MAX_SIZE are
> > guarded by SPL_HAS_BSS_LINKER_SECTION and SPL_BSS_LIMIT options in the
> > common/spl/Kconfig file where they are originally defined. Addition of
> > a second config statement without 'depends on' guard causes these two
> > options to be put in the configuration even when the guard is not
> > selected, which is unneeded and sounds wrong.
> >
> > Signed-off-by: Massimo Pegorer <massimo.pegorer+oss@gmail.com>
> > ---
> >  arch/arm/mach-rockchip/Kconfig | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
> > index 1a2e7847c9e..5ed774159be 100644
> > --- a/arch/arm/mach-rockchip/Kconfig
> > +++ b/arch/arm/mach-rockchip/Kconfig
> > @@ -836,11 +836,13 @@ config SPL_HAS_BSS_LINKER_SECTION
> >       default y if ARM64
> >
> >  config SPL_BSS_START_ADDR
> > +     depends on SPL_HAS_BSS_LINKER_SECTION
>
> This change is causing make to prompt for SPL_BSS_MAX_SIZE when building
> e.g. tinker-s-rk3288_defconfig.
>
>   Maximum size in memory allocated to the SPL BSS (SPL_BSS_MAX_SIZE) [] (NEW)
>
> >       default 0x63f80000 if SPL_TEXT_BASE = 0x60000000
> >       default 0x43f80000 if SPL_TEXT_BASE = 0x40000000
> >       default 0x03f80000 if SPL_TEXT_BASE = 0x00000000
> >
> >  config SPL_BSS_MAX_SIZE
> > +     depends on SPL_BSS_LIMIT
> >       default 0x8000 if SPL_BSS_START_ADDR = 0x63f80000
> >       default 0x8000 if SPL_BSS_START_ADDR = 0x43f80000
> >       default 0x8000 if SPL_BSS_START_ADDR = 0x03f80000
>
> Possible adding something like following?
>
>         default 0x8000 if !SPL_HAS_BSS_LINKER_SECTION

What about selecting SPL_BSS_MAX_SIZE default based on SPL_TEXT_BASE instead of
SPL_BSS_START_ADDR?

This seems to me more straightforward. As this configuration states, there are
cases where SPL_HAS_BSS_LINKER_SECTION (and thus SPL_BSS_START_ADDR) is not
needed, but SPL_BSS_MAX_SIZE is. Therefore, I would avoid a default definition
based on SPL_BSS_START_ADDR.

On the other hand, I've just noticed that the value is the same in the three
SPL_BSS_MAX_SIZE default statements, so it would probably be even clearer to
have something like (not tested yet):

config SPL_BSS_MAX_SIZE
    default 0x8000 if SPL_BSS_LIMIT

What do you think? Thanks for your revision.

Regards,
Massimo

>
> Regards,
> Jonas

Re: [PATCH 3/4] arm: rockchip: Avoid BSS SPL config options when unneeded

[Jonas Karlman]

Hi Massimo,

On 10/5/2026 1:44 PM, Massimo Pegorer wrote:
> Hi Jonas,
> 
> Il giorno dom 4 ott 2026 alle ore 20:54 Jonas Karlman
> <jonas@kwiboo.se> ha scritto:
>>
>> Hi Massimo,
>>
>> On 10/2/2026 6:36 PM, Massimo Pegorer wrote:
>>> The configuration options SPL_BSS_START_ADDR and SPL_BSS_MAX_SIZE are
>>> guarded by SPL_HAS_BSS_LINKER_SECTION and SPL_BSS_LIMIT options in the
>>> common/spl/Kconfig file where they are originally defined. Addition of
>>> a second config statement without 'depends on' guard causes these two
>>> options to be put in the configuration even when the guard is not
>>> selected, which is unneeded and sounds wrong.
>>>
>>> Signed-off-by: Massimo Pegorer <massimo.pegorer+oss@gmail.com>
>>> ---
>>>  arch/arm/mach-rockchip/Kconfig | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
>>> index 1a2e7847c9e..5ed774159be 100644
>>> --- a/arch/arm/mach-rockchip/Kconfig
>>> +++ b/arch/arm/mach-rockchip/Kconfig
>>> @@ -836,11 +836,13 @@ config SPL_HAS_BSS_LINKER_SECTION
>>>       default y if ARM64
>>>
>>>  config SPL_BSS_START_ADDR
>>> +     depends on SPL_HAS_BSS_LINKER_SECTION
>>
>> This change is causing make to prompt for SPL_BSS_MAX_SIZE when building
>> e.g. tinker-s-rk3288_defconfig.
>>
>>   Maximum size in memory allocated to the SPL BSS (SPL_BSS_MAX_SIZE) [] (NEW)
>>
>>>       default 0x63f80000 if SPL_TEXT_BASE = 0x60000000
>>>       default 0x43f80000 if SPL_TEXT_BASE = 0x40000000
>>>       default 0x03f80000 if SPL_TEXT_BASE = 0x00000000
>>>
>>>  config SPL_BSS_MAX_SIZE
>>> +     depends on SPL_BSS_LIMIT
>>>       default 0x8000 if SPL_BSS_START_ADDR = 0x63f80000
>>>       default 0x8000 if SPL_BSS_START_ADDR = 0x43f80000
>>>       default 0x8000 if SPL_BSS_START_ADDR = 0x03f80000
>>
>> Possible adding something like following?
>>
>>         default 0x8000 if !SPL_HAS_BSS_LINKER_SECTION
> 
> What about selecting SPL_BSS_MAX_SIZE default based on SPL_TEXT_BASE instead of
> SPL_BSS_START_ADDR?

Unsure, the original intent of the BSS_START_ADDR dependency was to only
affect boards that had transitioned to use the common bss and stack
addresses introduced in the commit 008ba0d56d00 ("rockchip: Add common
default bss and stack addresses").

Not fully sure about current migration state for AArch64 targets, I do
not have any rk3368 boards so never tried to migrate targets for that
SoC to use these common addresses. Most/all other AArch64 targets should
now use these defaults so it is likely these checks can be simplified.

> 
> This seems to me more straightforward. As this configuration states, there are
> cases where SPL_HAS_BSS_LINKER_SECTION (and thus SPL_BSS_START_ADDR) is not
> needed, but SPL_BSS_MAX_SIZE is. Therefore, I would avoid a default definition
> based on SPL_BSS_START_ADDR.

It is likely these complex conditions have overplayed its need now that
most AArch64 targets have been migrated to use these defaults.

> 
> On the other hand, I've just noticed that the value is the same in the three
> SPL_BSS_MAX_SIZE default statements, so it would probably be even clearer to
> have something like (not tested yet):
> 
> config SPL_BSS_MAX_SIZE
>     default 0x8000 if SPL_BSS_LIMIT
> 
> What do you think? Thanks for your revision.

Please check current values used for ARCH_ROCKCHIP boards using the
qconfig.py tool. If all boards use this value, we can likely just move
this default to normal "config SPL_BSS_MAX_SIZE" in common/spl/Kconfig.

	default 0x8000 if ARCH_ROCKCHIP

One goal should be to continue migrate as many boards/SoCs to use the
common bss and stack addresses. It should mostly be older ARMv7 SoCs
that I do not have access to that never have been migrated. I do have
access to rk322x boxes, and have some early work for that SoC, but too
much other work to try and upstream before circling back to rk322x :-)

Regards,
Jonas

> 
> Regards,
> Massimo
> 
>>
>> Regards,
>> Jonas

Re: [PATCH 3/4] arm: rockchip: Avoid BSS SPL config options when unneeded

[Massimo Pegorer]

Hi Jonas,

Il giorno mar 13 ott 2026 alle ore 23:01 Jonas Karlman
<jonas@kwiboo.se> ha scritto:
>
> Hi Massimo,
>
> On 10/5/2026 1:44 PM, Massimo Pegorer wrote:
> > Hi Jonas,
> >
> > Il giorno dom 4 ott 2026 alle ore 20:54 Jonas Karlman
> > <jonas@kwiboo.se> ha scritto:
> >>
> >> Hi Massimo,
> >>
> >> On 10/2/2026 6:36 PM, Massimo Pegorer wrote:
> >>> The configuration options SPL_BSS_START_ADDR and SPL_BSS_MAX_SIZE are
> >>> guarded by SPL_HAS_BSS_LINKER_SECTION and SPL_BSS_LIMIT options in the
> >>> common/spl/Kconfig file where they are originally defined. Addition of
> >>> a second config statement without 'depends on' guard causes these two
> >>> options to be put in the configuration even when the guard is not
> >>> selected, which is unneeded and sounds wrong.
> >>>
> >>> Signed-off-by: Massimo Pegorer <massimo.pegorer+oss@gmail.com>
> >>> ---
> >>>  arch/arm/mach-rockchip/Kconfig | 2 ++
> >>>  1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
> >>> index 1a2e7847c9e..5ed774159be 100644
> >>> --- a/arch/arm/mach-rockchip/Kconfig
> >>> +++ b/arch/arm/mach-rockchip/Kconfig
> >>> @@ -836,11 +836,13 @@ config SPL_HAS_BSS_LINKER_SECTION
> >>>       default y if ARM64
> >>>
> >>>  config SPL_BSS_START_ADDR
> >>> +     depends on SPL_HAS_BSS_LINKER_SECTION
> >>
> >> This change is causing make to prompt for SPL_BSS_MAX_SIZE when building
> >> e.g. tinker-s-rk3288_defconfig.
> >>
> >>   Maximum size in memory allocated to the SPL BSS (SPL_BSS_MAX_SIZE) [] (NEW)
> >>
> >>>       default 0x63f80000 if SPL_TEXT_BASE = 0x60000000
> >>>       default 0x43f80000 if SPL_TEXT_BASE = 0x40000000
> >>>       default 0x03f80000 if SPL_TEXT_BASE = 0x00000000
> >>>
> >>>  config SPL_BSS_MAX_SIZE
> >>> +     depends on SPL_BSS_LIMIT
> >>>       default 0x8000 if SPL_BSS_START_ADDR = 0x63f80000
> >>>       default 0x8000 if SPL_BSS_START_ADDR = 0x43f80000
> >>>       default 0x8000 if SPL_BSS_START_ADDR = 0x03f80000
> >>
> >> Possible adding something like following?
> >>
> >>         default 0x8000 if !SPL_HAS_BSS_LINKER_SECTION
> >
> > What about selecting SPL_BSS_MAX_SIZE default based on SPL_TEXT_BASE instead of
> > SPL_BSS_START_ADDR?
>
> Unsure, the original intent of the BSS_START_ADDR dependency was to only
> affect boards that had transitioned to use the common bss and stack
> addresses introduced in the commit 008ba0d56d00 ("rockchip: Add common
> default bss and stack addresses").
>
> Not fully sure about current migration state for AArch64 targets, I do
> not have any rk3368 boards so never tried to migrate targets for that
> SoC to use these common addresses. Most/all other AArch64 targets should
> now use these defaults so it is likely these checks can be simplified.
>
> >
> > This seems to me more straightforward. As this configuration states, there are
> > cases where SPL_HAS_BSS_LINKER_SECTION (and thus SPL_BSS_START_ADDR) is not
> > needed, but SPL_BSS_MAX_SIZE is. Therefore, I would avoid a default definition
> > based on SPL_BSS_START_ADDR.
>
> It is likely these complex conditions have overplayed its need now that
> most AArch64 targets have been migrated to use these defaults.
>
> >
> > On the other hand, I've just noticed that the value is the same in the three
> > SPL_BSS_MAX_SIZE default statements, so it would probably be even clearer to
> > have something like (not tested yet):
> >
> > config SPL_BSS_MAX_SIZE
> >     default 0x8000 if SPL_BSS_LIMIT
> >
> > What do you think? Thanks for your revision.
>
> Please check current values used for ARCH_ROCKCHIP boards using the
> qconfig.py tool. If all boards use this value, we can likely just move
> this default to normal "config SPL_BSS_MAX_SIZE" in common/spl/Kconfig.
>
>         default 0x8000 if ARCH_ROCKCHIP

I will check. Thanks for your time in reviewing my patch.

Regards,
Massimo

>
> One goal should be to continue migrate as many boards/SoCs to use the
> common bss and stack addresses. It should mostly be older ARMv7 SoCs
> that I do not have access to that never have been migrated. I do have
> access to rk322x boxes, and have some early work for that SoC, but too
> much other work to try and upstream before circling back to rk322x :-)
>
> Regards,
> Jonas
>
> >
> > Regards,
> > Massimo
> >
> >>
> >> Regards,
> >> Jonas
>

Re: [PATCH 3/4] arm: rockchip: Avoid BSS SPL config options when unneeded

[Quentin Schulz]

Hi Massimo,

On 10/2/26 6:36 PM, Massimo Pegorer wrote:
> The configuration options SPL_BSS_START_ADDR and SPL_BSS_MAX_SIZE are
> guarded by SPL_HAS_BSS_LINKER_SECTION and SPL_BSS_LIMIT options in the
> common/spl/Kconfig file where they are originally defined. Addition of
> a second config statement without 'depends on' guard causes these two
> options to be put in the configuration even when the guard is not
> selected, which is unneeded and sounds wrong.
> 

I'm sorry, I don't understand the issue. Can you clarify or provide a 
way to reproduce the issue? Multiple definitions of the same Kconfig 
symbol are "combined" as far as I know so this shouldn't be an issue.

Cheers,
Quentin

> Signed-off-by: Massimo Pegorer <massimo.pegorer+oss@gmail.com>
> ---
>   arch/arm/mach-rockchip/Kconfig | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
> index 1a2e7847c9e..5ed774159be 100644
> --- a/arch/arm/mach-rockchip/Kconfig
> +++ b/arch/arm/mach-rockchip/Kconfig
> @@ -836,11 +836,13 @@ config SPL_HAS_BSS_LINKER_SECTION
>   	default y if ARM64
>   
>   config SPL_BSS_START_ADDR
> +	depends on SPL_HAS_BSS_LINKER_SECTION
>   	default 0x63f80000 if SPL_TEXT_BASE = 0x60000000
>   	default 0x43f80000 if SPL_TEXT_BASE = 0x40000000
>   	default 0x03f80000 if SPL_TEXT_BASE = 0x00000000
>   
>   config SPL_BSS_MAX_SIZE
> +	depends on SPL_BSS_LIMIT
>   	default 0x8000 if SPL_BSS_START_ADDR = 0x63f80000
>   	default 0x8000 if SPL_BSS_START_ADDR = 0x43f80000
>   	default 0x8000 if SPL_BSS_START_ADDR = 0x03f80000
> 

Re: [PATCH 3/4] arm: rockchip: Avoid BSS SPL config options when unneeded

[Massimo Pegorer]

Hi Quentin,

Il giorno mer 14 ott 2026 alle ore 18:25 Quentin Schulz
<u-boot@0leil.net> ha scritto:
>
> Hi Massimo,
>
> On 10/2/26 6:36 PM, Massimo Pegorer wrote:
> > The configuration options SPL_BSS_START_ADDR and SPL_BSS_MAX_SIZE are
> > guarded by SPL_HAS_BSS_LINKER_SECTION and SPL_BSS_LIMIT options in the
> > common/spl/Kconfig file where they are originally defined. Addition of
> > a second config statement without 'depends on' guard causes these two
> > options to be put in the configuration even when the guard is not
> > selected, which is unneeded and sounds wrong.
> >
>
> I'm sorry, I don't understand the issue. Can you clarify or provide a
> way to reproduce the issue? Multiple definitions of the same Kconfig
> symbol are "combined" as far as I know so this shouldn't be an issue.

The reasoning is almost the same I've tried to explain in [1]. Sorry if it
sounds like ancillary changes. But in this way qconfig tool is more effective
and helpful.

Thanks.
Massimo

[1] https://lore.kernel.org/all/CAC928HYUq6rijik177mTxMt7Khu8QBwywrt2H2f6CX8z1r0aVQ@mail.gmail.com/

>
> Cheers,
> Quentin
>
> > Signed-off-by: Massimo Pegorer <massimo.pegorer+oss@gmail.com>
> > ---
> >   arch/arm/mach-rockchip/Kconfig | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
> > index 1a2e7847c9e..5ed774159be 100644
> > --- a/arch/arm/mach-rockchip/Kconfig
> > +++ b/arch/arm/mach-rockchip/Kconfig
> > @@ -836,11 +836,13 @@ config SPL_HAS_BSS_LINKER_SECTION
> >       default y if ARM64
> >
> >   config SPL_BSS_START_ADDR
> > +     depends on SPL_HAS_BSS_LINKER_SECTION
> >       default 0x63f80000 if SPL_TEXT_BASE = 0x60000000
> >       default 0x43f80000 if SPL_TEXT_BASE = 0x40000000
> >       default 0x03f80000 if SPL_TEXT_BASE = 0x00000000
> >
> >   config SPL_BSS_MAX_SIZE
> > +     depends on SPL_BSS_LIMIT
> >       default 0x8000 if SPL_BSS_START_ADDR = 0x63f80000
> >       default 0x8000 if SPL_BSS_START_ADDR = 0x43f80000
> >       default 0x8000 if SPL_BSS_START_ADDR = 0x03f80000
> >
>

[PATCH 4/4] arm: rockchip: Remove useless SPL_SHARES_INIT_SP_ADDR check

[Massimo Pegorer]

The ROCKCHIP_COMMON_STACK_ADDR configuration option depends on
SPL_SHARES_INIT_SP_ADDR, therefore the logical AND of the two options
values is equal to the to value of ROCKCHIP_COMMON_STACK_ADDR.

Signed-off-by: Massimo Pegorer <massimo.pegorer+oss@gmail.com>
---
 arch/arm/mach-rockchip/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
index 5ed774159be..8e377066a43 100644
--- a/arch/arm/mach-rockchip/Kconfig
+++ b/arch/arm/mach-rockchip/Kconfig
@@ -798,7 +798,7 @@ source "arch/arm/mach-rockchip/rk3588/Kconfig"
 source "arch/arm/mach-rockchip/rv1108/Kconfig"
 source "arch/arm/mach-rockchip/rv1126/Kconfig"
 
-if ROCKCHIP_COMMON_STACK_ADDR && SPL_SHARES_INIT_SP_ADDR
+if ROCKCHIP_COMMON_STACK_ADDR
 
 config CUSTOM_SYS_INIT_SP_ADDR
 	default 0x63f00000 if SPL_TEXT_BASE = 0x60000000

-- 
2.34.1

Re: [PATCH 4/4] arm: rockchip: Remove useless SPL_SHARES_INIT_SP_ADDR check

[Jonas Karlman]

Hi Massimo,

Please use more neutral wording than 'useless' in subject and messages,
e.g. unneeded or unnecessary.

On 10/2/2026 6:36 PM, Massimo Pegorer wrote:
> The ROCKCHIP_COMMON_STACK_ADDR configuration option depends on
> SPL_SHARES_INIT_SP_ADDR, therefore the logical AND of the two options
> values is equal to the to value of ROCKCHIP_COMMON_STACK_ADDR.
> 
> Signed-off-by: Massimo Pegorer <massimo.pegorer+oss@gmail.com>
> ---
>  arch/arm/mach-rockchip/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
> index 5ed774159be..8e377066a43 100644
> --- a/arch/arm/mach-rockchip/Kconfig
> +++ b/arch/arm/mach-rockchip/Kconfig
> @@ -798,7 +798,7 @@ source "arch/arm/mach-rockchip/rk3588/Kconfig"
>  source "arch/arm/mach-rockchip/rv1108/Kconfig"
>  source "arch/arm/mach-rockchip/rv1126/Kconfig"
>  
> -if ROCKCHIP_COMMON_STACK_ADDR && SPL_SHARES_INIT_SP_ADDR
> +if ROCKCHIP_COMMON_STACK_ADDR

I am pretty sure this was needed with the older Kconfig, however I was
not able to reproduce such issue, also possible the 'depends on' was
missing during early work on this.

With rewording this is:

Reviewed-by: Jonas Karlman <jonas@kwiboo.se>

Regards,
Jonas

>  
>  config CUSTOM_SYS_INIT_SP_ADDR
>  	default 0x63f00000 if SPL_TEXT_BASE = 0x60000000
> 

Re: [PATCH 4/4] arm: rockchip: Remove useless SPL_SHARES_INIT_SP_ADDR check

[Massimo Pegorer]

Hi Jonas,

Il giorno dom 4 ott 2026 alle ore 20:40 Jonas Karlman
<jonas@kwiboo.se> ha scritto:
>
> Hi Massimo,
>
> Please use more neutral wording than 'useless' in subject and messages,
> e.g. unneeded or unnecessary.

Sure! I will reword in v2.

Sorry, but my limited fluency in English makes me numb to such semantic and
usage nuances. Any suggestions and lessons are really appreciated. Thanks.

>
> On 10/2/2026 6:36 PM, Massimo Pegorer wrote:
> > The ROCKCHIP_COMMON_STACK_ADDR configuration option depends on
> > SPL_SHARES_INIT_SP_ADDR, therefore the logical AND of the two options
> > values is equal to the to value of ROCKCHIP_COMMON_STACK_ADDR.
> >
> > Signed-off-by: Massimo Pegorer <massimo.pegorer+oss@gmail.com>
> > ---
> >  arch/arm/mach-rockchip/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
> > index 5ed774159be..8e377066a43 100644
> > --- a/arch/arm/mach-rockchip/Kconfig
> > +++ b/arch/arm/mach-rockchip/Kconfig
> > @@ -798,7 +798,7 @@ source "arch/arm/mach-rockchip/rk3588/Kconfig"
> >  source "arch/arm/mach-rockchip/rv1108/Kconfig"
> >  source "arch/arm/mach-rockchip/rv1126/Kconfig"
> >
> > -if ROCKCHIP_COMMON_STACK_ADDR && SPL_SHARES_INIT_SP_ADDR
> > +if ROCKCHIP_COMMON_STACK_ADDR
>
> I am pretty sure this was needed with the older Kconfig, however I was
> not able to reproduce such issue, also possible the 'depends on' was
> missing during early work on this.

It is quite common for something to be needed in a context, but later on, when
the context changes, something that was needed can become unnecessary. And in
many cases, it is really difficult to catch it at that moment because it does
not break anything, it is just redundant. I've stumbled upon it by accident,
reasoning about the linker scripts' logic and implications.

Thanks for your review!

Regards,
Massimo


>
> With rewording this is:
>
> Reviewed-by: Jonas Karlman <jonas@kwiboo.se>
>
> Regards,
> Jonas
>
> >
> >  config CUSTOM_SYS_INIT_SP_ADDR
> >       default 0x63f00000 if SPL_TEXT_BASE = 0x60000000
> >
>

Re: [PATCH 4/4] arm: rockchip: Remove useless SPL_SHARES_INIT_SP_ADDR check

[Quentin Schulz]

Hi Massimo,

On 10/2/26 6:36 PM, Massimo Pegorer wrote:
> The ROCKCHIP_COMMON_STACK_ADDR configuration option depends on
> SPL_SHARES_INIT_SP_ADDR, therefore the logical AND of the two options
> values is equal to the to value of ROCKCHIP_COMMON_STACK_ADDR.
> 

Fixes: 008ba0d56d00 ("rockchip: Add common default bss and stack addresses")
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin