From: sashiko-bot--- via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: "Andrey Albershteyn via Linux-f2fs-devel"
<linux-f2fs-devel@lists.sourceforge.net>
Cc: sashiko-bot@kernel.org, linux-ext4@vger.kernel.org,
tytso@mit.edu, dsterba@suse.cz
Subject: Re: [f2fs-dev] [PATCH v17 14/21] xfs: don't remove written extents past EOF on fsverity inodes
Date: Sat, 03 Oct 2026 01:34:21 +0000 [thread overview]
Message-ID: <20261003013421.AC2691F00898@smtp.kernel.org> (raw)
In-Reply-To: <20261002223705.2175542-15-aalbersh@kernel.org>
> xfs_free_eofblocks() removes all extents past EOF unless the
> XFS_DIFLAG_PREALLOC or XFS_DIFLAG_APPEND flags are set. This is
> undesired for fsverity as it stores metadata beyond EOF. However, while
> merkle tree is being built, delayed preallocation and unwritten extents
> are used. After metadata construction is done, fsverity inodes becomes
> read-only and won't be changed anymore, none of these unwritten extents
> or preallocations in post EOF region will be used.
>
> Let xfs_free_eofblocks() be called on fsverity inode as usual to remove
> anything which is not written extent. However, inodes which are
> undergoing merkle tree construction need to be skipped in case reclaim
> takes place.
>
> Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261002223705.2175542-1-aalbersh@kernel.org?part=14
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: sashiko-bot@kernel.org
To: "Andrey Albershteyn via Linux-f2fs-devel"
<linux-f2fs-devel@lists.sourceforge.net>
Cc: dsterba@suse.cz, tytso@mit.edu, linux-ext4@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v17 14/21] xfs: don't remove written extents past EOF on fsverity inodes
Date: Sat, 03 Oct 2026 01:34:21 +0000 [thread overview]
Message-ID: <20261003013421.AC2691F00898@smtp.kernel.org> (raw)
In-Reply-To: <20261002223705.2175542-15-aalbersh@kernel.org>
> xfs_free_eofblocks() removes all extents past EOF unless the
> XFS_DIFLAG_PREALLOC or XFS_DIFLAG_APPEND flags are set. This is
> undesired for fsverity as it stores metadata beyond EOF. However, while
> merkle tree is being built, delayed preallocation and unwritten extents
> are used. After metadata construction is done, fsverity inodes becomes
> read-only and won't be changed anymore, none of these unwritten extents
> or preallocations in post EOF region will be used.
>
> Let xfs_free_eofblocks() be called on fsverity inode as usual to remove
> anything which is not written extent. However, inodes which are
> undergoing merkle tree construction need to be skipped in case reclaim
> takes place.
>
> Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261002223705.2175542-1-aalbersh@kernel.org?part=14
next prev parent reply other threads:[~2026-10-03 1:34 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 22:36 [PATCH v17 00/21] fs-verity support for XFS with post EOF merkle tree Andrey Albershteyn
2026-10-02 22:36 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-10-02 22:36 ` [PATCH v17 01/21] fsverity: report validation errors through fserror to fsnotify Andrey Albershteyn
2026-10-02 22:36 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot--- via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot
2026-10-02 22:36 ` [PATCH v17 02/21] fsverity: expose ensure_fsverity_info() Andrey Albershteyn
2026-10-02 22:36 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot--- via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot
2026-10-02 22:36 ` [PATCH v17 03/21] fsverity: pass digest size and hash of the all-zeroes block to ->write Andrey Albershteyn
2026-10-02 22:36 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot--- via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot
2026-10-02 22:36 ` [PATCH v17 04/21] fsverity: hoist pagecache_read from f2fs/ext4 to fsverity Andrey Albershteyn
2026-10-02 22:36 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot--- via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot
2026-10-02 22:36 ` [PATCH v17 05/21] fsverity: don't allow setting DAX file attribute on fsverity files Andrey Albershteyn
2026-10-02 22:36 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot
2026-10-02 22:36 ` [PATCH v17 06/21] fsverity: hoist statx reporting of fs-verity flag Andrey Albershteyn
2026-10-02 22:36 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot
2026-10-02 22:36 ` [PATCH v17 07/21] xfs: introduce fsverity on-disk changes Andrey Albershteyn
2026-10-02 22:36 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot
2026-10-02 22:36 ` [PATCH v17 08/21] xfs: don't allow to enable DAX on fs-verity sealed inode Andrey Albershteyn
2026-10-02 22:36 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot
2026-10-02 22:36 ` [PATCH v17 09/21] xfs: disable direct read path for fs-verity files Andrey Albershteyn
2026-10-02 22:36 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot--- via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot
2026-10-02 22:36 ` [PATCH v17 10/21] xfs: don't report dio_mem_align and dio_offset_align for fsverity files Andrey Albershteyn
2026-10-02 22:36 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot--- via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot
2026-10-02 22:36 ` [PATCH v17 11/21] xfs: handle fsverity I/O in write/read path Andrey Albershteyn
2026-10-02 22:36 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot--- via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot
2026-10-02 22:36 ` [PATCH v17 12/21] xfs: use read ioend for fsverity data verification Andrey Albershteyn
2026-10-02 22:36 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot--- via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot
2026-10-02 22:36 ` [PATCH v17 13/21] xfs: add XFS_BMAPI_UNWRITTEN to unmap unwritten extents in __xfs_bunmapi() Andrey Albershteyn
2026-10-02 22:36 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot--- via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot
2026-10-02 22:36 ` [PATCH v17 14/21] xfs: don't remove written extents past EOF on fsverity inodes Andrey Albershteyn
2026-10-02 22:36 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot--- via Linux-f2fs-devel [this message]
2026-10-03 1:34 ` sashiko-bot
2026-10-02 22:36 ` [PATCH v17 15/21] xfs: add fs-verity support Andrey Albershteyn
2026-10-02 22:36 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot--- via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot
2026-10-05 17:18 ` Andrey Albershteyn
2026-10-05 17:18 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-10-05 21:12 ` Darrick J. Wong
2026-10-05 21:12 ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-10-06 9:03 ` Andrey Albershteyn
2026-10-06 9:03 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-10-02 22:36 ` [PATCH v17 16/21] xfs: initialize fs-verity on file open Andrey Albershteyn
2026-10-02 22:36 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot--- via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot
2026-10-02 22:36 ` [PATCH v17 17/21] xfs: add fs-verity ioctls Andrey Albershteyn
2026-10-02 22:36 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot--- via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot
2026-10-02 22:36 ` [PATCH v17 18/21] xfs: advertise fs-verity being available on filesystem Andrey Albershteyn
2026-10-02 22:36 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot--- via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot
2026-10-02 22:37 ` [PATCH v17 19/21] xfs: check and repair the verity inode flag state Andrey Albershteyn
2026-10-02 22:37 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot--- via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot
2026-10-02 22:37 ` [PATCH v17 20/21] xfs: introduce health state for corrupted fsverity metadata Andrey Albershteyn
2026-10-02 22:37 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot--- via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot
2026-10-02 22:37 ` [PATCH v17 21/21] xfs: enable ro-compat fs-verity flag Andrey Albershteyn
2026-10-02 22:37 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot--- via Linux-f2fs-devel
2026-10-03 1:34 ` sashiko-bot
2026-10-02 23:25 ` [PATCH v17 00/21] fs-verity support for XFS with post EOF merkle tree Eric Biggers
2026-10-02 23:25 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
2026-10-03 12:07 ` Carlos Maiolino
2026-10-03 12:07 ` [f2fs-dev] " Carlos Maiolino via Linux-f2fs-devel
2026-10-05 11:26 ` Andrey Albershteyn
2026-10-05 11:26 ` [f2fs-dev] " Andrey Albershteyn via Linux-f2fs-devel
2026-10-05 13:30 ` Eric Biggers
2026-10-05 13:30 ` [f2fs-dev] " Eric Biggers via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261003013421.AC2691F00898@smtp.kernel.org \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=dsterba@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.