From: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: mallesh.koujalagi@intel.com,
Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
Subject: [PATCH v5 12/12] drm/xe/vram: Report VRAM errors using structured xe_log API
Date: Thu, 8 Oct 2026 02:44:17 +0530 [thread overview]
Message-ID: <20261007211417.2093611-13-dnyaneshwar.bhadane@intel.com> (raw)
In-Reply-To: <20261007211417.2093611-1-dnyaneshwar.bhadane@intel.com>
Replace few drm_err()/drm_info() with xe_log_err_fatal()/xe_log_info()
using the VRAM component tag. The "no CPU visible VRAM" error uses
tile or device as the log location depending on the caller context.
Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
---
v2:
- Update the ternary condition (Mallesh)
---
---
drivers/gpu/drm/xe/xe_vram.c | 27 +++++++++++++++------------
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_vram.c b/drivers/gpu/drm/xe/xe_vram.c
index 2441ffe77edb..d44a92e97195 100644
--- a/drivers/gpu/drm/xe/xe_vram.c
+++ b/drivers/gpu/drm/xe/xe_vram.c
@@ -17,6 +17,7 @@
#include "xe_device.h"
#include "xe_force_wake.h"
#include "xe_gt_mcr.h"
+#include "xe_log.h"
#include "xe_map.h"
#include "xe_migrate.h"
#include "xe_mmio.h"
@@ -46,7 +47,8 @@ static int determine_lmem_bar_size(struct xe_device *xe, struct xe_vram_region *
struct pci_dev *pdev = to_pci_dev(xe->drm.dev);
if (!resource_is_valid(pdev, LMEM_BAR)) {
- drm_err(&xe->drm, "pci resource is not valid\n");
+ xe_log_err_fatal(xe, VRAM, -ENXIO,
+ "PCI resource is not valid\n");
return -ENXIO;
}
@@ -227,15 +229,14 @@ struct xe_vram_region *xe_vram_region_alloc(struct xe_device *xe, u8 id, u32 pla
static void print_vram_region_info(struct xe_device *xe, struct xe_vram_region *vram)
{
- struct drm_device *drm = &xe->drm;
if (vram->io_size < vram->usable_size)
- drm_info(drm, "Small BAR device\n");
+ xe_log_info(xe, VRAM, "Small BAR device\n");
- drm_info(drm,
- "VRAM[%u]: Actual physical size %pa, usable size exclude stolen %pa, CPU accessible size %pa\n",
- vram->id, &vram->actual_physical_size, &vram->usable_size, &vram->io_size);
- drm_info(drm, "VRAM[%u]: DPA range: [%pa-%llx], io range: [%pa-%llx]\n",
+ xe_log_info(xe, VRAM,
+ "VRAM[%u]: Actual physical size %pa, usable size exclude stolen %pa, CPU accessible size %pa\n",
+ vram->id, &vram->actual_physical_size, &vram->usable_size, &vram->io_size);
+ xe_log_info(xe, VRAM, "VRAM[%u]: DPA range: [%pa-%llx], io range: [%pa-%llx]\n",
vram->id, &vram->dpa_base, vram->dpa_base + (u64)vram->actual_physical_size,
&vram->io_start, vram->io_start + (u64)vram->io_size);
}
@@ -254,8 +255,9 @@ static int vram_region_init(struct xe_device *xe, struct xe_vram_region *vram,
vram->io_size = min_t(u64, usable_size, remain_io_size);
if (!vram->io_size) {
- drm_err(&xe->drm, "%s without any CPU visible VRAM. Aborting.\n",
- tile ? "Tile" : "Device");
+ xe_log_err_fatal(xe, VRAM, -ENODEV,
+ "%s without any CPU visible VRAM. Aborting.\n",
+ tile ? "Tile" : "Device");
return -ENODEV;
}
@@ -320,7 +322,7 @@ int xe_vram_probe(struct xe_device *xe)
err = determine_lmem_bar_size(xe, &lmem_bar);
if (err)
return err;
- drm_info(&xe->drm, "VISIBLE VRAM: %pa, %pa\n", &lmem_bar.io_start, &lmem_bar.io_size);
+ xe_log_info(xe, VRAM, "VISIBLE VRAM: %pa, %pa\n", &lmem_bar.io_start, &lmem_bar.io_size);
remain_io_size = lmem_bar.io_size;
@@ -342,8 +344,9 @@ int xe_vram_probe(struct xe_device *xe)
return err;
if (total_size > lmem_bar.io_size) {
- drm_info(&xe->drm, "VRAM: %pa is larger than resource %pa\n",
- &total_size, &lmem_bar.io_size);
+ xe_log_info(xe, VRAM,
+ "Total size %pa is larger than resource %pa\n",
+ &total_size, &lmem_bar.io_size);
}
remain_io_size -= min_t(u64, tile->mem.vram->actual_physical_size, remain_io_size);
--
2.54.0
next prev parent reply other threads:[~2026-10-07 21:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 21:14 [PATCH v5 00/12] drm/xe: Convert IO_BUS errors to structured xe_log API Dnyaneshwar Bhadane
2026-10-07 21:14 ` [PATCH v5 01/12] drm/xe/log: Add VRAM, PAT, and HWMON DRIVER_HARDWARE components Dnyaneshwar Bhadane
2026-10-08 13:59 ` Mallesh, Koujalagi
2026-10-07 21:14 ` [PATCH v5 02/12] drm/xe/ggtt: Report GGTT errors using structured logging Dnyaneshwar Bhadane
2026-10-07 21:14 ` [PATCH v5 03/12] drm/xe/hwmon: Report errors using structured xe_log API Dnyaneshwar Bhadane
2026-10-08 13:01 ` Mallesh, Koujalagi
2026-10-07 21:14 ` [PATCH v5 04/12] drm/xe/mmio: Report BAR mapping " Dnyaneshwar Bhadane
2026-10-07 21:14 ` [PATCH v5 05/12] drm/xe/memirq: Report " Dnyaneshwar Bhadane
2026-10-07 21:20 ` sashiko-bot
2026-10-07 21:14 ` [PATCH v5 06/12] drm/xe/reg_sr: Report save-restore " Dnyaneshwar Bhadane
2026-10-07 21:23 ` sashiko-bot
2026-10-08 13:45 ` Mallesh, Koujalagi
2026-10-07 21:14 ` [PATCH v5 07/12] drm/xe/pat: Return error from xe_pat_init_early() on unknown platform Dnyaneshwar Bhadane
2026-10-07 21:14 ` [PATCH v5 08/12] drm/xe/pat: Report missing PAT table using structured xe_log API Dnyaneshwar Bhadane
2026-10-07 21:14 ` [PATCH v5 09/12] drm/xe/pci: Report unknown GMDID versions " Dnyaneshwar Bhadane
2026-10-07 21:14 ` [PATCH v5 10/12] drm/xe/lmtt: Report invalidation errors " Dnyaneshwar Bhadane
2026-10-08 13:07 ` Mallesh, Koujalagi
2026-10-07 21:14 ` [PATCH v5 11/12] drm/xe/vram: Report tile vs device VRAM visibility errors Dnyaneshwar Bhadane
2026-10-08 13:25 ` Mallesh, Koujalagi
2026-10-07 21:14 ` Dnyaneshwar Bhadane [this message]
2026-10-07 21:19 ` [PATCH v5 12/12] drm/xe/vram: Report VRAM errors using structured xe_log API sashiko-bot
2026-10-07 21:40 ` ✗ CI.checkpatch: warning for drm/xe: Convert IO_BUS errors to structured xe_log API (rev5) Patchwork
2026-10-07 21:42 ` ✓ CI.KUnit: success " Patchwork
2026-10-07 22:32 ` ✓ Xe.CI.BAT: " Patchwork
2026-10-08 2:59 ` ✗ Xe.CI.FULL: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261007211417.2093611-13-dnyaneshwar.bhadane@intel.com \
--to=dnyaneshwar.bhadane@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=mallesh.koujalagi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.