Re: [PATCH v5 03/12] drm/xe/hwmon: Report errors using structured xe_log API

["Mallesh, Koujalagi" <mallesh.koujalagi@intel.com>]

On 08-10-2026 02:44 am, Dnyaneshwar Bhadane wrote:
> Replace drm_err() calls with xe_log_err() using the HWMON component
> tag to enable structured error reporting with SIGID for hardware
> monitor failures:
>
> Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
LGTM,
Reviewed-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
> ---
> v2:
>   - Store error in local variable err (Mallesh)
> ---
> ---
>   drivers/gpu/drm/xe/xe_hwmon.c | 15 +++++++++------
>   1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
> index 5edeac961ec3..fa5473ed6e7f 100644
> --- a/drivers/gpu/drm/xe/xe_hwmon.c
> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
> @@ -15,6 +15,7 @@
>   #include "regs/xe_pcode_regs.h"
>   #include "xe_device.h"
>   #include "xe_hwmon.h"
> +#include "xe_log.h"
>   #include "xe_mmio.h"
>   #include "xe_pcode.h"
>   #include "xe_pcode_api.h"
> @@ -558,9 +559,9 @@ xe_hwmon_power_max_interval_show(struct device *dev, struct device_attribute *at
>   	if (hwmon->xe->info.has_mbx_power_limits) {
>   		ret = xe_hwmon_pcode_read_power_limit(hwmon, power_attr, channel, &reg_val);
>   		if (ret) {
> -			drm_err(&hwmon->xe->drm,
> -				"power interval read fail, ch %d, attr %d, val 0x%08x, ret %d\n",
> -				channel, power_attr, reg_val, ret);
> +			xe_log_err(hwmon->xe, HWMON, ret,
> +				   "Power interval read fail, ch %d, attr %d, val 0x%08x\n",
> +				   channel, power_attr, reg_val);
>   			reg_val = 0;
>   		}
>   	} else {
> @@ -1563,7 +1564,7 @@ int xe_hwmon_register(struct xe_device *xe)
>   {
>   	struct device *dev = xe->drm.dev;
>   	struct xe_hwmon *hwmon;
> -	int ret;
> +	int ret, err;
>   
>   	/* hwmon is available only for dGfx */
>   	if (!IS_DGFX(xe))
> @@ -1594,9 +1595,11 @@ int xe_hwmon_register(struct xe_device *xe)
>   								&hwmon_chip_info,
>   								hwmon_groups);
>   	if (IS_ERR(hwmon->hwmon_dev)) {
> -		drm_err(&xe->drm, "Failed to register xe hwmon (%pe)\n", hwmon->hwmon_dev);
> +		err = PTR_ERR(hwmon->hwmon_dev);
> +		xe_log_err(xe, HWMON, err,
> +			   "Failed to register xe hwmon\n");
>   		xe->hwmon = NULL;
> -		return PTR_ERR(hwmon->hwmon_dev);
> +		return err;
>   	}
>   
>   	return 0;