Enabling Sashiko replies to linux-crypto?

Enabling Sashiko replies to linux-crypto?

[Eric Biggers]

Currently, Sashiko is configured (in
https://github.com/sashiko-dev/sashiko/blob/main/projects/linux/mailing_lists.toml)
to monitor linux-crypto for patches, but not to send emails to it.

Would there be any objections to me opening a pull request that changes
it to the same setting that I set the fscrypt and fsverity lists to?

    ["linux-crypto@vger.kernel.org"]
    reply_to = ["author", "list", "recipients"]

That would enable emails for issues found, with reply-all.

(There's also a 'positive_review = "all"' setting that would enable
emails for positive reviews, i.e. "Sashiko has reviewed this patch and
found no issues. It looks great!"  But those are kind of noisy.)

- Eric

Re: Enabling Sashiko replies to linux-crypto?

[Jason A. Donenfeld]

I was looking to do this on the wireguard mailing list too. (I have
some review comments on a PR I need to address for that.) No
objections from me.

Re: Enabling Sashiko replies to linux-crypto?

[Herbert Xu]

On Tue, Oct 20, 2026 at 09:57:44PM +0000, Eric Biggers wrote:
> Currently, Sashiko is configured (in
> https://github.com/sashiko-dev/sashiko/blob/main/projects/linux/mailing_lists.toml)
> to monitor linux-crypto for patches, but not to send emails to it.
> 
> Would there be any objections to me opening a pull request that changes
> it to the same setting that I set the fscrypt and fsverity lists to?
> 
>     ["linux-crypto@vger.kernel.org"]
>     reply_to = ["author", "list", "recipients"]
> 
> That would enable emails for issues found, with reply-all.
> 
> (There's also a 'positive_review = "all"' setting that would enable
> emails for positive reviews, i.e. "Sashiko has reviewed this patch and
> found no issues. It looks great!"  But those are kind of noisy.)

Sure that sounds like a good idea.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: Enabling Sashiko replies to linux-crypto?

[Thomas Huth]

On 20/10/2026 23.57, Eric Biggers wrote:
> Currently, Sashiko is configured (in
> https://github.com/sashiko-dev/sashiko/blob/main/projects/linux/mailing_lists.toml)
> to monitor linux-crypto for patches, but not to send emails to it.
> 
> Would there be any objections to me opening a pull request that changes
> it to the same setting that I set the fscrypt and fsverity lists to?
> 
>      ["linux-crypto@vger.kernel.org"]
>      reply_to = ["author", "list", "recipients"]
> 
> That would enable emails for issues found, with reply-all.
> 
> (There's also a 'positive_review = "all"' setting that would enable
> emails for positive reviews, i.e. "Sashiko has reviewed this patch and
> found no issues. It looks great!"  But those are kind of noisy.)
Is it possible to configure it in a way that it only sends mails if it 
really found something? ... always getting "Sashiko has reviewed this patch 
and it looks great" mails is rather annoying than helpful ...

  Thomas

Re: Enabling Sashiko replies to linux-crypto?

[Eric Biggers]

On Wed, Oct 21, 2026 at 08:18:18AM +0200, Thomas Huth wrote:
> On 20/10/2026 23.57, Eric Biggers wrote:
> > Currently, Sashiko is configured (in
> > https://github.com/sashiko-dev/sashiko/blob/main/projects/linux/mailing_lists.toml)
> > to monitor linux-crypto for patches, but not to send emails to it.
> > 
> > Would there be any objections to me opening a pull request that changes
> > it to the same setting that I set the fscrypt and fsverity lists to?
> > 
> >      ["linux-crypto@vger.kernel.org"]
> >      reply_to = ["author", "list", "recipients"]
> > 
> > That would enable emails for issues found, with reply-all.
> > 
> > (There's also a 'positive_review = "all"' setting that would enable
> > emails for positive reviews, i.e. "Sashiko has reviewed this patch and
> > found no issues. It looks great!"  But those are kind of noisy.)
> Is it possible to configure it in a way that it only sends mails if it
> really found something? ... always getting "Sashiko has reviewed this patch
> and it looks great" mails is rather annoying than helpful ...

Yes, that's what I proposed above (and it's merged now).

- Eric