Re: [PATCH 1/2] configs: spacemit: k3: enable spi nor flash in main app

[Yixun Lan <dlan@kernel.org>]

Hi E Shattow,

Thanks for the patch

On 12:51 Tue 20 Oct     , E Shattow wrote:
> Enable sf command and env storage in SPI NOR flash.
..
> SPL is not yet
> upstream so this is only in the main app, and depends on vendor SPL for
> clocks setup ahead of SPI NOR flash probe.
> 
This could be added as additional info, but I'd rather not put in commit
meassage, maybe just put it under "---" scissors line for reference

For why depend on SPL for clock, reset setup.. I checked fsl_qspi.c,
there is no clock & reset enabling support currently, although SpacemiT
do provide those support, but I think it's another item need to improve,
and we could definitely address it in a separate thread..

> Signed-off-by: E Shattow <e@freeshell.de>
> ---
>  arch/riscv/cpu/k3/Kconfig     | 1 +
>  configs/spacemit_k3_defconfig | 6 ++++++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/arch/riscv/cpu/k3/Kconfig b/arch/riscv/cpu/k3/Kconfig
> index 5474ac112437..07b490a718dd 100644
> --- a/arch/riscv/cpu/k3/Kconfig
> +++ b/arch/riscv/cpu/k3/Kconfig
> @@ -14,5 +14,6 @@ config SPACEMIT_K3
>  	imply RISCV_TIMER if RISCV_SMODE
>  	imply CMD_CPU
>  	imply OF_UPSTREAM
> +	imply SPI
Any reason to add this dependency?

I'd prefer to put this config in defconfig, As I see K3 has 
no hard requirement for SPI support from architecture perspective

>  
>  endif
> diff --git a/configs/spacemit_k3_defconfig b/configs/spacemit_k3_defconfig
> index 586305c62322..b333e708d01b 100644
> --- a/configs/spacemit_k3_defconfig
> +++ b/configs/spacemit_k3_defconfig
> @@ -4,6 +4,8 @@ CONFIG_SYS_MALLOC_F_LEN=0x80000
>  CONFIG_NR_DRAM_BANKS=2
>  CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y
>  CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x102300000
> +CONFIG_ENV_SIZE=0x10000
> +CONFIG_ENV_OFFSET=0xa0000
>  CONFIG_DM_GPIO=y
>  CONFIG_DEFAULT_DEVICE_TREE="spacemit/k3-pico-itx"
>  CONFIG_SYS_BOOTM_LEN=0xa000000
> @@ -35,6 +37,8 @@ CONFIG_CMD_REGULATOR=y
>  CONFIG_CMD_FAT=y
>  CONFIG_CMD_FS_GENERIC=y
>  CONFIG_DEVICE_TREE_INCLUDES="spacemit-k3-u-boot.dtsi"
> +CONFIG_ENV_OVERWRITE=y
> +CONFIG_ENV_IS_IN_SPI_FLASH=y
>  CONFIG_NET_LWIP=y
>  CONFIG_NET_RANDOM_ETHADDR=y
>  CONFIG_SYSCON=y
> @@ -44,6 +48,7 @@ CONFIG_SPACEMIT_GPIO=y
>  CONFIG_DM_I2C=y
>  CONFIG_SYS_I2C_SPACEMIT_K1=y
>  CONFIG_MISC=y
> +CONFIG_SPI_FLASH_WINBOND=y
>  CONFIG_PHY_GIGE=y
>  CONFIG_DWC_ETH_QOS=y
>  CONFIG_DWC_ETH_QOS_SPACEMIT=y
> @@ -61,4 +66,5 @@ CONFIG_DEBUG_UART_SHIFT=2
>  CONFIG_DEBUG_UART_ANNOUNCE=y
>  CONFIG_SYS_NS16550=y
>  CONFIG_SYS_NS16550_MEM32=y
> +CONFIG_FSL_QSPI=y
>  CONFIG_TIMER_EARLY=y
> -- 
> 2.53.0
> 

-- 
Yixun Lan (dlan)