All of lore.kernel.org
 help / color / mirror / Atom feed
From: E Shattow <e@freeshell.de>
To: Yixun Lan <dlan@kernel.org>
Cc: u-boot@lists.u-boot-project.org,
	Tim Ouyang <tim609@andestech.com>,
	Leo Liang <leo.liang@sifive.com>, Yao Zi <me@ziyao.cc>,
	Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH 1/2] configs: spacemit: k3: enable spi nor flash in main app
Date: Wed, 21 Oct 2026 08:47:56 -0700	[thread overview]
Message-ID: <ed866aae-5434-4b7d-8732-bea60bb73cb1@freeshell.de> (raw)
In-Reply-To: <20261021080117-GKE65567@kernel.org>

Hi Yixun,

On 10/21/26 01:01, Yixun Lan wrote:
> Hi E Shattow,
> 
> one more comment
> 
> On 12:51 Tue 20 Oct     , E Shattow wrote:
>> Enable sf command and env storage in SPI NOR flash. SPL is not yet

Okay, I will adjust the commit message. Thanks for looking at fsl_qspi.c
this is a good report to learn it will need some work.

I have carefully constructed a build of SPL from
spacemit-com/uboot-2022.10 that is reduced to a minimum of build config
options. I'll make the requested changes and send a short write-up of
how I build this reduced vendor SPL, for a baseline of testing.

>> upstream so this is only in the main app, and depends on vendor SPL for
>> clocks setup ahead of SPI NOR flash probe.
>>
>> Signed-off-by: E Shattow <e@freeshell.de>
>> ---
>>  arch/riscv/cpu/k3/Kconfig     | 1 +
>>  configs/spacemit_k3_defconfig | 6 ++++++
>>  2 files changed, 7 insertions(+)
>>
> ..
>>  CONFIG_SYSCON=y
>> @@ -44,6 +48,7 @@ CONFIG_SPACEMIT_GPIO=y
>>  CONFIG_DM_I2C=y
>>  CONFIG_SYS_I2C_SPACEMIT_K1=y
>>  CONFIG_MISC=y
>> +CONFIG_SPI_FLASH_WINBOND=y
> I've also tested on com260 board which use GD25LQ64C chip, same 8MiB
> but need to enable CONFIG_SPI_FLASH_GIGADEVICE=y, the patch 2/2 also
> works on com260, so I'd suggest to make the commit message slightly
>  more generic? not specific for Pico-ITX board
> 
Great, adding this for extending support to CoM260, thank you.

-E

  reply	other threads:[~2026-10-21 15:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20 19:51 [PATCH 0/2] Enable SPI NOR flash for SpacemiT K3 in main app E Shattow
2026-10-20 19:51 ` [PATCH 1/2] configs: spacemit: k3: enable spi nor flash " E Shattow
2026-10-21  7:13   ` Yixun Lan
2026-10-21  7:37     ` E Shattow
2026-10-21  8:01   ` Yixun Lan
2026-10-21 15:47     ` E Shattow [this message]
2026-10-20 19:51 ` [PATCH 2/2] configs: spacemit: k3: enable mtdparts on Pico-ITX " E Shattow
2026-10-21  7:56   ` Yixun Lan
2026-10-21 14:35     ` E Shattow
2026-10-22  0:57       ` Yixun Lan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed866aae-5434-4b7d-8732-bea60bb73cb1@freeshell.de \
    --to=e@freeshell.de \
    --cc=dlan@kernel.org \
    --cc=leo.liang@sifive.com \
    --cc=me@ziyao.cc \
    --cc=tim609@andestech.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.u-boot-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.