All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Sasha Levin <sashal@kernel.org>
Cc: Thierry Reding <thierry.reding@kernel.org>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Lyude Paul <lyude@redhat.com>, Danilo Krummrich <dakr@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Alexandre Courbot <acourbot@nvidia.com>,
	Mikko Perttunen <mperttunen@nvidia.com>,
	Aaron Kling <webgeek1234@gmail.com>,
	Diogo Ivo <diogo.ivo@bootlin.com>,
	Svyatoslav Ryhel <clamor95@gmail.com>,
	Dmitry Osipenko <dmitry.osipenko@collabora.com>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] dt-bindings: gpu: nvidia,gk20a: Require the fuse clock
Date: Thu, 22 Oct 2026 08:59:38 -0500	[thread overview]
Message-ID: <20261022135938.GA937780-robh@kernel.org> (raw)
In-Reply-To: <20261016160700.3831336-2-sashal@kernel.org>

On Fri, Oct 16, 2026 at 12:06:54PM -0400, Sasha Levin wrote:
> The GM20B on Tegra210 often fails to initialize unless the fuse clock
> is running while the GPU is powered, and the GPUs on the other Tegra
> generations are expected to have the same requirement. Tegra194 already
> describes the fuse clock for its GV11B.
> 
> Make the fuse clock required for all of them, and list the exact clocks
> for each GPU instead of allowing either the reference or the fuse clock
> as the third one: GM20B takes the fuse clock after its reference clock,
> the others take it after the GPU and power clocks.
> 
> The nouveau driver keeps treating the fuse clock as optional, so device
> trees that lack it continue to work as before.
> 
> Assisted-by: LLM
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
>  .../devicetree/bindings/gpu/nvidia,gk20a.yaml | 52 ++++++++++++++-----
>  1 file changed, 40 insertions(+), 12 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/gpu/nvidia,gk20a.yaml b/Documentation/devicetree/bindings/gpu/nvidia,gk20a.yaml
> index 4d856a8b674c5..af0ada6e02557 100644
> --- a/Documentation/devicetree/bindings/gpu/nvidia,gk20a.yaml
> +++ b/Documentation/devicetree/bindings/gpu/nvidia,gk20a.yaml
> @@ -39,18 +39,12 @@ properties:
>        Regulator for GPU supply voltage
>  
>    clocks:
> -    minItems: 2
> -    items:
> -      - description: GPU clock
> -      - description: Power clock
> -      - description: Reference or fuse clock
> +    minItems: 3
> +    maxItems: 4
>  
>    clock-names:
> -    minItems: 2
> -    items:
> -      - const: gpu
> -      - const: pwr
> -      - enum: [ ref, fuse ]
> +    minItems: 3
> +    maxItems: 4

See my reply on v1. We want to keep the names defined at the top-level 
(to avoid ever variant making up their own names).

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Sasha Levin <sashal@kernel.org>
Cc: Thierry Reding <thierry.reding@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Alexandre Courbot <acourbot@nvidia.com>,
	Mikko Perttunen <mperttunen@nvidia.com>,
	Aaron Kling <webgeek1234@gmail.com>,
	Diogo Ivo <diogo.ivo@bootlin.com>,
	Svyatoslav Ryhel <clamor95@gmail.com>,
	Dmitry Osipenko <dmitry.osipenko@collabora.com>,
	Simona Vetter <simona@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] dt-bindings: gpu: nvidia,gk20a: Require the fuse clock
Date: Thu, 22 Oct 2026 08:59:38 -0500	[thread overview]
Message-ID: <20261022135938.GA937780-robh@kernel.org> (raw)
In-Reply-To: <20261016160700.3831336-2-sashal@kernel.org>

On Fri, Oct 16, 2026 at 12:06:54PM -0400, Sasha Levin wrote:
> The GM20B on Tegra210 often fails to initialize unless the fuse clock
> is running while the GPU is powered, and the GPUs on the other Tegra
> generations are expected to have the same requirement. Tegra194 already
> describes the fuse clock for its GV11B.
> 
> Make the fuse clock required for all of them, and list the exact clocks
> for each GPU instead of allowing either the reference or the fuse clock
> as the third one: GM20B takes the fuse clock after its reference clock,
> the others take it after the GPU and power clocks.
> 
> The nouveau driver keeps treating the fuse clock as optional, so device
> trees that lack it continue to work as before.
> 
> Assisted-by: LLM
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
>  .../devicetree/bindings/gpu/nvidia,gk20a.yaml | 52 ++++++++++++++-----
>  1 file changed, 40 insertions(+), 12 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/gpu/nvidia,gk20a.yaml b/Documentation/devicetree/bindings/gpu/nvidia,gk20a.yaml
> index 4d856a8b674c5..af0ada6e02557 100644
> --- a/Documentation/devicetree/bindings/gpu/nvidia,gk20a.yaml
> +++ b/Documentation/devicetree/bindings/gpu/nvidia,gk20a.yaml
> @@ -39,18 +39,12 @@ properties:
>        Regulator for GPU supply voltage
>  
>    clocks:
> -    minItems: 2
> -    items:
> -      - description: GPU clock
> -      - description: Power clock
> -      - description: Reference or fuse clock
> +    minItems: 3
> +    maxItems: 4
>  
>    clock-names:
> -    minItems: 2
> -    items:
> -      - const: gpu
> -      - const: pwr
> -      - enum: [ ref, fuse ]
> +    minItems: 3
> +    maxItems: 4

See my reply on v1. We want to keep the names defined at the top-level 
(to avoid ever variant making up their own names).

Rob

  parent reply	other threads:[~2026-10-22 13:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 16:06 [PATCH v2 0/6] Keep the fuse clock enabled while the Tegra GPU is powered Sasha Levin
2026-10-16 16:06 ` Sasha Levin
2026-10-16 16:06 ` [PATCH v2 1/6] dt-bindings: gpu: nvidia,gk20a: Require the fuse clock Sasha Levin
2026-10-16 16:06   ` [PATCH v2 1/6] dt-bindings: gpu: nvidia, gk20a: " Sasha Levin
2026-10-16 16:06   ` [PATCH v2 1/6] dt-bindings: gpu: nvidia,gk20a: " Sasha Levin
2026-10-16 16:13   ` sashiko-bot
2026-10-22 13:59   ` Rob Herring [this message]
2026-10-22 13:59     ` Rob Herring
2026-10-16 16:06 ` [PATCH v2 2/6] ARM: tegra: Add the fuse clock to the Tegra124 GPU Sasha Levin
2026-10-16 16:06   ` Sasha Levin
2026-10-16 16:06 ` [PATCH v2 3/6] arm64: tegra: Add the fuse clock to the Tegra132 GPU Sasha Levin
2026-10-16 16:06   ` Sasha Levin
2026-10-16 16:06 ` [PATCH v2 4/6] arm64: tegra: Add the fuse clock to the Tegra186 GPU Sasha Levin
2026-10-16 16:06   ` Sasha Levin
2026-10-16 16:06 ` [PATCH v2 5/6] arm64: tegra: Add the fuse clock to the Tegra210 GPU Sasha Levin
2026-10-16 16:06   ` Sasha Levin
2026-10-16 16:06 ` [PATCH v2 6/6] drm/nouveau/tegra: Keep the fuse clock enabled while the GPU is powered Sasha Levin
2026-10-16 16:06   ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261022135938.GA937780-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=clamor95@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=dakr@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=diogo.ivo@bootlin.com \
    --cc=dmitry.osipenko@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jonathanh@nvidia.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=lyude@redhat.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mperttunen@nvidia.com \
    --cc=mripard@kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=sashal@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=thierry.reding@kernel.org \
    --cc=tzimmermann@suse.de \
    --cc=webgeek1234@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.